From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF5EC433ED for ; Wed, 5 May 2021 12:42:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5627261222 for ; Wed, 5 May 2021 12:42:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5627261222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B29C76E43A; Wed, 5 May 2021 12:42:21 +0000 (UTC) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFFCF6E43A for ; Wed, 5 May 2021 12:42:20 +0000 (UTC) Received: by mail-lj1-x231.google.com with SMTP id w4so2239355ljw.9 for ; Wed, 05 May 2021 05:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y1dMmNrYG94oz59wSA/+KSKHQZ8uKPZPPZDXaMAM5W8=; b=vcvXLK0+9vUGAc43w/mbZ5NE5FEzq0eZhYhPjCCIqtvmStxUsJTFiVkZRA1v0txYaB DCFSTpmZ6WsKK0nkU5je18029+bxvISxDXzGZXrzNTvgh/CLftSjxSh+DGr/T7bD0M7v dDuB1CUoRpXvgiEACH5VJiiIZlJ/GVi64s7dqq5qBnV4+jg/KDihM5D/HxNJhuxFYFPP IFWjqWINXdVoXFxwOckn13jKIpK5KNE4/4/5622dIE1s8/XFDdGUESpL3Z+nZ6ictBMK MIJQya9vtz+LR/PthzdoVyRumDFZXqhfxhia9GXDoevnJ5HKROv6+EBTjJn8f0TzSDxJ Jp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y1dMmNrYG94oz59wSA/+KSKHQZ8uKPZPPZDXaMAM5W8=; b=EAHl3itvPcaxZcFb57kpl4NVx6lLIm4B6xU5HW4W2fgv24wMb27Qg9NqALdJYOPMZD tqgOXy95brif/eTDweRaBLaWZhyZpvpEAXPaj4rpfcsOfPtge/Xu4mOFm5JZiLKgqaCh o6mqesJfL3hlqugv5XjuPhSCLxBNzCXNybyGVtTMLkOcmuJo7sl+/U6UILQvFL4WLcWG 5/eUmoOX8Kyxs1Nn38fWGW5k0z+rQAcf6kOAG8FfV1b8OHL6lmy02o9MkdgiDTWE+9MS TBl+mY3h9c1aggFIxkDa7TVG8IYZZjTi43cjEXWRq/FqahedJB2Bets/g+Qv5FWApeTT y4bw== X-Gm-Message-State: AOAM532HnkEFltjAIxM0WxXwl51SMUwiCgWT+NahNN01/YdJllIkaPeg AdDCEbOr9TXCJ9gNKejSKgg9ZkBZGygusuPtXpTL7A== X-Google-Smtp-Source: ABdhPJwD2qv3lmY6EBn+J/conITkpSWX+6if1y8apZPxeEcCYZ5VCIWRQ1OX9U37hQtDNOzH+k4UKOHFPuUuT3pqLkw= X-Received: by 2002:a2e:814d:: with SMTP id t13mr2021863ljg.467.1620218539365; Wed, 05 May 2021 05:42:19 -0700 (PDT) MIME-Version: 1.0 References: <20210505100218.108024-1-marex@denx.de> <20210505100218.108024-2-marex@denx.de> In-Reply-To: <20210505100218.108024-2-marex@denx.de> From: Linus Walleij Date: Wed, 5 May 2021 14:42:08 +0200 Message-ID: Subject: Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver To: Marek Vasut X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Loic Poulain , ch@denx.de, Douglas Anderson , "open list:DRM PANEL DRIVERS" , Stephen Boyd , Philippe Schenker , Jagan Teki , Valentin Raevsky , Sam Ravnborg , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 5, 2021 at 12:03 PM Marek Vasut wrote: > Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge > and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS > bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, > but easy to add. > > The driver operates the chip via I2C bus. Currently the LVDS clock are > always derived from DSI clock lane, which is the usual mode of operation. > Support for clock from external oscillator is not implemented, but it is > easy to add if ever needed. Only RGB888 pixel format is implemented, the > LVDS666 is not supported, but could be added if needed. > > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Loic Poulain > Cc: Philippe Schenker > Cc: Sam Ravnborg > Cc: Stephen Boyd > Cc: Valentin Raevsky > To: dri-devel@lists.freedesktop.org This looks very nice to me, despite the complex nature of the driver it is a bliss to read this code with all nice comments and explanations. I don't know the gory details as well as the bridge maintainers but from my helicopter perspective, hats off. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel