From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator Date: Thu, 4 Oct 2018 11:02:10 +0200 Message-ID: References: <1147be600733a1bcde194f7df61866019f34a531.1538504729.git.leonard.crestez@nxp.com> <234ccbfccc26701bd0b9fd9cf2ffb5ad2414adec.camel@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <234ccbfccc26701bd0b9fd9cf2ffb5ad2414adec.camel@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Leonard Crestez Cc: Rob Herring , NXP Linux Team , "linux-kernel@vger.kernel.org" , Andy Duan , Fabio Estevam , "open list:GPIO SUBSYSTEM" , Mark Brown , Liam Girdwood , Shawn Guo , Sascha Hauer List-Id: linux-gpio@vger.kernel.org On Wed, Oct 3, 2018 at 1:49 PM Leonard Crestez wrote: > On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote: > > I guess I could hack to make "gpios" be ignored by the > > regulator GPIO quirks in gpiolib, but I take it you probably > > prefer to fix up the real issue like this. > > Maybe you could document in fixed-regulator bindings that it now > supports the standard "gpios" property as well? There still seems to be > a restriction that the list must contain a single element. OK you're right, fixing the docs to be more standards compliant is indeed better. > Anyway, what my patch fixes is a board-specific issue which exists even > outside your patch: the enet phy regulator never worked as expected. Indeed. Yours, Linus Walleij