From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH][next] pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static Date: Wed, 2 May 2018 13:46:19 +0200 Message-ID: References: <20180430130434.1361-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180430130434.1361-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Manivannan Sadhasivam , "open list:GPIO SUBSYSTEM" , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Mon, Apr 30, 2018 at 3:04 PM, Colin King wrote: > From: Colin Ian King > > s900_functions, s900_padinfo and s900_pads are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: > drivers/pinctrl/actions/pinctrl-s900.c:1445:30: warning: symbol > 's900_functions' was not declared. Should it be static? > drivers/pinctrl/actions/pinctrl-s900.c:1664:20: warning: symbol > 's900_padinfo' was not declared. Should it be static? > drivers/pinctrl/actions/pinctrl-s900.c:207:31: warning: symbol > 's900_pads' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Patch applied with Manivannan's ACK, I got the same patch from the 0day build robot, but I prefer human contributors to I pick this one. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Date: Wed, 02 May 2018 11:46:19 +0000 Subject: Re: [PATCH][next] pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static Message-Id: List-Id: References: <20180430130434.1361-1-colin.king@canonical.com> In-Reply-To: <20180430130434.1361-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Manivannan Sadhasivam , "open list:GPIO SUBSYSTEM" , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" On Mon, Apr 30, 2018 at 3:04 PM, Colin King wrote: > From: Colin Ian King > > s900_functions, s900_padinfo and s900_pads are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: > drivers/pinctrl/actions/pinctrl-s900.c:1445:30: warning: symbol > 's900_functions' was not declared. Should it be static? > drivers/pinctrl/actions/pinctrl-s900.c:1664:20: warning: symbol > 's900_padinfo' was not declared. Should it be static? > drivers/pinctrl/actions/pinctrl-s900.c:207:31: warning: symbol > 's900_pads' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Patch applied with Manivannan's ACK, I got the same patch from the 0day build robot, but I prefer human contributors to I pick this one. Yours, Linus Walleij