From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count() Date: Thu, 7 Jan 2016 10:34:38 +0100 Message-ID: References: <1452129169-2014-1-git-send-email-sboyd@codeaurora.org> <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Rob Herring , Greg Kroah-Hartman , Andy Gross List-Id: linux-arm-msm@vger.kernel.org On Thu, Jan 7, 2016 at 2:12 AM, Stephen Boyd wrote: > A recent patch added calls to of_irq_count() in the qcom pinctrl > drivers and that caused module build failures because > of_irq_count() is not an exported symbol. We shouldn't export > of_irq_count() to modules because it's an internal OF API that > shouldn't be used by drivers. Platform drivers should use > platform device APIs instead. Therefore, add a platform_irq_count() > API that mirrors the of_irq_count() API so that platform drivers > can stay DT agnostic. > > Cc: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Andy Gross > Signed-off-by: Stephen Boyd Patch applied with Rob's and Greg's ACKs. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbcAGJet (ORCPT ); Thu, 7 Jan 2016 04:34:49 -0500 Received: from mail-ob0-f182.google.com ([209.85.214.182]:33841 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbcAGJej (ORCPT ); Thu, 7 Jan 2016 04:34:39 -0500 MIME-Version: 1.0 In-Reply-To: <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> References: <1452129169-2014-1-git-send-email-sboyd@codeaurora.org> <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> Date: Thu, 7 Jan 2016 10:34:38 +0100 Message-ID: Subject: Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count() From: Linus Walleij To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Rob Herring , Greg Kroah-Hartman , Andy Gross Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 7, 2016 at 2:12 AM, Stephen Boyd wrote: > A recent patch added calls to of_irq_count() in the qcom pinctrl > drivers and that caused module build failures because > of_irq_count() is not an exported symbol. We shouldn't export > of_irq_count() to modules because it's an internal OF API that > shouldn't be used by drivers. Platform drivers should use > platform device APIs instead. Therefore, add a platform_irq_count() > API that mirrors the of_irq_count() API so that platform drivers > can stay DT agnostic. > > Cc: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Andy Gross > Signed-off-by: Stephen Boyd Patch applied with Rob's and Greg's ACKs. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Thu, 7 Jan 2016 10:34:38 +0100 Subject: [PATCH 1/3] driver-core: platform: Add platform_irq_count() In-Reply-To: <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> References: <1452129169-2014-1-git-send-email-sboyd@codeaurora.org> <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 7, 2016 at 2:12 AM, Stephen Boyd wrote: > A recent patch added calls to of_irq_count() in the qcom pinctrl > drivers and that caused module build failures because > of_irq_count() is not an exported symbol. We shouldn't export > of_irq_count() to modules because it's an internal OF API that > shouldn't be used by drivers. Platform drivers should use > platform device APIs instead. Therefore, add a platform_irq_count() > API that mirrors the of_irq_count() API so that platform drivers > can stay DT agnostic. > > Cc: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Andy Gross > Signed-off-by: Stephen Boyd Patch applied with Rob's and Greg's ACKs. Yours, Linus Walleij