From: Linus Walleij <linus.walleij@linaro.org>
To: Alex Lemberg <Alex.Lemberg@sandisk.com>
Cc: Avri Altman <Avri.Altman@sandisk.com>,
Arnd Bergmann <arnd@arndb.de>,
"ulf. org" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Adrian Hunter <adrian.hunter@intel.com>,
Paolo Valente <paolo.valente@linaro.org>
Subject: Re: Outstanding MQ questions from MMC
Date: Thu, 18 May 2017 11:36:34 +0200 [thread overview]
Message-ID: <CACRpkdaczsqeBE155iXmxqDj5K04mrEnysHeMuzJD8uC-_b3Sw@mail.gmail.com> (raw)
In-Reply-To: <34FA1610-93EF-441A-B8B9-F1DD6B706398@sandisk.com>
On Tue, Apr 18, 2017 at 5:31 PM, Alex Lemberg <Alex.Lemberg@sandisk.com> wrote:
> There is an additional functionality, which is require the host lock
> to be held for several write commands - the FFU.
> In case of FFU, the FW can be download/write in several iterations
> of Write command (CMD25). This sequence should not be interrupted by regular
> Write requests.
> In current driver, both FFU and RPMB can be sent by using mmc_blk_ioctl_multi_cmd().
Both single and multi ioctl()s are funneled into the block layer
using the driver-specific request ops in the latest iteration of
my patch set.
It turns out this was a simpler change than I though.
If you check the patch set I realized that I also fixes a userspace
starvation issue when issueing ioctls() such as for RPMB
during heavy block I/O.
This usecase:
> dd if=/dev/mmcblk3 of=/dev/null bs=1M &
> mmc extcs read /dev/mmcblk3
This would previously hang until the dd command was complete before
issuing the ioctl() command, just waiting for the host lock.
I guess RPMB has the same problem...
It is now fixed.
If you can verify the v2 patch set (just posted) and provide Tested-by's
(or bug reports...) it's appreciated.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-05-18 9:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 3:09 Outstanding MQ questions from MMC Linus Walleij
2017-03-30 12:42 ` Arnd Bergmann
2017-03-30 16:39 ` Ulf Hansson
2017-03-31 8:43 ` Arnd Bergmann
2017-04-13 13:22 ` Linus Walleij
2017-04-14 18:41 ` Avri Altman
2017-04-14 18:41 ` Avri Altman
2017-04-15 18:34 ` Linus Walleij
2017-04-15 19:24 ` Avri Altman
2017-04-15 19:24 ` Avri Altman
2017-04-18 15:31 ` Alex Lemberg
2017-04-18 15:31 ` Alex Lemberg
2017-05-18 9:36 ` Linus Walleij [this message]
2017-04-15 10:20 ` Ulf Hansson
2017-05-18 9:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaczsqeBE155iXmxqDj5K04mrEnysHeMuzJD8uC-_b3Sw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Alex.Lemberg@sandisk.com \
--cc=Avri.Altman@sandisk.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.