From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBBAC433EF for ; Thu, 30 Jun 2022 09:07:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbiF3JHk (ORCPT ); Thu, 30 Jun 2022 05:07:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233567AbiF3JHj (ORCPT ); Thu, 30 Jun 2022 05:07:39 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 576561CB2F for ; Thu, 30 Jun 2022 02:07:37 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id i15so32687802ybp.1 for ; Thu, 30 Jun 2022 02:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LM7syOsuEujen5dmBbJf2NA8ECKqk41TV2371TTE0Ek=; b=TlEFTT+BqFbp7eqEnEAaggxbVkXRy71Zg2YuphHqLVH39D8HbYrV6YvFEfMc8Hot+2 08kRtTlZAtWvUHnwVyl/4zRAODaPgbpoKw1P8cWZCrnt58/uqImCJVrkST2NpLCZcwto W6bj0ML9VQIeiSmriEbyERn++O5W79kZXSKmRYNeF8VWcIWcql2c4BcI1KdUtjOsci+X QTBBP/Dy724Srhf6ViUXgxtuEqLWD8c8v9tDJt1boGEzWf2TTkYD5o8RxFetHT0BXe22 lgCu/QfYNpCqbBu1/kczyPPtJSpGtWwdA7Q/7zKFyymFEPbLHWMFwks+BzWYbOI+M61A WnIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LM7syOsuEujen5dmBbJf2NA8ECKqk41TV2371TTE0Ek=; b=wWQsFjNQ8GJSZE01hRJqgxkQTP7081HYa6CJZSdqla7oXapHBqvLLW/5InGGWZ4hT6 tKtD1E7FOGnpEG16kGn64X9G5VW+Agd5xofKS3ZJd8iVWSUVgasLq65P/WXN8jSVVwYl c4zbZPaN/nhwvM1Y0lfmi++OtbHMDozAR/drQ0cMPEsr8pdZdcJ9+xJmyR0j0fPCyRFF WBjdSS4NhbjX4ikLDcD+SLQJuVjeBWg9xF+A7+dJqu7AegEYsKQA0LtrjDylSIVN7FvT l+Ixh+1MuvIlCWAaiqkIcx3Z73hZ2G4W6M82/rmferGPQM6n42s8JG7dhTKiW4gPfWIF DLNw== X-Gm-Message-State: AJIora8xzmUj+uKrUc13gh5Hr8ouv6zhuK3BRxIk5CMw9XtqzKExcNxX zqmiILfqmpMh5w49IvQfqquKjQgs66YvslhFQWIQFw== X-Google-Smtp-Source: AGRyM1txhj6Bt2Ppk95Xs8lzgpOlcXsxAyKn9sSO7LnkUjia6xoliisgZJZfuZHQrrccsWvvlPua0vjyAqBysuk9X1M= X-Received: by 2002:a25:d82:0:b0:66c:dafa:48c6 with SMTP id 124-20020a250d82000000b0066cdafa48c6mr8388465ybn.492.1656580056618; Thu, 30 Jun 2022 02:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20220629102304.65712-1-chanho61.park@samsung.com> <20220629102304.65712-3-chanho61.park@samsung.com> In-Reply-To: <20220629102304.65712-3-chanho61.park@samsung.com> From: Linus Walleij Date: Thu, 30 Jun 2022 11:07:25 +0200 Message-ID: Subject: Re: [PATCH v3 2/4] spi: s3c64xx: support custom value of internal clock divider To: Chanho Park Cc: Krzysztof Kozlowski , Andi Shyti , Mark Brown , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jun 29, 2022 at 12:27 PM Chanho Park wrote: > Modern exynos SoCs such as Exynos Auto v9 have different internal clock > divider, for example "4". To support this internal value, this adds > clk_div of the s3c64xx_spi_port_config and assign "2" as the default > value to existing s3c64xx_spi_port_config. > > Signed-off-by: Chanho Park I don't really see why this divider value should be hard-coded like this. I guess it is some default value, that's OK I guess, then call it: > + * @clk_div: Internal clock divider > + int clk_div; clk_div_default And the documentation should say "clock divider to be used by default unless a specific clock frequency is configured" Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FC49C433EF for ; Thu, 30 Jun 2022 09:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bXXHgXCNlldVelxosAiHnXpmV9jl6JwBT9QQQ0wS7vg=; b=yCctrGPKEdNlkF Y6lJNHQAi5a6VXa5z9wuxkAmaUOn7Eyef96PMrJukYfmkkLqblPZMt5USYbEMzj5+F/z7nrWcI/Nc M4UiaWaY+Kt9bvV4d81Mo40HKkt5vPvZZC78kGVpKQi29U0L7e+E7FoBqKrqa018vfLCW08NvrZ9q pHd+o/X9Dpo+P/WIuwTiHfjrm7ODxTsBS6ufGJemqhFlnqTX3+1+SKbLHQnKhJod7xC8VaijSzrd2 YSB2RfhE0g+XXSNOY09wfmuHmmxLXmLDp0QDuaAS+r4k/atxGt7Ya/5D9ip34+TJUmB9NB/n/ctoL NAWUjILkOdval7kBL85A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6q9I-00GA1U-Kx; Thu, 30 Jun 2022 09:07:44 +0000 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6q9E-00G9zL-VD for linux-arm-kernel@lists.infradead.org; Thu, 30 Jun 2022 09:07:42 +0000 Received: by mail-yb1-xb2d.google.com with SMTP id d5so32609173yba.5 for ; Thu, 30 Jun 2022 02:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LM7syOsuEujen5dmBbJf2NA8ECKqk41TV2371TTE0Ek=; b=TlEFTT+BqFbp7eqEnEAaggxbVkXRy71Zg2YuphHqLVH39D8HbYrV6YvFEfMc8Hot+2 08kRtTlZAtWvUHnwVyl/4zRAODaPgbpoKw1P8cWZCrnt58/uqImCJVrkST2NpLCZcwto W6bj0ML9VQIeiSmriEbyERn++O5W79kZXSKmRYNeF8VWcIWcql2c4BcI1KdUtjOsci+X QTBBP/Dy724Srhf6ViUXgxtuEqLWD8c8v9tDJt1boGEzWf2TTkYD5o8RxFetHT0BXe22 lgCu/QfYNpCqbBu1/kczyPPtJSpGtWwdA7Q/7zKFyymFEPbLHWMFwks+BzWYbOI+M61A WnIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LM7syOsuEujen5dmBbJf2NA8ECKqk41TV2371TTE0Ek=; b=1CY6M9kx5NxKq7MsD51Orky6QB08xGaTRNOIvkqYwqf++EHzS0BHhIqWtO8lQ11qNl PP5Do56zcfQ7mcRd83+A2QNtpzJJ1/EIOjS6vEZ1W3vRkDedYlrnMBavbRFabNi3EMu5 GyHwJ1nwZBEKscdiiZCg11LgGm/C5nGfqW/w5YHcKGmQ2d0Z9koJJKCGCBdRlm1JCkX2 hzBCy6Akr4Dd53a0G5D4XyFNkG8HVzHNvE4bF0bN7XXyBoP4duRp9V6MwGUQ+Lr2g0JQ ddK/9d4YP9nM1KG5bnWeU9ktI33pleujT6Qr8D1NQenMOBcJHGLYz3og7eED2iuNkGjs mnZw== X-Gm-Message-State: AJIora/+5vK1Dk9rwkHWbGqWNOD3N+KnsmpcH3yi4QSTwgfLPTUIGesL Ysyb0Cw2+Uk75WKjRndtEJsPxRVdEDdfpl+loXlVoA== X-Google-Smtp-Source: AGRyM1txhj6Bt2Ppk95Xs8lzgpOlcXsxAyKn9sSO7LnkUjia6xoliisgZJZfuZHQrrccsWvvlPua0vjyAqBysuk9X1M= X-Received: by 2002:a25:d82:0:b0:66c:dafa:48c6 with SMTP id 124-20020a250d82000000b0066cdafa48c6mr8388465ybn.492.1656580056618; Thu, 30 Jun 2022 02:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20220629102304.65712-1-chanho61.park@samsung.com> <20220629102304.65712-3-chanho61.park@samsung.com> In-Reply-To: <20220629102304.65712-3-chanho61.park@samsung.com> From: Linus Walleij Date: Thu, 30 Jun 2022 11:07:25 +0200 Message-ID: Subject: Re: [PATCH v3 2/4] spi: s3c64xx: support custom value of internal clock divider To: Chanho Park Cc: Krzysztof Kozlowski , Andi Shyti , Mark Brown , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220630_020741_050641_6D453CC9 X-CRM114-Status: GOOD ( 11.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 29, 2022 at 12:27 PM Chanho Park wrote: > Modern exynos SoCs such as Exynos Auto v9 have different internal clock > divider, for example "4". To support this internal value, this adds > clk_div of the s3c64xx_spi_port_config and assign "2" as the default > value to existing s3c64xx_spi_port_config. > > Signed-off-by: Chanho Park I don't really see why this divider value should be hard-coded like this. I guess it is some default value, that's OK I guess, then call it: > + * @clk_div: Internal clock divider > + int clk_div; clk_div_default And the documentation should say "clock divider to be used by default unless a specific clock frequency is configured" Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel