From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Halaney <ajhalaney@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: nomadik: Fix pull direction debug info
Date: Thu, 13 Aug 2020 10:06:55 +0200 [thread overview]
Message-ID: <CACRpkdaiMCgHt8obPV4g7pnMcXWvWKf+KJdQjYp7qKOObQ5McQ@mail.gmail.com> (raw)
In-Reply-To: <20200806155322.GA25523@ola-jn9phv2.ad.garmin.com>
On Thu, Aug 6, 2020 at 5:53 PM Andrew Halaney <ajhalaney@gmail.com> wrote:
> The nomadik pinctrl hardware doesn't have any way to
> determine if the active pull is up or down. Reading
> the bit currently used to report if the pull is up/down
> indicates if the gpio input is reading high or low, it
> doesn't reflect the pull state.
>
> For this reason change the output from "pull up"/"pull down" to
> "pull enabled". This avoids confusing developers who were using
> the output to determine what the pull state is.
>
> Signed-off-by: Andrew Halaney <ajhalaney@gmail.com>
Patch applied. It's clearly better like this. A plain bug.
Do you think we can fix it properly by reading both the
DATS and DATC registers to do the inverse of what
__nmk_gpio_set_pull() does and give a proper readout
of pull up/down?
Out of curiosity: what hardware are you testing this on?
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-08-13 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 15:53 [PATCH] pinctrl: nomadik: Fix pull direction debug info Andrew Halaney
2020-08-13 8:06 ` Linus Walleij [this message]
2020-08-13 17:39 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaiMCgHt8obPV4g7pnMcXWvWKf+KJdQjYp7qKOObQ5McQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=ajhalaney@gmail.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.