* [PATCH] dt-bindings: mmc: arm,pl18x: Make each example a separate entry
@ 2022-01-06 18:25 Rob Herring
2022-01-10 16:13 ` Linus Walleij
2022-01-19 16:11 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2022-01-06 18:25 UTC (permalink / raw)
To: Ulf Hansson, Linus Walleij; +Cc: linux-mmc, devicetree, linux-kernel
Each independent example should be a separate entry. This and dropping
'interrupt-parent' allows for 'interrupts' to have different cell sizes.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index 47595cb483be..2a64cffbe6ad 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -167,6 +167,9 @@ examples:
clock-names = "mclk", "apb_pclk";
};
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
mmc@80126000 {
compatible = "arm,pl18x", "arm,primecell";
reg = <0x80126000 0x1000>;
@@ -188,12 +191,12 @@ examples:
vqmmc-supply = <&vmmci>;
};
+ - |
mmc@101f6000 {
compatible = "arm,pl18x", "arm,primecell";
reg = <0x101f6000 0x1000>;
clocks = <&sdiclk>, <&pclksdi>;
clock-names = "mclk", "apb_pclk";
- interrupt-parent = <&vica>;
interrupts = <22>;
max-frequency = <400000>;
bus-width = <4>;
@@ -208,6 +211,7 @@ examples:
vmmc-supply = <&vmmc_regulator>;
};
+ - |
mmc@52007000 {
compatible = "arm,pl18x", "arm,primecell";
arm,primecell-periphid = <0x10153180>;
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mmc: arm,pl18x: Make each example a separate entry
2022-01-06 18:25 [PATCH] dt-bindings: mmc: arm,pl18x: Make each example a separate entry Rob Herring
@ 2022-01-10 16:13 ` Linus Walleij
2022-01-19 16:11 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-01-10 16:13 UTC (permalink / raw)
To: Rob Herring; +Cc: Ulf Hansson, linux-mmc, devicetree, linux-kernel
On Thu, Jan 6, 2022 at 7:25 PM Rob Herring <robh@kernel.org> wrote:
> Each independent example should be a separate entry. This and dropping
> 'interrupt-parent' allows for 'interrupts' to have different cell sizes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
This is neat!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mmc: arm,pl18x: Make each example a separate entry
2022-01-06 18:25 [PATCH] dt-bindings: mmc: arm,pl18x: Make each example a separate entry Rob Herring
2022-01-10 16:13 ` Linus Walleij
@ 2022-01-19 16:11 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-01-19 16:11 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, linux-kernel, linux-mmc, Ulf Hansson, devicetree
On Thu, 06 Jan 2022 12:25:14 -0600, Rob Herring wrote:
> Each independent example should be a separate entry. This and dropping
> 'interrupt-parent' allows for 'interrupts' to have different cell sizes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-19 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 18:25 [PATCH] dt-bindings: mmc: arm,pl18x: Make each example a separate entry Rob Herring
2022-01-10 16:13 ` Linus Walleij
2022-01-19 16:11 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.