From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator Date: Tue, 2 Oct 2018 21:56:39 +0200 Message-ID: References: <1147be600733a1bcde194f7df61866019f34a531.1538504729.git.leonard.crestez@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1147be600733a1bcde194f7df61866019f34a531.1538504729.git.leonard.crestez@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Leonard Crestez , Rob Herring Cc: Fabio Estevam , Andy Duan , Shawn Guo , Mark Brown , Liam Girdwood , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , NXP Linux Team , Sascha Hauer List-Id: linux-gpio@vger.kernel.org On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez wrote: > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed: > Convert to use GPIO descriptor only") which causes the "gpios" property > to also be parsed. Before that commit the "gpios" property had no > effect and PHY reset was only handled in the bootloader. Wow that was a very interesting one. Turning over these stones sometimes expose the weirdest things. This is one of the reasons why we need formal validation of DTS files: things look OK to the human eye and get merged but they are just syntactically wrong. I guess I could hack to make "gpios" be ignored by the regulator GPIO quirks in gpiolib, but I take it you probably prefer to fix up the real issue like this. Anyways, good job! Reviewed-by: Linus Walleij Yours, Linus Walleij