From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver Date: Mon, 12 Jan 2015 01:04:10 +0100 Message-ID: References: <1420802369-3840-1-git-send-email-Vincent.Yang@tw.fujitsu.com> <1420803212-4350-1-git-send-email-Vincent.Yang@tw.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ig0-f171.google.com ([209.85.213.171]:56596 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbbALAEL (ORCPT ); Sun, 11 Jan 2015 19:04:11 -0500 Received: by mail-ig0-f171.google.com with SMTP id z20so9207855igj.4 for ; Sun, 11 Jan 2015 16:04:10 -0800 (PST) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Vincent Yang , Kamlakant Patel Cc: "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , Olof Johansson , Rob Herring , =?UTF-8?Q?Pawe=C5=82_Moll?= , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Grant Likely , Alexandre Courbot , Andy Green , Patch Tracking , Jaswinder Singh , Vincent Yang , Tetsuya Nuriya On Sun, Jan 11, 2015 at 11:40 PM, Linus Walleij wrote: > First I thought maybe this could use the generic MMIO driver > but it seems you need this double register access for setting > the direction so it won't work. > > Otherwise it's sort of close ... have you looks at the option? Bah, sorry I saw I already asked this in the past and you explained that the arithmetic is not simple enough. Sorry for forgetting what I already asked. This is over all looking very good, but waiting since you had some pending change, then I'll merge it. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Mon, 12 Jan 2015 01:04:10 +0100 Subject: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver In-Reply-To: References: <1420802369-3840-1-git-send-email-Vincent.Yang@tw.fujitsu.com> <1420803212-4350-1-git-send-email-Vincent.Yang@tw.fujitsu.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jan 11, 2015 at 11:40 PM, Linus Walleij wrote: > First I thought maybe this could use the generic MMIO driver > but it seems you need this double register access for setting > the direction so it won't work. > > Otherwise it's sort of close ... have you looks at the option? Bah, sorry I saw I already asked this in the past and you explained that the arithmetic is not simple enough. Sorry for forgetting what I already asked. This is over all looking very good, but waiting since you had some pending change, then I'll merge it. Yours, Linus Walleij