From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF5EC433DB for ; Thu, 11 Mar 2021 01:18:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDCE564E77 for ; Thu, 11 Mar 2021 01:18:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229542AbhCKBR3 (ORCPT ); Wed, 10 Mar 2021 20:17:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbhCKBRG (ORCPT ); Wed, 10 Mar 2021 20:17:06 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72871C061760 for ; Wed, 10 Mar 2021 17:17:06 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id q14so227731ljp.4 for ; Wed, 10 Mar 2021 17:17:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=B7suaILMqkwRadnzQQxPfSqPrJ+7maZjfwE653KBZsY=; b=I5asAXLdzh8hgadBtI0ePVcXHJrnN3OmbnuSEAkDUiL0l06QmaBO6SEvt38EGF78gw 4pYxRtg/ieeD8DN8YCl4k7jqQ279+qebcaI5JCfgzkfCSUTDbm7oPeSyDia1K4POiRcE svhAa93OB6ht1jgc3bJptcPsnmUNrx+ASd5wg5GFTiwyrv9eb0tv+225S/E5ieGTSimn 5kaUwzH+jvzR/B17DSTBMtW2JtMPFpZ3JDJC+8VHAqlwo6oDf9KG9TJXxFi/MO0d6Eb8 wCtp3I0jIoQ9Uh2F3fPVO4HUrle8NDDBjTb/VBolSr75a8Aw4LtePcfXea5S3CwR7ZVw l2lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=B7suaILMqkwRadnzQQxPfSqPrJ+7maZjfwE653KBZsY=; b=kqjoXJoorsA2UiGUoc8e05bjH5uuoOcctdetGuyix94ypHX99u7m6YyUpXOveu+tTr Vv3iF8ATRGz2wQ+On0AJwYKGy+OTQcsqZ856zCs1GF3wTh1t42fO2r3esmUEpEvP43fh AUCGFd+9+TqP5QYKGT5Grj7aU4RdmjVRsdOHBW3HaeqbNii+i1734wyyvokM0n4u75PG N0Au1ETF8Bm4wsj/ddy3IdnIdrDUdnq3xYIQvEn42gMHkGgqcH0rl0OM/ozVkqpCmndc yvA+BG84S5cSvuyhd6lvw0DPJVFZpjAQMpLvO3/YfHXf3z4f8ADK/ClKzslgI6OKBlUY w3DQ== X-Gm-Message-State: AOAM530F9DQykLU+nD01lQJSKEIiuPaHVpwzjsEnEG2R37xZuO1rcNs3 Pgcsho61poH5vt38HdZRykpifYgIA9cTXIyW0Tri+Q== X-Google-Smtp-Source: ABdhPJw4+/D839Q6QR+cLunMDw8nqYj+e0QUG0rP80PVTMnqGi4QCWr0d3t0u6bTJ/26oZMuJfs1lIwcmmW3VWl7mIQ= X-Received: by 2002:a2e:9004:: with SMTP id h4mr3415908ljg.326.1615425424782; Wed, 10 Mar 2021 17:17:04 -0800 (PST) MIME-Version: 1.0 References: <20210310125504.31886-1-noltari@gmail.com> <20210310125504.31886-3-noltari@gmail.com> <7e35bfd395f3ae40029b0f3cb2bc8f70@walle.cc> In-Reply-To: From: Linus Walleij Date: Thu, 11 Mar 2021 02:16:54 +0100 Message-ID: Subject: Re: [PATCH v6 02/15] gpio: regmap: set gpio_chip of_node To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Michael Walle , Rob Herring , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list , Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Mar 10, 2021 at 8:12 PM =C3=81lvaro Fern=C3=A1ndez Rojas wrote: > > If there will be a new version, please add the following comment: > > Right now I don=E2=80=99t know that either, because I=E2=80=99m honestly = getting tired of this=E2=80=A6 IMO there is indeed such a thing as over-review when it comes to migrating legacy platforms: as subsystem maintainer I ask the bigger question: does the kernel look better after than before this patch? If the author is stressed by too much review I tend to just apply it and say that comments can be addressed by additional patches. DT bindings are different because they are written in stone. We just need to settle the DT bindings. Give the patch set some rest and come back and poke me to apply it when the chatter stops. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B3CC433E0 for ; Thu, 11 Mar 2021 01:18:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9136661601 for ; Thu, 11 Mar 2021 01:18:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9136661601 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a1aMK3d1+rm9L6tudDl+CZkqswL3FSMVq4MOfTRcHto=; b=kFmd7hALs0QkJ19Obz48w0Dx7 FKsy6MeO8oD4Q9ZAtt0o1nKGqUNb8AwupUkTzQSo7vsTmTa8z0ZW2FokuXt+WhOdTO2G39d7jMoCT 6hRYH2VOl6hC2BZU2F6C7ETMBDID2TOjsnPqJ0i8ZIAKzlTxGwr0EO9xMQwRV8o7aLydGhiCjZRkN +dWUwm71vodMJGurKRM9SkExMonYxlfiPQDRN6sXINDGm2jbgogeoTL0k14Iu1inZb+oIor75Gxjn SMrMfyOx5v5/7V+skL34dgrboLVcJ25zd/8413qhz9cY23IyISIYlOWPUSytiRBCUi1gPWJOE9zCi WJEMHhKrA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lK9ws-008A4M-3x; Thu, 11 Mar 2021 01:17:10 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lK9wn-008A3j-Vy for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 01:17:08 +0000 Received: by mail-lj1-x229.google.com with SMTP id k12so202059ljg.9 for ; Wed, 10 Mar 2021 17:17:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=B7suaILMqkwRadnzQQxPfSqPrJ+7maZjfwE653KBZsY=; b=I5asAXLdzh8hgadBtI0ePVcXHJrnN3OmbnuSEAkDUiL0l06QmaBO6SEvt38EGF78gw 4pYxRtg/ieeD8DN8YCl4k7jqQ279+qebcaI5JCfgzkfCSUTDbm7oPeSyDia1K4POiRcE svhAa93OB6ht1jgc3bJptcPsnmUNrx+ASd5wg5GFTiwyrv9eb0tv+225S/E5ieGTSimn 5kaUwzH+jvzR/B17DSTBMtW2JtMPFpZ3JDJC+8VHAqlwo6oDf9KG9TJXxFi/MO0d6Eb8 wCtp3I0jIoQ9Uh2F3fPVO4HUrle8NDDBjTb/VBolSr75a8Aw4LtePcfXea5S3CwR7ZVw l2lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=B7suaILMqkwRadnzQQxPfSqPrJ+7maZjfwE653KBZsY=; b=FeO6m2PwHlZQZ3qwYGIEGKyUbNjdsHHynkxPzgHStPC/NS5iXZcYEF2JiYQN/NEeoj sTQmS1CYWEKs3v69NDbF8mhmiXBUG+aSRmN7yYUbvh2zbT0SefFOLYBbeayAIT784yiZ JB5bIQIOFum20XVmc8574WG1jAshDFwrQvQYKDE3hEbb6EX6wAwHcBP2Opms+RahEXQO 6kuCZYzckkB+AHQ0SVG02cMrm9xcXd4jChSzwCZDAg8N/Z4EVKJvCOmhfiMDwKiZ80yw iFqunPMFSQxY5K5p6Y7ZEeJ75zGnN/b9f5n+EYoHOD0p3NrkWXX8MgCPOhF1doz4MF/m JFMA== X-Gm-Message-State: AOAM531WDt0kwXaxP4BeSX+Ytz9ht7p3nnGBwVtmY9AIJ6iPFMc3o1l9 0rZBAk/BzhC73p6ObVTU1uviZmcbO/SUcnaKIoLlug== X-Google-Smtp-Source: ABdhPJw4+/D839Q6QR+cLunMDw8nqYj+e0QUG0rP80PVTMnqGi4QCWr0d3t0u6bTJ/26oZMuJfs1lIwcmmW3VWl7mIQ= X-Received: by 2002:a2e:9004:: with SMTP id h4mr3415908ljg.326.1615425424782; Wed, 10 Mar 2021 17:17:04 -0800 (PST) MIME-Version: 1.0 References: <20210310125504.31886-1-noltari@gmail.com> <20210310125504.31886-3-noltari@gmail.com> <7e35bfd395f3ae40029b0f3cb2bc8f70@walle.cc> In-Reply-To: From: Linus Walleij Date: Thu, 11 Mar 2021 02:16:54 +0100 Message-ID: Subject: Re: [PATCH v6 02/15] gpio: regmap: set gpio_chip of_node To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Michael Walle , Rob Herring , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list , Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_011706_187006_EBED9BA5 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXIgMTAsIDIwMjEgYXQgODoxMiBQTSDDgWx2YXJvIEZlcm7DoW5kZXogUm9qYXMK PG5vbHRhcmlAZ21haWwuY29tPiB3cm90ZToKCj4gPiBJZiB0aGVyZSB3aWxsIGJlIGEgbmV3IHZl cnNpb24sIHBsZWFzZSBhZGQgdGhlIGZvbGxvd2luZyBjb21tZW50Ogo+Cj4gUmlnaHQgbm93IEkg ZG9u4oCZdCBrbm93IHRoYXQgZWl0aGVyLCBiZWNhdXNlIEnigJltIGhvbmVzdGx5IGdldHRpbmcg dGlyZWQgb2YgdGhpc+KApgoKSU1PIHRoZXJlIGlzIGluZGVlZCBzdWNoIGEgdGhpbmcgYXMgb3Zl ci1yZXZpZXcgd2hlbiBpdCBjb21lcwp0byBtaWdyYXRpbmcgbGVnYWN5IHBsYXRmb3JtczogYXMg c3Vic3lzdGVtIG1haW50YWluZXIgSSBhc2sgdGhlIGJpZ2dlcgpxdWVzdGlvbjogZG9lcyB0aGUg a2VybmVsIGxvb2sgYmV0dGVyIGFmdGVyIHRoYW4gYmVmb3JlIHRoaXMgcGF0Y2g/IElmIHRoZQph dXRob3IgaXMgc3RyZXNzZWQgYnkgdG9vIG11Y2ggcmV2aWV3IEkgdGVuZCB0byBqdXN0IGFwcGx5 IGl0IGFuZCBzYXkgdGhhdApjb21tZW50cyBjYW4gYmUgYWRkcmVzc2VkIGJ5IGFkZGl0aW9uYWwg cGF0Y2hlcy4KCkRUIGJpbmRpbmdzIGFyZSBkaWZmZXJlbnQgYmVjYXVzZSB0aGV5IGFyZSB3cml0 dGVuIGluIHN0b25lLiBXZSBqdXN0IG5lZWQKdG8gc2V0dGxlIHRoZSBEVCBiaW5kaW5ncy4gR2l2 ZSB0aGUgcGF0Y2ggc2V0IHNvbWUgcmVzdCBhbmQgY29tZSBiYWNrIGFuZApwb2tlIG1lIHRvIGFw cGx5IGl0IHdoZW4gdGhlIGNoYXR0ZXIgc3RvcHMuCgpZb3VycywKTGludXMgV2FsbGVpagoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=