From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v4 2/9] pinctrl: Renesas RZ/A1 pin and gpio controller Date: Fri, 28 Apr 2017 10:06:16 +0200 Message-ID: References: <1491401247-7030-1-git-send-email-jacopo+renesas@jmondi.org> <1491401247-7030-3-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Wed, Apr 26, 2017 at 2:21 PM, Geert Uytterhoeven wrote: > On Wed, Apr 5, 2017 at 4:07 PM, Jacopo Mondi wrote: >> Add combined gpio and pin controller driver for Renesas RZ/A1 >> r7s72100 SoC. >> >> Signed-off-by: Jacopo Mondi > >> --- /dev/null >> +++ b/drivers/pinctrl/pinctrl-rza1.c > >> +/* >> + * Keep this up-to-date with pinconf-generic.h: it performs packing of >> + * pin conf flags and argument during pinconf_generic_parse_dt_config(); >> + * we simply discard pinconf argument here >> + */ >> +#define PIN_CONF_UNPACK(pinconf) ((pinconf) & 0xffUL) > > Perhaps this should be moved to pinconf-generic.h, to make sure it stays > up-to-date? I agree. Use the generic macros. If further processing is needed, make a static inline to discard config flags etc. Yours, Linus Walleij