From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C11C433E0 for ; Wed, 3 Jun 2020 22:09:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3C5D2077D for ; Wed, 3 Jun 2020 22:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HKtt7Ce2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbgFCWJD (ORCPT ); Wed, 3 Jun 2020 18:09:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgFCWJC (ORCPT ); Wed, 3 Jun 2020 18:09:02 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73103C08C5C0 for ; Wed, 3 Jun 2020 15:09:02 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id z206so2323627lfc.6 for ; Wed, 03 Jun 2020 15:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cGmwYW9BzpYkE3b5BXMa4x8r+iWYDMrACAFEn5/TXJs=; b=HKtt7Ce2T/uv0uuk+ikmeaezZFR7KV+O78D0r/pRwJ/pvjEvYLfSpoVYCPmGMlXgAH vklJDoXat2X4tk+UWGiPrV1fAJzjDYjto173ALf43iPuLmlA7XTETrfM1n42QfDFYA6G lybqZRxRsnxahb0rFMHSsWDGaHfUwLYJcRCM3DQs1xpf/3lnHy6DC75yQNYuwQT7hyC7 aI3VznFrKb81GMJMV34Mg5laOi3kTzCSe4MyP4nCHPbGBrMF/l/O5CUyDc96d9qfMTyw /u1HgOiHC0+TbH7IDV7ts5kgOQS0aTGs9WtayvOuKAcQsbrJtu+D4ZrcZ7BbOqgXazYA Sdzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cGmwYW9BzpYkE3b5BXMa4x8r+iWYDMrACAFEn5/TXJs=; b=lKtTh8IQS+2VdUzStAeRu+Cd4loaw2P5wqmTZrjb3BCotuiitvm0+hYscf34zFCvvW 4hBQNOYCAxHKGLRc/EwkUKEGKJagt4M9fwO5rsF0elXIu6dXJjI20uGUyBwlECTTaoqP 7AQn5+M7zyj6m+nQ9y+b2ZpYGsKfw+FDKMlpBhRANXSidfrORyuJZTNH5mArkX5rJyit lPrDAe173+HXY/W3lPohj2RM+DYmLZcLgupxqFfL2Rw6hEBkIFFTaIql4YGNSEyeqAZK S7I6aClUNAK603giIcOQYS2Ct38J+nsRWPgh/ThKeEbWs2Bw+xFIkXDgRru0e/pJ4S/4 dWPw== X-Gm-Message-State: AOAM533LQJ20oUDVk2DnZnH3AlO1wsJCfquyrUqAcPzAW7YlsdDBIW94 CaNd80vtCYGpIIvGgJPMI7gtKwfcsI4achjdQwHjqA== X-Google-Smtp-Source: ABdhPJyk+KPR2lsjSvLKNRHP6aN4z/UirZhICS+CEfRNQ+r3j4K/FSNVE284NtSnzx9V5dXUQyG8xe1LglaugjNvlLo= X-Received: by 2002:a19:c8cb:: with SMTP id y194mr820722lff.89.1591222140898; Wed, 03 Jun 2020 15:09:00 -0700 (PDT) MIME-Version: 1.0 References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> In-Reply-To: <20200601183102.GS30374@kadam> From: Linus Walleij Date: Thu, 4 Jun 2020 00:08:49 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken To: Dan Carpenter Cc: Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jun 1, 2020 at 8:31 PM Dan Carpenter wro= te: > On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > > Le 01/06/2020 =C3=A0 10:58, Robert Jarzmik a =C3=A9crit : > > > Christophe JAILLET writes: > > > > > > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for= pinctrl registration") > > > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > > > > 'pxa2xx_pinctrl_init()'. > > > > However, the corresponding 'pinctrl_unregister()' call in > > > > 'pxa2xx_pinctrl_exit()' has not been removed. > > > > > > > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > > > > Remove it now to avoid some wondering in the future and save a few = LoC. > > > > > > > > Signed-off-by: Christophe JAILLET > > > Acked-by: Robert Jarzmik > > > > > > Would be even a better patch with a : > > > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for p= inctrl registration") > > > > I was wondering it was was needed in this case. > > The patch does not really fix anything, as the function is unused. Or i= t > > fixes things on a theoretical point of view. > > There is no concensus... We should call a vote on this at Kernel > Summit. :P Fixes means it fixes something that was wrong in that commit. That's all. Whether syntactic or semantic or regression or serious or not does not matter. It is also not compulsory to add it is just helpful. If it is a regression or critical bug, we also add Cc: stable. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Date: Wed, 03 Jun 2020 22:08:49 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: List-Id: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> In-Reply-To: <20200601183102.GS30374@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM On Mon, Jun 1, 2020 at 8:31 PM Dan Carpenter wrote: > On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > > Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : > > > Christophe JAILLET writes: > > > > > > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") > > > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > > > > 'pxa2xx_pinctrl_init()'. > > > > However, the corresponding 'pinctrl_unregister()' call in > > > > 'pxa2xx_pinctrl_exit()' has not been removed. > > > > > > > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > > > > Remove it now to avoid some wondering in the future and save a few LoC. > > > > > > > > Signed-off-by: Christophe JAILLET > > > Acked-by: Robert Jarzmik > > > > > > Would be even a better patch with a : > > > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") > > > > I was wondering it was was needed in this case. > > The patch does not really fix anything, as the function is unused. Or it > > fixes things on a theoretical point of view. > > There is no concensus... We should call a vote on this at Kernel > Summit. :P Fixes means it fixes something that was wrong in that commit. That's all. Whether syntactic or semantic or regression or serious or not does not matter. It is also not compulsory to add it is just helpful. If it is a regression or critical bug, we also add Cc: stable. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 096ECC433DF for ; Wed, 3 Jun 2020 22:09:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C83FF2077D for ; Wed, 3 Jun 2020 22:09:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ge9/Rra9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HKtt7Ce2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C83FF2077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cga3RXgCKJBky3POGzRfV1+5AXiYV6+CCKtXGJhrf2c=; b=Ge9/Rra9CfqiiM zyYop1mcl/j399Yi2UvrfvloV1X+jZxvAp/wZ1iwCuIgkheL3/f9IKmdrHppoaUE/v53rkQWbMHU4 TIFgyN+/RBpFFRWdwXgGvfLAXG8kM+z4f7YXXJ+rHUB1+a/tgs27TOf6cfrl9QPW/pgu22oY8ifuD KiFC1zc86IGOZQApN80j/eFm8ISdBOu3XJhISpHcSfLAh9z8hzomFgPNL0bQNPPF0jRuD5bxQy0MS yo7SuJA9+oyA8R+7lVtbSKOt7C7jUQJETrt076sdR9W7NnEb0s9QtWDzYsXnOgF0i7SlhF1j0gnDW zeRS2LJYTQ0nzwx5UrKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgbZK-00036Y-1P; Wed, 03 Jun 2020 22:09:06 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgbZG-000368-O9 for linux-arm-kernel@lists.infradead.org; Wed, 03 Jun 2020 22:09:04 +0000 Received: by mail-lf1-x144.google.com with SMTP id 82so2325367lfh.2 for ; Wed, 03 Jun 2020 15:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cGmwYW9BzpYkE3b5BXMa4x8r+iWYDMrACAFEn5/TXJs=; b=HKtt7Ce2T/uv0uuk+ikmeaezZFR7KV+O78D0r/pRwJ/pvjEvYLfSpoVYCPmGMlXgAH vklJDoXat2X4tk+UWGiPrV1fAJzjDYjto173ALf43iPuLmlA7XTETrfM1n42QfDFYA6G lybqZRxRsnxahb0rFMHSsWDGaHfUwLYJcRCM3DQs1xpf/3lnHy6DC75yQNYuwQT7hyC7 aI3VznFrKb81GMJMV34Mg5laOi3kTzCSe4MyP4nCHPbGBrMF/l/O5CUyDc96d9qfMTyw /u1HgOiHC0+TbH7IDV7ts5kgOQS0aTGs9WtayvOuKAcQsbrJtu+D4ZrcZ7BbOqgXazYA Sdzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cGmwYW9BzpYkE3b5BXMa4x8r+iWYDMrACAFEn5/TXJs=; b=Y7ezJODof2LaDqzNTUxsqjrxu3eBHdIAuS2/B2NAkxDANxP/zBvHAnJ7aFH2ub24Xs q+lrCQXiyWG8M61E9PAePC0T4mZgZp7AcghCobUBTvYDhNct9+bgCAyiISo4GNFRDpGg auaVhnCNODWMx461az5EYMm2+5lLvYkARiVm8/GhmabUMfrYRr4ZnJgHlNmQuVlivtof hgFPchwYMzEoZ6PL3+H1GNkolLDOoWlhW7UXg5lM5mFeFVNo57pJ34Ayp/p5aKLzGb5E Bp1EZ0pKHdS5KDSK0EgCd5eNnWOzFCZD+ACj1ulIAeiMmZRAAHh2Lhc6KMMO9VWruhdk dOYQ== X-Gm-Message-State: AOAM531bmGQvSqAfNMkUjVS4zq/UsnIG/jeumqfjgBewZEN6zFqq6E4d tUrJaAIiZ84VQyqIrVBWoPIY5MZGw2mt7DLZGbOqrA== X-Google-Smtp-Source: ABdhPJyk+KPR2lsjSvLKNRHP6aN4z/UirZhICS+CEfRNQ+r3j4K/FSNVE284NtSnzx9V5dXUQyG8xe1LglaugjNvlLo= X-Received: by 2002:a19:c8cb:: with SMTP id y194mr820722lff.89.1591222140898; Wed, 03 Jun 2020 15:09:00 -0700 (PDT) MIME-Version: 1.0 References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> In-Reply-To: <20200601183102.GS30374@kadam> From: Linus Walleij Date: Thu, 4 Jun 2020 00:08:49 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken To: Dan Carpenter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_150902_789952_996787E0 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMSwgMjAyMCBhdCA4OjMxIFBNIERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50 ZXJAb3JhY2xlLmNvbT4gd3JvdGU6Cj4gT24gTW9uLCBKdW4gMDEsIDIwMjAgYXQgMDE6MzE6MjNQ TSArMDIwMCwgQ2hyaXN0b3BoZSBKQUlMTEVUIHdyb3RlOgo+ID4gTGUgMDEvMDYvMjAyMCDDoCAx MDo1OCwgUm9iZXJ0IEphcnptaWsgYSDDqWNyaXQgOgo+ID4gPiBDaHJpc3RvcGhlIEpBSUxMRVQg PGNocmlzdG9waGUuamFpbGxldEB3YW5hZG9vLmZyPiB3cml0ZXM6Cj4gPiA+Cj4gPiA+ID4gQ29t bWl0IDZkMzNlZTdhMDUzNCAoInBpbmN0cmw6IHB4YTogVXNlIGRldm1fcGluY3RybF9yZWdpc3Rl cigpIGZvciBwaW5jdHJsIHJlZ2lzdHJhdGlvbiIpCj4gPiA+ID4gaGFzIHR1cm5lZCBhICdwaW5j dHJsX3JlZ2lzdGVyKCknIGludG8gJ2Rldm1fcGluY3RybF9yZWdpc3RlcigpJyBpbgo+ID4gPiA+ ICdweGEyeHhfcGluY3RybF9pbml0KCknLgo+ID4gPiA+IEhvd2V2ZXIsIHRoZSBjb3JyZXNwb25k aW5nICdwaW5jdHJsX3VucmVnaXN0ZXIoKScgY2FsbCBpbgo+ID4gPiA+ICdweGEyeHhfcGluY3Ry bF9leGl0KCknIGhhcyBub3QgYmVlbiByZW1vdmVkLgo+ID4gPiA+Cj4gPiA+ID4gVGhpcyBpcyBu b3QgYW4gaXNzdWUsIGJlY2F1c2UgJ3B4YTJ4eF9waW5jdHJsX2V4aXQoKScgaXMgdW51c2VkLgo+ ID4gPiA+IFJlbW92ZSBpdCBub3cgdG8gYXZvaWQgc29tZSB3b25kZXJpbmcgaW4gdGhlIGZ1dHVy ZSBhbmQgc2F2ZSBhIGZldyBMb0MuCj4gPiA+ID4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJp c3RvcGhlIEpBSUxMRVQgPGNocmlzdG9waGUuamFpbGxldEB3YW5hZG9vLmZyPgo+ID4gPiBBY2tl ZC1ieTogUm9iZXJ0IEphcnptaWsgPHJvYmVydC5qYXJ6bWlrQGZyZWUuZnI+Cj4gPiA+Cj4gPiA+ IFdvdWxkIGJlIGV2ZW4gYSBiZXR0ZXIgcGF0Y2ggd2l0aCBhIDoKPiA+ID4gRml4ZXM6IDZkMzNl ZTdhMDUzNCAoInBpbmN0cmw6IHB4YTogVXNlIGRldm1fcGluY3RybF9yZWdpc3RlcigpIGZvciBw aW5jdHJsIHJlZ2lzdHJhdGlvbiIpCj4gPgo+ID4gSSB3YXMgd29uZGVyaW5nIGl0IHdhcyB3YXMg bmVlZGVkIGluIHRoaXMgY2FzZS4KPiA+IFRoZSBwYXRjaCBkb2VzIG5vdCByZWFsbHkgZml4IGFu eXRoaW5nLCBhcyB0aGUgZnVuY3Rpb24gaXMgdW51c2VkLiBPciBpdAo+ID4gZml4ZXMgdGhpbmdz IG9uIGEgdGhlb3JldGljYWwgcG9pbnQgb2Ygdmlldy4KPgo+IFRoZXJlIGlzIG5vIGNvbmNlbnN1 cy4uLiAgV2Ugc2hvdWxkIGNhbGwgYSB2b3RlIG9uIHRoaXMgYXQgS2VybmVsCj4gU3VtbWl0LiAg OlAKCkZpeGVzIG1lYW5zIGl0IGZpeGVzIHNvbWV0aGluZyB0aGF0IHdhcyB3cm9uZyBpbiB0aGF0 IGNvbW1pdC4KVGhhdCdzIGFsbC4gV2hldGhlciBzeW50YWN0aWMgb3Igc2VtYW50aWMgb3IgcmVn cmVzc2lvbiBvcgpzZXJpb3VzIG9yIG5vdCBkb2VzIG5vdCBtYXR0ZXIuIEl0IGlzIGFsc28gbm90 IGNvbXB1bHNvcnkgdG8KYWRkIGl0IGlzIGp1c3QgaGVscGZ1bC4KCklmIGl0IGlzIGEgcmVncmVz c2lvbiBvciBjcml0aWNhbCBidWcsIHdlIGFsc28gYWRkIENjOiBzdGFibGUuCgpZb3VycywKTGlu dXMgV2FsbGVpagoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=