From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939ABC433FE for ; Tue, 22 Feb 2022 15:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233084AbiBVPPS (ORCPT ); Tue, 22 Feb 2022 10:15:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232742AbiBVPPR (ORCPT ); Tue, 22 Feb 2022 10:15:17 -0500 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF99115DB32 for ; Tue, 22 Feb 2022 07:14:51 -0800 (PST) Received: by mail-yb1-xb34.google.com with SMTP id j12so41782757ybh.8 for ; Tue, 22 Feb 2022 07:14:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jN84IyhQ+LgdWRqtd7lUvVay/DUmHfKHp5mv+NF+bno=; b=hWf49D2cc1xAa4d+bgbY+Oga7rh+MUwZ7eEUe/hiaKp64GiYTWgwiJVu6AePuaj4Tl 9sZeQT55+rHqoQbXylR1cTJYfbWe6Ce6ql8clWK0gNW5zF9Kno1OJYv6jB81j2wKRxSQ HcsdS1gpuKnEd3/loFc3F4loVj0EUeryHwNPzHBMjD2l8IFg8Bn6lKfO1NMmliwTq8ou R/1iJoF/McQufw313XFio22O3Mk4wDHOu4tsBeMlcuKray4bT7F9KIlV2GNWKDFSpwQu Yo26ubZd5rQwjNuQZMKGj3c5QlRiosQb7INSeeAZWMMshrypdAiGDDuV+o+8LGTMK78w FlbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jN84IyhQ+LgdWRqtd7lUvVay/DUmHfKHp5mv+NF+bno=; b=eaUqJFi9DlDBYT9ktsqwqPg/UHgXOLsddZgM8n737NNsc/nrjwLg3JRxOBlMDUYbMQ 8CYfF/btp+7QAh2QE58RdXxe76Yvviu1BDC/NmbboH5krd0pq27DCS1eB/YCjAGLd2D+ YCMIvPVnr5k5CNnCL1Tqm9L+Ca6vLI8uQv8PkPVFR5k56tsgATRPQXpZoGMnNQJGyRwB 0OhfzfJJgSPRySDnpqgkEjabxCv4+dUPBCI1phdJeKzd3F3+qJwh3wqAPHQ760rytXpV oHBcNVEIhayU5XZBKqW/iJqVKo/XAm7V01/2jgHWD0+qoGhNHXSOD9GW8pdjim0HoJfM iDuA== X-Gm-Message-State: AOAM531vedUcBF9WQYNJJC8EbD4lp4rkqp8UVl9+FLAKQaiuWKM3Q+gG WsRPFHKngkiROXB0+0SiXSa/BVlHul1B1+Mg/rYZ6w== X-Google-Smtp-Source: ABdhPJzCQX/ZTn+euSlhGiTqwhninqZpnHfPL8hOUkqp+hxxA9ki5u9bVgy5r9OEI/1A6NJMQ887ufAIeXBhqY0rWp8= X-Received: by 2002:a25:9108:0:b0:61e:329:700 with SMTP id v8-20020a259108000000b0061e03290700mr22861242ybl.369.1645542891248; Tue, 22 Feb 2022 07:14:51 -0800 (PST) MIME-Version: 1.0 References: <20220221184631.252308-1-alvin@pqrs.dk> <20220221184631.252308-3-alvin@pqrs.dk> <871qzviwhp.fsf@bang-olufsen.dk> In-Reply-To: <871qzviwhp.fsf@bang-olufsen.dk> From: Linus Walleij Date: Tue, 22 Feb 2022 16:14:39 +0100 Message-ID: Subject: Re: [PATCH v2 net-next 2/2] net: dsa: realtek: rtl8365mb: serialize indirect PHY register access To: =?UTF-8?Q?Alvin_=C5=A0ipraga?= Cc: =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Michael Rasmussen , Luiz Angelo Daros de Luca , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 22, 2022 at 1:19 AM Alvin =C5=A0ipraga w= rote: > > On Mon, Feb 21, 2022 at 7:46 PM Alvin =C5=A0ipraga wrot= e: > > What I worry about is whether we need to do a similar patch to > > rtl8366rb_phy_read() and rtl8366rb_phy_write() in > > rtl8366rb.c? > > Unfortunately I do not have the hardware to test rtl8366rb.c, so I can > only speculate. But I gave some hints in the commit message which might > help in checking whether or not it is an issue on that hardware as > well. The code for rtl8366rb_phy_read() looks similar, but since this is > a quirk of the hardware design, it could be that it is not > necessary. The only way is to test. I can test it. > If you or somebody else can confirm that it is an issue for RTL8366RB as > well, I will happily send a patch to the list for testing. You can for > example try spamming PHY register reads with phytool while also reading > off switch registers via regmap debugfs. See also the discussion in [1]. > > [1] https://lore.kernel.org/netdev/878rukib4f.fsf@bang-olufsen.dk/ If you have time to write a patch I'd love testing it! Yours, Linus Walleij