From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD9AECA9EAF for ; Thu, 24 Oct 2019 12:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81D852166E for ; Thu, 24 Oct 2019 12:07:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CwWCuv7z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439584AbfJXMG6 (ORCPT ); Thu, 24 Oct 2019 08:06:58 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:34981 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733180AbfJXMG5 (ORCPT ); Thu, 24 Oct 2019 08:06:57 -0400 Received: by mail-ua1-f65.google.com with SMTP id n41so7072304uae.2 for ; Thu, 24 Oct 2019 05:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+Lbvvl6tmDfsef6Adcm223n4P0saLVKySDcFwg4whEU=; b=CwWCuv7zqHDpb3UQa/HhY2uB032NkGh9fyxr+zHL/5NeEcJty7gKPJOyZH91LIGw1u 4Ig/ixYsJpvxvQq2bS+sOrYW4T5ZUEoVU38sq7UELpHT/0VqKITEOX+WK8tIcGE6w1FS JVx3sc2PgANsKhtJv2TY+buoWqv8uUNxqR6rACKXPic9BmQ39dF+y6gjqS/8IHAUx08F pfPRkH7SI6qa+O+wStiIyP+NyhhhbKhJi+LVE81jeNfpDqljknxTCK8TbS9a+5DBpxxQ U2NQyvJMvBngiOJggMOHDt+NRm7yBPfaJEZc/RkvfZkBheM4+fY7NeHGt+bdEL4WewuR tq4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+Lbvvl6tmDfsef6Adcm223n4P0saLVKySDcFwg4whEU=; b=Gy0tLRMQNn1BZ85Hqsg/eoyiyABQkAlIyLI4bELDGNrokp1zQFZe8rmos/J/oBMEuf PyUSqEgLQLgWh6RuxhJhEx+/O/tjRmn4QbW0TVGZTxksZ84ZgdwxOWUr+3nI0wwH7Hul ZRfBJnhmyuDq81p3826KYCv1OgoY1M+MVdDVDCdXLU6P5bpAOmmt/KKMUBlCB8ZRChii OG4pgqxuJv5KIBWsbGJ+RI/cvPxryYEHTr3eKIaileE3eXRfKRWL93Y9dIDDId7BfX4Z T/hCBZBJXouEHjFR8A6HD98hHYuBBbT5FJ0l0Ex2UZeGSRtiXHm0MVzx0w3Ti32Cj3N5 clBQ== X-Gm-Message-State: APjAAAVjAAsCUlqD+uZ1SIH9BS+Ud2+VAoypqIvY5BR+aBbe4N1urVgC g9XRzDd2nnWRNeVAWeJBGO96dYt76SM2S2jzV+BhojPK X-Google-Smtp-Source: APXvYqz/u7GDculbgv4Ltb7TsTfgDqc2G1JnhwfCdOEAQ5op57bB4jqXOhU4kGn1Y5/Z2ijpw5NUrHB9jSIPCGb29oQ= X-Received: by 2002:ab0:7043:: with SMTP id v3mr8419775ual.84.1571918816518; Thu, 24 Oct 2019 05:06:56 -0700 (PDT) MIME-Version: 1.0 References: <20191016142601.28255-1-geert+renesas@glider.be> In-Reply-To: <20191016142601.28255-1-geert+renesas@glider.be> From: Linus Walleij Date: Thu, 24 Oct 2019 14:06:45 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: sh-pfc: Do not use platform_get_irq() to count interrupts To: Geert Uytterhoeven Cc: "open list:GPIO SUBSYSTEM" , Linux-Renesas , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Oct 16, 2019 at 4:26 PM Geert Uytterhoeven wrote: > As platform_get_irq() now prints an error when the interrupt does not > exist, counting interrupts by looping until failure causes the printing > of scary messages like: > > sh-pfc e6060000.pin-controller: IRQ index 0 not found > > Fix this by using the platform_irq_count() helper instead. > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to = platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Yoshihiro Shimoda > Reviewed-by: Stephen Boyd > Reviewed-by: Niklas S=C3=B6derlund > Tested-by: Yoshihiro Shimoda > --- > v2: > - Add Reviewed-by, Tested-by. > > Linus: Can you please take this one, as it is a fix for v5.4? Thx! I'm not sure the little error message counts as a regression, certainly users can live with it. Can't you just put it in your queue for the next kernel? Yours, Linus Walleij