All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 13/21] mmc: core: Move public functions from core.h to private headers
Date: Mon, 9 Jan 2017 19:19:53 +0100	[thread overview]
Message-ID: <CACRpkdb0OHgWH4GDZPvN9SX69xNt52f_6oW1w43JTqKHh9nUpA@mail.gmail.com> (raw)
In-Reply-To: <1483102054-1752-14-git-send-email-ulf.hansson@linaro.org>

On Fri, Dec 30, 2016 at 1:47 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> A significant amount of functions are available through the public mmc
> core.h header file. Let's slim down this public mmc interface, as to
> prevent users from abusing it, by moving some of the functions to private
> mmc header files.
>
> This change concentrates on moving the functions into private mmc headers,
> following changes may continue with additional clean-ups, as an example
> some functions can be turned into static.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Nice, encapsulate!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  reply	other threads:[~2017-01-09 18:19 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 12:47 [PATCH 00/21] mmc: core: A start to slim down public mmc headers Ulf Hansson
2016-12-30 12:47 ` [PATCH 01/21] sh: sh7724: Don't use a public mmc header for MMC_PROGRESS* Ulf Hansson
2016-12-30 12:47   ` Ulf Hansson
2017-01-03  9:24   ` Simon Horman
2017-01-03  9:24     ` Simon Horman
2017-01-09 15:00   ` Linus Walleij
2017-01-09 15:00     ` Linus Walleij
2017-01-10 15:28     ` Ulf Hansson
2017-01-10 15:28       ` Ulf Hansson
2016-12-30 12:47 ` [PATCH 02/21] mmc: Removed the unused public mmc boot.h header Ulf Hansson
2017-01-09 15:01   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 03/21] mmc: sh_mmcif: Remove unused use_cd_gpio/cd_gpio from platform data Ulf Hansson
2017-01-09 15:03   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 04/21] mmc: sh_mmcif: Remove unused ->get_cd() platform callback Ulf Hansson
2017-01-09 15:04   ` Linus Walleij
2017-01-09 15:48     ` Geert Uytterhoeven
2016-12-30 12:47 ` [PATCH 05/21] mmc: sh_mmcif: Remove unused ccs_unsupported from the platform data Ulf Hansson
2017-01-09 15:05   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 06/21] mmc: sh_mmcif: Remove unused clk_ctrl2_present " Ulf Hansson
2017-01-09 15:06   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 07/21] mmc: dw_mmc: Remove the public dw_mmc header file Ulf Hansson
2017-01-09 15:13   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 08/21] mmc: sdhci-cadence: Include mmc.h Ulf Hansson
2017-01-09 15:14   ` Linus Walleij
2017-01-10  8:35   ` Adrian Hunter
2016-12-30 12:47 ` [PATCH 09/21] mmc: sdhci: Include leds.h Ulf Hansson
2016-12-30 13:35   ` Mateusz Nowak
2017-01-10 15:32     ` Ulf Hansson
2017-01-09 15:15   ` Linus Walleij
2017-01-10  8:32   ` Adrian Hunter
2016-12-30 12:47 ` [PATCH 10/21] mmc: host: Include interrupt.h in mmc host drivers that depends on it Ulf Hansson
2017-01-09 15:18   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 11/21] mmc: core: First step in cleaning up public mmc header files Ulf Hansson
2016-12-30 14:52   ` kbuild test robot
2016-12-30 15:11   ` kbuild test robot
2016-12-30 12:47 ` [PATCH 12/21] mmc: core: First step in cleaning up private " Ulf Hansson
2016-12-30 12:47 ` [PATCH 13/21] mmc: core: Move public functions from core.h to private headers Ulf Hansson
2017-01-09 18:19   ` Linus Walleij [this message]
2016-12-30 12:47 ` [PATCH 14/21] mmc: core: Move some host specific public functions to host.h Ulf Hansson
2017-01-09 18:21   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 15/21] mmc: core: Move erase/trim/discard defines from public core.h to mmc.h Ulf Hansson
2017-01-09 18:22   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 16/21] mmc: core: Remove unused struct _mmc_csd from public mmc.h header Ulf Hansson
2017-01-09 18:23   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 17/21] mmc: omap: Don't use mmc_card_present() when validating for inserted card Ulf Hansson
2017-01-02 17:11   ` Tony Lindgren
2017-01-09 18:24   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 18/21] mmc: vub300: " Ulf Hansson
2017-01-09 18:24   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 19/21] mmc: core: Move public functions from card.h to private headers Ulf Hansson
2017-01-09 18:26   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 20/21] mmc: core: Move public functions from host.h " Ulf Hansson
2017-01-09 18:26   ` Linus Walleij
2016-12-30 12:47 ` [PATCH 21/21] mmc: core: Don't use extern declarations of public mmc functions Ulf Hansson
2017-01-09 18:27   ` Linus Walleij
2017-01-10 15:37 ` [PATCH 00/21] mmc: core: A start to slim down public mmc headers Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdb0OHgWH4GDZPvN9SX69xNt52f_6oW1w43JTqKHh9nUpA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=adrian.hunter@intel.com \
    --cc=jh80.chung@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.