From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
David Heidelberg <david@ixit.cz>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
MSM <linux-arm-msm@vger.kernel.org>,
phone-devel@vger.kernel.org
Subject: Re: [PATCH] mfd: qcom-pm8xxx: switch away from using chained IRQ handlers
Date: Thu, 23 Sep 2021 02:04:10 +0200 [thread overview]
Message-ID: <CACRpkdb15D0m7L-vO7RFcAaVuS7hdD8J=6=15TFgRgvvsw1e9g@mail.gmail.com> (raw)
In-Reply-To: <20210921162433.1858296-1-dmitry.baryshkov@linaro.org>
On Tue, Sep 21, 2021 at 6:24 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
> PM8xxx PMIC family uses GPIO as parent IRQ. Using it together with the
> irq_set_chained_handler_and_data() results in warnings from the GPIOLIB
> as in this path the IRQ resources are not allocated (and thus the
> corresponding GPIO is not marked as used for the IRQ. Use request_irq so
> that the IRQ resources are proprely setup.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
I sent this patch:
https://lore.kernel.org/lkml/20210819154400.51932-1-linus.walleij@linaro.org/
David Heidelberg reported that it didn't work for him.
David can you test Dmitry's patch instead and see if that works
for you, I suppose I could have some bug in my patch :/
It would be nice with a Tested-by from David.
FWIW the code looks good:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-09-23 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 16:24 [PATCH] mfd: qcom-pm8xxx: switch away from using chained IRQ handlers Dmitry Baryshkov
2021-09-21 19:49 ` Bjorn Andersson
2021-09-21 20:47 ` Dmitry Baryshkov
2021-09-23 0:04 ` Linus Walleij [this message]
2021-09-23 5:19 ` David Heidelberg
2021-09-23 21:15 ` Linus Walleij
2021-10-06 8:03 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb15D0m7L-vO7RFcAaVuS7hdD8J=6=15TFgRgvvsw1e9g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=dmitry.baryshkov@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.