From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7B6C54E8E for ; Tue, 12 May 2020 12:22:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D3DE20661 for ; Tue, 12 May 2020 12:22:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fRMfmTqU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729229AbgELMWO (ORCPT ); Tue, 12 May 2020 08:22:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726891AbgELMWO (ORCPT ); Tue, 12 May 2020 08:22:14 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8831DC061A0E for ; Tue, 12 May 2020 05:22:12 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id f18so13359336lja.13 for ; Tue, 12 May 2020 05:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6rE0fPu5jCjuTK0cRn6PVF83ctsvQUR9eqdpVEWEcp8=; b=fRMfmTqU/svnwd/DeHQpZqANKDRENpPQrFnFCdA6XrC7CAjuUBlWO5WlHhJX1VdFZx GMq8lToALBRe4c2J8T+QxKo9JnROag//KysTHoivaIxpklZerMhBClnLLRGkf6GTvxAZ HkmO3moxLpKmk6A6rO8oP7BDRG8DnImZgtRVlxbihuFkbxwz1Ua1Vkr2ST+iiVDtsiMz +M1+jQ3zq3lb0Xi3P6DDhvioJsSDIiVLJW6i37AU92QD1VUuBYzTzk/eg8zmrLXxDlHD ODaToJfeFvwuXa2LV7sZKRly/f9mFOUS9o9v8dILxoPCrjdsYLDHOnR6njLXYMKzYGwc 5uhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6rE0fPu5jCjuTK0cRn6PVF83ctsvQUR9eqdpVEWEcp8=; b=QsDFMH4bJatRv+szHG+3ITEP1ben+JgB/FrFtsMqQL7/EpomqSRKZyf9Xkq49X8swF QfoS/0ziLY3jOgur/RLJu2GYSFTNj5uF8rrNRqdkrPOMPoujN+dZdwp6X/EHfdpIAzC8 8+6P+D4dElzyWUgNEv5igEcPLhgFOzldrOiAuuFz1X7QpqhPMk3cXMiUZ3nat5c42cu/ wclkgi/bL0WEQIrnLhfJC2lISbKSpVV0YOoh+Oi/9VD8Ke14ddVC/Pf3yR4dbvjzUsC7 M8PFXC5ckDJ5YOPULZKeOyspjcmGCrOL36Pliku48CbZVDqWBROTdgpWaSeY+QSKRbMh ecxg== X-Gm-Message-State: AOAM531wF7dj1AHgfqCvopkzKe2LLXkM9EsJXnzsoCWzUx3Ej3AoOkCO kt1/KQbdbnY1IU5XiEyFoaDFcfqqJkxYcU/i+/EuTA== X-Google-Smtp-Source: ABdhPJwIPX2HNFOXh8yU8/OwdxhhRENdd70ug7z8dIHFgzX2fvXuP4+XvRAkuMUcWF3Sb2fH8n4awGxwbFbw77QNBx8= X-Received: by 2002:a2e:9c97:: with SMTP id x23mr1647314lji.39.1589286131013; Tue, 12 May 2020 05:22:11 -0700 (PDT) MIME-Version: 1.0 References: <20200430194617.197510-1-dianders@chromium.org> <20200430124442.v4.1.Ia50267a5549392af8b37e67092ca653a59c95886@changeid> In-Reply-To: From: Linus Walleij Date: Tue, 12 May 2020 14:22:00 +0200 Message-ID: Subject: Re: [PATCH v4 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux To: Doug Anderson Cc: Bartosz Golaszewski , David Airlie , Daniel Vetter , Rob Herring , Neil Armstrong , Andrzej Hajda , Laurent Pinchart , Sandeep Panda , "open list:GPIO SUBSYSTEM" , Jonas Karlman , Rob Clark , Bjorn Andersson , Jeffrey Hugo , Jernej Skrabec , dri-devel , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Stephen Boyd , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, May 7, 2020 at 4:39 PM Doug Anderson wrote: > One suggestion that came off-list is to change the code to make the > numbering match up better with the datasheet. Right now if you want > GPIO 2 you have to refer to it like: > > hpd-gpios = <&sn65dsi86_bridge 1 GPIO_ACTIVE_HIGH>; > > That's because the code right now numbers things starting at 0 even if > the datasheet numbers things starting at 1. This is the hallmark of mixed-mode IC engineers at work. They are at heart analog IC designers so of course they enumerate everything starting at 1. Digital IC designers are like programmers and start on 0. Never the twain shall meet... Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32D4C54E8F for ; Tue, 12 May 2020 12:22:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C968320661 for ; Tue, 12 May 2020 12:22:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fRMfmTqU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C968320661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D68C6E8C5; Tue, 12 May 2020 12:22:14 +0000 (UTC) Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id A78FE6E8C5 for ; Tue, 12 May 2020 12:22:12 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id u6so13361632ljl.6 for ; Tue, 12 May 2020 05:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6rE0fPu5jCjuTK0cRn6PVF83ctsvQUR9eqdpVEWEcp8=; b=fRMfmTqU/svnwd/DeHQpZqANKDRENpPQrFnFCdA6XrC7CAjuUBlWO5WlHhJX1VdFZx GMq8lToALBRe4c2J8T+QxKo9JnROag//KysTHoivaIxpklZerMhBClnLLRGkf6GTvxAZ HkmO3moxLpKmk6A6rO8oP7BDRG8DnImZgtRVlxbihuFkbxwz1Ua1Vkr2ST+iiVDtsiMz +M1+jQ3zq3lb0Xi3P6DDhvioJsSDIiVLJW6i37AU92QD1VUuBYzTzk/eg8zmrLXxDlHD ODaToJfeFvwuXa2LV7sZKRly/f9mFOUS9o9v8dILxoPCrjdsYLDHOnR6njLXYMKzYGwc 5uhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6rE0fPu5jCjuTK0cRn6PVF83ctsvQUR9eqdpVEWEcp8=; b=I/T6O8oOejb3VVp/LKUHwWE9SRm+kq6iXmgMlP6OISZJSuFul8ep+D1kjEfvm3ZtRT +/irHl2oPbsyvrXfinsxM7GuwDxoikdeNpT/zLAnm3D05n4SRjC0Z1Hgk4SnZz5U46ir SLLcWe7+KDcs8jihNxYg6xf5XOv+S8sP7+jpDhudMTQXS+izKgulg7vcq6o/VIhU/gec tDSr0HIWLRgXxRa7pELg9dqhQxVC/45dsTv32gAYwWqvyRPRxB0ovHuKTkrR41q0jnnW FBG2flEGlzbBJFGnIsrziFAwh4YWFLE7vVhobneUaExF8qK7bHvQbi0IjKkPpl65Gygk biDQ== X-Gm-Message-State: AOAM533Q9CULyJgQn5gI5fud+CncbAkvPKHuuFRZg7FN7DHVwCi++BvJ zhbvkljpKhV+fdsaAxM2dr4CsuINc5Ge8UdNHRae6A== X-Google-Smtp-Source: ABdhPJwIPX2HNFOXh8yU8/OwdxhhRENdd70ug7z8dIHFgzX2fvXuP4+XvRAkuMUcWF3Sb2fH8n4awGxwbFbw77QNBx8= X-Received: by 2002:a2e:9c97:: with SMTP id x23mr1647314lji.39.1589286131013; Tue, 12 May 2020 05:22:11 -0700 (PDT) MIME-Version: 1.0 References: <20200430194617.197510-1-dianders@chromium.org> <20200430124442.v4.1.Ia50267a5549392af8b37e67092ca653a59c95886@changeid> In-Reply-To: From: Linus Walleij Date: Tue, 12 May 2020 14:22:00 +0200 Message-ID: Subject: Re: [PATCH v4 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux To: Doug Anderson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jernej Skrabec , Andrzej Hajda , David Airlie , linux-arm-msm , "open list:GPIO SUBSYSTEM" , Neil Armstrong , Jeffrey Hugo , Sandeep Panda , dri-devel , Bjorn Andersson , Bartosz Golaszewski , Jonas Karlman , Rob Herring , Laurent Pinchart , Stephen Boyd , LKML Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 7, 2020 at 4:39 PM Doug Anderson wrote: > One suggestion that came off-list is to change the code to make the > numbering match up better with the datasheet. Right now if you want > GPIO 2 you have to refer to it like: > > hpd-gpios = <&sn65dsi86_bridge 1 GPIO_ACTIVE_HIGH>; > > That's because the code right now numbers things starting at 0 even if > the datasheet numbers things starting at 1. This is the hallmark of mixed-mode IC engineers at work. They are at heart analog IC designers so of course they enumerate everything starting at 1. Digital IC designers are like programmers and start on 0. Never the twain shall meet... Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel