From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70DA3C6FA86 for ; Thu, 8 Sep 2022 08:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230496AbiIHId7 (ORCPT ); Thu, 8 Sep 2022 04:33:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230463AbiIHIdz (ORCPT ); Thu, 8 Sep 2022 04:33:55 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C891E1ABB for ; Thu, 8 Sep 2022 01:33:41 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id r17so8961216ejy.9 for ; Thu, 08 Sep 2022 01:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=yoKt2dR8DpMlh2XORFcltXAYMgjes8PsrrPXKGawrKEhed4y+WSSTQmmNgG0Gf1SJu /FfQ3PEPixSLl61o/wNzP2mAl16GeJnsTLbhWLnWfaVkAwo6y83SYrJYUs2zfFeTOmCJ KCfvXIX2k6sUR9M4H2LnnadTsaJNBeTiS5ZBjIN9tOf2Kpq6GTWefCkCUFHSnLO/4AAN bF2Kwwu1NBRMUHGOV8o4kZ9m3PqjItvKGaAHum8EmxiW7WxhfY/+qFWuKiEN2m/2UZCf n8HtcVv1JxiPWMi7HHbrHpse1K4PW6ghIMCVLd1VC32slTHEjJxXugMgMhGNvWgPOPtq zkOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=en/5rj0omXkf8yAa3UPpoKEzOoCVc5ApvHIZ9Wn+/cZ3qgfttw0m3DD6hLLeeV6sr6 GcWWTniODCj0JYbLDnOpqcRkO0VVI9Sbw74UFx979FH3EJ6WA6ptuecqZgm+nSX2cz2J 4f7vlWp1h4lnx9ukFJndfvTAc4O9N4MRk/sBgFCnpEBRGbJCPX5JgAUzt1JIJg1Lmpag tDM5e0CMUxMuSS6J8Fhsz+ctrEQaJY6JjNRBpbxTqE031mFUfQaxiWX2rKXOoQlnN4w3 NHYhJ7A2AESpzf+kMEUnEOQ/88jrbPi08S6/H35cYlHsiRpOZy5B2B0UThYSab+cK99i nhgw== X-Gm-Message-State: ACgBeo2TqqWE4YwiC/NHGo88srq+oD1MeHBIQSr/mdBwoItc2xoTfjzT 4jJSZR59RNROQ/8sPY6kDuUdB2/Nb488vvfZljUCMA== X-Google-Smtp-Source: AA6agR6YdmowLCqDy13X6GVFnJajdgoAbYXT6/9jX+Ol46w4Ykshwr2tFJzDmJvExLu3Rbp1DyOQwdZVX8mDYcaxnJ0= X-Received: by 2002:a17:907:7242:b0:741:770b:dfc6 with SMTP id ds2-20020a170907724200b00741770bdfc6mr5235773ejc.203.1662626019497; Thu, 08 Sep 2022 01:33:39 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-7-b29adfb27a6c@gmail.com> In-Reply-To: From: Linus Walleij Date: Thu, 8 Sep 2022 10:33:28 +0200 Message-ID: Subject: Re: [PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index() To: Dmitry Torokhov Cc: Thierry Reding , Mark Brown , Matti Vaittinen , Lorenzo Pieralisi , Claudiu Beznea , Liam Girdwood , Wim Van Sebroeck , Greg Kroah-Hartman , Guenter Roeck , Miquel Raynal , Felipe Balbi , Alexandre Belloni , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Vignesh Raghavendra , Daniel Vetter , Thomas Petazzoni , Alexandre Torgue , Marc Zyngier , Richard Weinberger , David Airlie , Nicolas Ferre , Alyssa Rosenzweig , Bartosz Golaszewski , Jonathan Hunter , Rob Herring , Maxime Coquelin , Bjorn Helgaas , =?UTF-8?Q?Pali_Roh=C3=A1r?= , linux-watchdog@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Sep 6, 2022 at 2:19 AM Dmitry Torokhov wrote: > On Sun, Sep 04, 2022 at 11:30:59PM -0700, Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic > > fwnode property API. > > > > Signed-off-by: Dmitry Torokhov > > > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > > index a2c3c207a04b..d83817d3ff86 100644 > > --- a/drivers/pci/controller/pcie-apple.c > > +++ b/drivers/pci/controller/pcie-apple.c > > @@ -516,8 +516,8 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > > u32 stat, idx; > > int ret, i; > > > > - reset = gpiod_get_from_of_node(np, "reset-gpios", 0, > > - GPIOD_OUT_LOW, "PERST#"); > > + reset = fwnode_gpiod_get_index(of_fwnode_handle(np), > > + "reset", 0, GPIOD_OUT_LOW, "PERST#"); > > Hmm, I am looking at the driver and it leaks the reset gpio on > unbind/unload. I guess it does not matter in practice, but still nice > not to leak. Thankfully it is easy to cure by switching to devm option: > devm_fwnode_gpiod_get(). > > I'll send and updated patch with a new justification. With that change: Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4FFEECAAD5 for ; Thu, 8 Sep 2022 08:33:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0488410E9A3; Thu, 8 Sep 2022 08:33:46 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFA0910E9A6 for ; Thu, 8 Sep 2022 08:33:40 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id r18so9105577eja.11 for ; Thu, 08 Sep 2022 01:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=yoKt2dR8DpMlh2XORFcltXAYMgjes8PsrrPXKGawrKEhed4y+WSSTQmmNgG0Gf1SJu /FfQ3PEPixSLl61o/wNzP2mAl16GeJnsTLbhWLnWfaVkAwo6y83SYrJYUs2zfFeTOmCJ KCfvXIX2k6sUR9M4H2LnnadTsaJNBeTiS5ZBjIN9tOf2Kpq6GTWefCkCUFHSnLO/4AAN bF2Kwwu1NBRMUHGOV8o4kZ9m3PqjItvKGaAHum8EmxiW7WxhfY/+qFWuKiEN2m/2UZCf n8HtcVv1JxiPWMi7HHbrHpse1K4PW6ghIMCVLd1VC32slTHEjJxXugMgMhGNvWgPOPtq zkOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=qGKiARHvFFLgLM2pRTz0J/r5xMceFFxhdsmYSWLVdYOic7tXHD2RvIyiEntFCMrZ8Y OgfwCBkSyREZoZ1fImzFU6y+cSdWnQr/Z/HNz9MIvyDKs1X04dw3UjbiTYX0QQaIWB2x zRNmTU95zO74g3YOjxLowgz8e7uYmfCmvt0MMzTCZyPefX3jsLhO8JO0/VxpzsVEpNid BcRwxLlvAhtuuJKsapsKp+MkvrHLsrMh5C3aBHhfz2905AHR4W0DMz6YmHGHpmaNIXtR Ip46bBluVjYL7e82+1xM+GYlunZF5dtI9O3jPjkoQNG1wzj3ey1UI3CPEIIpgfUUTyeO SCtA== X-Gm-Message-State: ACgBeo1GJM/Q1j1FQzwr7F/iCPFz/U/6p+GTUE8Ggi4EazE02UK1eJyt mGRGxNbRhsZCFKUXO1Y+4ItfYjt9JlH8CHYQS6B3ZQ== X-Google-Smtp-Source: AA6agR6YdmowLCqDy13X6GVFnJajdgoAbYXT6/9jX+Ol46w4Ykshwr2tFJzDmJvExLu3Rbp1DyOQwdZVX8mDYcaxnJ0= X-Received: by 2002:a17:907:7242:b0:741:770b:dfc6 with SMTP id ds2-20020a170907724200b00741770bdfc6mr5235773ejc.203.1662626019497; Thu, 08 Sep 2022 01:33:39 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-7-b29adfb27a6c@gmail.com> In-Reply-To: From: Linus Walleij Date: Thu, 8 Sep 2022 10:33:28 +0200 Message-ID: Subject: Re: [PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index() To: Dmitry Torokhov Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Alexandre Belloni , Vignesh Raghavendra , David Airlie , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Alexandre Torgue , dri-devel@lists.freedesktop.org, Liam Girdwood , linux-tegra@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, Thomas Petazzoni , Miquel Raynal , linux-stm32@st-md-mailman.stormreply.com, Alyssa Rosenzweig , linux-watchdog@vger.kernel.org, Marc Zyngier , Bartosz Golaszewski , Jonathan Hunter , Guenter Roeck , Maxime Coquelin , Matti Vaittinen , linux-gpio@vger.kernel.org, Mark Brown , Bjorn Helgaas , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Nicolas Ferre , linux-kernel@vger.kernel.org, Richard Weinberger , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Claudiu Beznea Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 6, 2022 at 2:19 AM Dmitry Torokhov wrote: > On Sun, Sep 04, 2022 at 11:30:59PM -0700, Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic > > fwnode property API. > > > > Signed-off-by: Dmitry Torokhov > > > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > > index a2c3c207a04b..d83817d3ff86 100644 > > --- a/drivers/pci/controller/pcie-apple.c > > +++ b/drivers/pci/controller/pcie-apple.c > > @@ -516,8 +516,8 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > > u32 stat, idx; > > int ret, i; > > > > - reset = gpiod_get_from_of_node(np, "reset-gpios", 0, > > - GPIOD_OUT_LOW, "PERST#"); > > + reset = fwnode_gpiod_get_index(of_fwnode_handle(np), > > + "reset", 0, GPIOD_OUT_LOW, "PERST#"); > > Hmm, I am looking at the driver and it leaks the reset gpio on > unbind/unload. I guess it does not matter in practice, but still nice > not to leak. Thankfully it is easy to cure by switching to devm option: > devm_fwnode_gpiod_get(). > > I'll send and updated patch with a new justification. With that change: Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88F66C54EE9 for ; Thu, 8 Sep 2022 08:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=08O5OKlSEgdTf/zWCj5aOskLEHnnOl2asp/YHwaZbTk=; b=rFWu0zGoKsJMJ8 c43zmhwajd9MMKtTSYk36HFaYIpAw2UuYgfLBJIqhmE7zjNOmtcXt8e7xCQ4Tkf5zMQAZp38SN1yB uVU5uVgzTbFLzVk/rvsObdnn7LXOXrS1YXZOLMR1MZ34GPUwEJMBOYdKfF8Pzh1UmJaxhEAnAEawZ nv0EwkrrWDDJqB7ZH4BZcGW/04c6yvG8qdKJuBKngbtAvPR4Gdk/QjB2M9b31S/BYQCtjDmppTUl0 rP7WG7/n2To8RY/Tfim9qXW2uYZcvAMU9udfBHDM3Q5p2kowhK2ryAfGu8Gw/SLfFElXptStMxiH/ +ZPcZCTcH38rylL4tLBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWCyy-0013Tg-Qp; Thu, 08 Sep 2022 08:33:56 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWCyl-0013Nl-3F for linux-mtd@lists.infradead.org; Thu, 08 Sep 2022 08:33:45 +0000 Received: by mail-ej1-x633.google.com with SMTP id gh9so14445249ejc.8 for ; Thu, 08 Sep 2022 01:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=yoKt2dR8DpMlh2XORFcltXAYMgjes8PsrrPXKGawrKEhed4y+WSSTQmmNgG0Gf1SJu /FfQ3PEPixSLl61o/wNzP2mAl16GeJnsTLbhWLnWfaVkAwo6y83SYrJYUs2zfFeTOmCJ KCfvXIX2k6sUR9M4H2LnnadTsaJNBeTiS5ZBjIN9tOf2Kpq6GTWefCkCUFHSnLO/4AAN bF2Kwwu1NBRMUHGOV8o4kZ9m3PqjItvKGaAHum8EmxiW7WxhfY/+qFWuKiEN2m/2UZCf n8HtcVv1JxiPWMi7HHbrHpse1K4PW6ghIMCVLd1VC32slTHEjJxXugMgMhGNvWgPOPtq zkOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=SvW4GSY+viHQMRP7jW4WuNCCivW6g8HPmrn0R6e2TYC494R6kbEsqnmG0c+X5DPw3s vWcj3TN/wDpGgVxjT4uMlI83AB2CMPBE2wVbB0lIYQw5WZkcRcvPiRJB+P72KYoRUsIm G/DJhBOsgMKJDWby22wgJcWQzUsS6Tpoo4cgGMfJ8PLJVirBpImAH/TfMnVZYaWQsjlv Pmr6rO80EnwPmykiBZuTkMwVPlmtPQLFGWifIzk2qmC2cmDTlz2ppV3E1qwSIhkO8Is5 3rqywPbRxjTLj/b2jignUE9YbsF1tVoyI3MSjSzCQkKv3VT+ITuOG9fTzNmkOd+8CwqX NMsg== X-Gm-Message-State: ACgBeo3K8rRCLlBdkRZXkjG+JIgfLoEzpc/yqB9iKVSEL78wAql8I7Vg qVhKv5HyetyLe5tQdqUnYUt+/dFKcOH1cP8rAOMk6Q== X-Google-Smtp-Source: AA6agR6YdmowLCqDy13X6GVFnJajdgoAbYXT6/9jX+Ol46w4Ykshwr2tFJzDmJvExLu3Rbp1DyOQwdZVX8mDYcaxnJ0= X-Received: by 2002:a17:907:7242:b0:741:770b:dfc6 with SMTP id ds2-20020a170907724200b00741770bdfc6mr5235773ejc.203.1662626019497; Thu, 08 Sep 2022 01:33:39 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-7-b29adfb27a6c@gmail.com> In-Reply-To: From: Linus Walleij Date: Thu, 8 Sep 2022 10:33:28 +0200 Message-ID: Subject: Re: [PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index() To: Dmitry Torokhov Cc: Thierry Reding , Mark Brown , Matti Vaittinen , Lorenzo Pieralisi , Claudiu Beznea , Liam Girdwood , Wim Van Sebroeck , Greg Kroah-Hartman , Guenter Roeck , Miquel Raynal , Felipe Balbi , Alexandre Belloni , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Vignesh Raghavendra , Daniel Vetter , Thomas Petazzoni , Alexandre Torgue , Marc Zyngier , Richard Weinberger , David Airlie , Nicolas Ferre , Alyssa Rosenzweig , Bartosz Golaszewski , Jonathan Hunter , Rob Herring , Maxime Coquelin , Bjorn Helgaas , =?UTF-8?Q?Pali_Roh=C3=A1r?= , linux-watchdog@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_013343_144921_96A2EB3D X-CRM114-Status: GOOD ( 22.06 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Sep 6, 2022 at 2:19 AM Dmitry Torokhov wrote: > On Sun, Sep 04, 2022 at 11:30:59PM -0700, Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic > > fwnode property API. > > > > Signed-off-by: Dmitry Torokhov > > > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > > index a2c3c207a04b..d83817d3ff86 100644 > > --- a/drivers/pci/controller/pcie-apple.c > > +++ b/drivers/pci/controller/pcie-apple.c > > @@ -516,8 +516,8 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > > u32 stat, idx; > > int ret, i; > > > > - reset = gpiod_get_from_of_node(np, "reset-gpios", 0, > > - GPIOD_OUT_LOW, "PERST#"); > > + reset = fwnode_gpiod_get_index(of_fwnode_handle(np), > > + "reset", 0, GPIOD_OUT_LOW, "PERST#"); > > Hmm, I am looking at the driver and it leaks the reset gpio on > unbind/unload. I guess it does not matter in practice, but still nice > not to leak. Thankfully it is easy to cure by switching to devm option: > devm_fwnode_gpiod_get(). > > I'll send and updated patch with a new justification. With that change: Reviewed-by: Linus Walleij Yours, Linus Walleij ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2983C38145 for ; Thu, 8 Sep 2022 08:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vpPqUtQT3FSi9D5NWqbWNNZHWaueDtDh5mUzEYz9a9w=; b=Y31oW1KjioRxfh SvyfgJhfph6336R95Lma7V2EZwFb/vKE4sRRG6+6fnaK/hcXMgZzswSPlu399qQ9/JJP+DDLIkdOj XqE0842mQSPkW3EYHeq5nCMbGiLFfr+SOT6JJYpI0Bfh9yrY/+EmTh/UKXOzhR0E9fuU5TMkOfI5l rRLpVhgG2KNoPTTa86nAcN9/twJlfoJ8oO2XsQdPDejEYIYtlkTL8nw0PFZ5h4M1eLjELLZDlrS8U Z83jeaSVxRXq7GKGUxtmD7IQrHBZXiuj84vDHYo4J/vdLrSNRDD1qhGWKFv3o1E8qQFi/2ZkwBY0P DqtQAXrolCChIKNmnCSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWCyo-0013QV-LS; Thu, 08 Sep 2022 08:33:46 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWCyk-0013Nm-6U for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 08:33:43 +0000 Received: by mail-ej1-x632.google.com with SMTP id dv25so7064597ejb.12 for ; Thu, 08 Sep 2022 01:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=yoKt2dR8DpMlh2XORFcltXAYMgjes8PsrrPXKGawrKEhed4y+WSSTQmmNgG0Gf1SJu /FfQ3PEPixSLl61o/wNzP2mAl16GeJnsTLbhWLnWfaVkAwo6y83SYrJYUs2zfFeTOmCJ KCfvXIX2k6sUR9M4H2LnnadTsaJNBeTiS5ZBjIN9tOf2Kpq6GTWefCkCUFHSnLO/4AAN bF2Kwwu1NBRMUHGOV8o4kZ9m3PqjItvKGaAHum8EmxiW7WxhfY/+qFWuKiEN2m/2UZCf n8HtcVv1JxiPWMi7HHbrHpse1K4PW6ghIMCVLd1VC32slTHEjJxXugMgMhGNvWgPOPtq zkOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ZlO9z6iariE6j62dDg3WdSSqBdCZFPhJNQtrGMOHOrM=; b=T0+GCnG9IXPVmgsgR6y7Yg6zq69qRUtmfhQ1fn6FHAkcR0yGxmhwTv5Rb8nipchIG2 VbUnEkNfaFp/KmLZ7JFerMWmLsUZx5bDgr6rL4EtgWpBHdAN3B9U2G0/Y1gq7ftn5bW+ Y/kymd1vHnQsh/umJUifoHLJNUip/ldS4anpeM/WtqpcJ4XZ48xUwZdSeqYXnd3z6A8x ts+tG5b7Uyt/Wun2sH1hBntUXd8ON9WUv3FjsTKcUB2c1lHb+Y1ITFWl0dTUmd8UBZhk IphilWi+jEe95EhLisVqzH+3PU4zyMAZ2XA9MgTHcgMi0iH2J6CA4jhfdUUYKXRJiIzq 74zA== X-Gm-Message-State: ACgBeo3jko19bpp3pkjiVqEDaH80iJoSO3IqxFOTSK/p2i4aHSlUMucX CfEK7e+iTKFa4tsuIaHuavcQE1+ItL6cZ2bzkgp1Hg== X-Google-Smtp-Source: AA6agR6YdmowLCqDy13X6GVFnJajdgoAbYXT6/9jX+Ol46w4Ykshwr2tFJzDmJvExLu3Rbp1DyOQwdZVX8mDYcaxnJ0= X-Received: by 2002:a17:907:7242:b0:741:770b:dfc6 with SMTP id ds2-20020a170907724200b00741770bdfc6mr5235773ejc.203.1662626019497; Thu, 08 Sep 2022 01:33:39 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-7-b29adfb27a6c@gmail.com> In-Reply-To: From: Linus Walleij Date: Thu, 8 Sep 2022 10:33:28 +0200 Message-ID: Subject: Re: [PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index() To: Dmitry Torokhov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_013342_302277_251D0E6F X-CRM114-Status: GOOD ( 22.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Alexandre Belloni , Vignesh Raghavendra , David Airlie , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Alexandre Torgue , dri-devel@lists.freedesktop.org, Liam Girdwood , linux-tegra@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, Thomas Petazzoni , Miquel Raynal , linux-stm32@st-md-mailman.stormreply.com, Alyssa Rosenzweig , linux-watchdog@vger.kernel.org, Rob Herring , Marc Zyngier , Bartosz Golaszewski , Jonathan Hunter , Guenter Roeck , Maxime Coquelin , Matti Vaittinen , linux-gpio@vger.kernel.org, Mark Brown , Bjorn Helgaas , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Vetter , Richard Weinberger , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Claudiu Beznea Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 6, 2022 at 2:19 AM Dmitry Torokhov wrote: > On Sun, Sep 04, 2022 at 11:30:59PM -0700, Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic > > fwnode property API. > > > > Signed-off-by: Dmitry Torokhov > > > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > > index a2c3c207a04b..d83817d3ff86 100644 > > --- a/drivers/pci/controller/pcie-apple.c > > +++ b/drivers/pci/controller/pcie-apple.c > > @@ -516,8 +516,8 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > > u32 stat, idx; > > int ret, i; > > > > - reset = gpiod_get_from_of_node(np, "reset-gpios", 0, > > - GPIOD_OUT_LOW, "PERST#"); > > + reset = fwnode_gpiod_get_index(of_fwnode_handle(np), > > + "reset", 0, GPIOD_OUT_LOW, "PERST#"); > > Hmm, I am looking at the driver and it leaks the reset gpio on > unbind/unload. I guess it does not matter in practice, but still nice > not to leak. Thankfully it is easy to cure by switching to devm option: > devm_fwnode_gpiod_get(). > > I'll send and updated patch with a new justification. With that change: Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel