From: Linus Walleij <linus.walleij@linaro.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Robert Richter <rrichter@marvell.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: thunderx: fix irq_request_resources
Date: Thu, 12 Mar 2020 14:42:05 +0100 [thread overview]
Message-ID: <CACRpkdb3VzOFmnZkXXopsbKAAiQ9nzsqm6fMpcsCfmuvmaeOmg@mail.gmail.com> (raw)
In-Reply-To: <1583941433-15876-1-git-send-email-tharvey@gateworks.com>
On Wed, Mar 11, 2020 at 4:43 PM Tim Harvey <tharvey@gateworks.com> wrote:
> If there are no parent resources do not call irq_chip_request_resources_parent
> at all as this will return an error.
>
> This resolves a regression where devices using a thunderx gpio as an interrupt
> would fail probing.
>
> Fixes: 0d04d0c ("gpio: thunderx: Use the default parent apis for {request,release}_resources")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
This patch does not apply to the mainline kernel or v5.6-rc1.
Please verify:
1. If the problem is still in v5.6 (we refactored the driver to
use GPIOLIB_IRQCHIP)
2. If not, only propose it for linux-stable v5.5 etc.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-03-12 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 15:43 [PATCH] gpio: thunderx: fix irq_request_resources Tim Harvey
2020-03-12 13:42 ` Linus Walleij [this message]
2020-03-12 17:16 ` Tim Harvey
2020-03-13 15:01 ` Sasha Levin
2020-03-25 23:33 ` Linus Walleij
2020-03-13 15:31 ` Robert Richter
2020-03-13 19:12 ` Robert Richter
2020-03-13 19:41 ` Tim Harvey
2020-03-13 20:24 ` Robert Richter
2020-03-13 21:06 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb3VzOFmnZkXXopsbKAAiQ9nzsqm6fMpcsCfmuvmaeOmg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=rrichter@marvell.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.