From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F56C33C99 for ; Tue, 7 Jan 2020 10:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1D1020848 for ; Tue, 7 Jan 2020 10:04:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C/TMqDRf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbgAGKE0 (ORCPT ); Tue, 7 Jan 2020 05:04:26 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:42978 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727154AbgAGKE0 (ORCPT ); Tue, 7 Jan 2020 05:04:26 -0500 Received: by mail-lf1-f68.google.com with SMTP id y19so38420566lfl.9 for ; Tue, 07 Jan 2020 02:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IaT+HGrfAbav44v71XZlSNd1URgNRj4zIy7n7ZKUqH4=; b=C/TMqDRfkoUuJ0f7T7D+O5oR+b6o4w0FNo/T1F+R1AHCSi74QZrP0ulqX/mlk/yMb3 CgBbnBDXHH3RQbFfjeIBmDCMxBgBJoWMyfSinbTkTKu7+eAqlL4UQ+G6Qu9e8sGULoAW scPPSgM5ky8Dgu+u+57Yj0r+9bLeLU5VTQ5mngb2qRSIofjffwJo8cHE39XF1zC55KbR sBdWKaMBlfnmYRjXkQ6NzWwAl4XoASa4PfrvonyU+r6J1Kj88we/W4tZT4yErxsOgisP oDj7YGWcd/AGmfR3FZQWc7Lz9Z+TBcTUrOnS7BUoLmif98Q98aJ28tRnBC4luasznBue V+Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IaT+HGrfAbav44v71XZlSNd1URgNRj4zIy7n7ZKUqH4=; b=BkNjlQg7k81oZqQCEgmYE+El0qKgomOCRgEAIHmSOo18o/ztnnIsekpfgZUA6B8XF9 vRbinyYejsdpPNBMB6oW4wRJCR46xSEhNuQn0jDdKIdVHV7qX/XJjCTI/P3OnWFXwUip df01fBPJVtftWXaeOx2eJoN9Ah+M+F0Ss1+B5WN/eUMJvNMQSSOneXbCUO6mmdVSGFk2 aBAmCimH7rpZlAXeMTP2If1exQqLUoVaxPEpBlEwu7Ju+J3CYVqxZ7hDJO6goF8CKszW KtpgieddT1BscG68BszAwld3lAGz/KUv+hahNiGDUgHko2CPnf38quSA1Uy3ojk0A7JR kVQA== X-Gm-Message-State: APjAAAUgCNlCOX0URUP80Ln2l6OkbjhECLAdTEdWdCnjZPuOAYelx72u eU3Iafw2PoQ4WB7BwSsAuixwbFLyohUSgSWYFzFhhw== X-Google-Smtp-Source: APXvYqzIqvdiEJyuN737lKRaPRJmxancOJCuQ7zjFMf8BOpiiEvcoUI8UR/icK9L/Hp7tnD+upUM0vg9QbSylxpdyTQ= X-Received: by 2002:a19:2389:: with SMTP id j131mr56672702lfj.86.1578391464246; Tue, 07 Jan 2020 02:04:24 -0800 (PST) MIME-Version: 1.0 References: <20191224120709.18247-1-brgl@bgdev.pl> <20191224120709.18247-5-brgl@bgdev.pl> In-Reply-To: <20191224120709.18247-5-brgl@bgdev.pl> From: Linus Walleij Date: Tue, 7 Jan 2020 11:04:13 +0100 Message-ID: Subject: Re: [PATCH v4 04/13] gpiolib: use gpiochip_get_desc() in linehandle_create() To: Bartosz Golaszewski Cc: Kent Gibson , Andy Shevchenko , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Dec 24, 2019 at 1:07 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Unduplicate the ngpio check by simply calling gpiochip_get_desc() and > checking its return value. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij