From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C2FC4321E for ; Sun, 1 May 2022 21:48:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350281AbiEAVwE (ORCPT ); Sun, 1 May 2022 17:52:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359636AbiEAVwC (ORCPT ); Sun, 1 May 2022 17:52:02 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62DDE48E75 for ; Sun, 1 May 2022 14:48:35 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-2f863469afbso107651587b3.0 for ; Sun, 01 May 2022 14:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=zwY5ZnqN7kNhGK99pE/WVaiRJMMJk1J46UwT4pwImXGX6UOmFH90vIl3pqBFOiefpf XGDauOFPVnr0N+wehwWqxGedJrPEnCfA7QYfI1Ud6pUqjR0VJCUMCPCgmokVJfJlO5J3 9fgUKiXoKaLiNlZ2lnMOc8odLW1cWM39J6DifJp1VzhPP3yFCswh3y7kpJGPLRycUKkx MOm6n0oCCKvOF9FQQTqGTr1+Nj0qDNWhyJnFD6sUHzDc8vvEHbsUWHtvJVGJUVLO7jGU zEl/kVv1ENb3aFDPeJIshWrcYr3gbS2Bho2vG2ESmIY+jYGxLU0tAEUviHdRTMa60iKl bN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=oJgNSi3D+iOjss7jFzVYbiQokGhDAbfkRjH2CSsBB/4fszkG7yWT/M2IwpGzAZzSEg euyjhkOXDg6nlS5EWTppkN/jy1n0yBM9G1vNaFPih/kHguMIwPZgQfPc7sbNW0+qFKsj gLwR5JoaMJjUKEAN2sdasbBNu7BQ3betVMDJlNcP6I2Pe1IMrx2RGSlXFAZp5oLPFQv2 FRsCNske6p/arIfmEhvbphw9c1Npjf57LVfvdAtAEF9eplovOBWfv3UFh8uypiym0Se4 VEKY/TO4SfGXNjQnRDq0MX863Ypg9be96vL8ayaKq4g7AKWBPp3KSXRw8W6T3p0T4SCE FTBg== X-Gm-Message-State: AOAM531Vpo59U1ppB8P/rz0Hp/GbvyY5BJXLAuuD/un++T715oVlMTWb N11FHkiiNEMoT7VcQClsQbchLwvlhkFYxq864jk+GQ== X-Google-Smtp-Source: ABdhPJyC4yrP3wkFWKCa3+OUAbpp0OAp6QL2ydyOZCULhsvaONngjc+9/s4GocTjYt3qkP0LOVwZrKfaB6+LtqaJLgI= X-Received: by 2002:a0d:f0c3:0:b0:2f4:d291:9dde with SMTP id z186-20020a0df0c3000000b002f4d2919ddemr9084184ywe.437.1651441714674; Sun, 01 May 2022 14:48:34 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-25-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-25-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:48:23 +0200 Message-ID: Subject: Re: [PATCH 24/48] ARM: pxa: mainstone-wm97xx: use gpio lookup table To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, Apr 19, 2022 at 6:42 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > This driver hardcodes gpio numbers without a header file. > Use lookup tables instead. > > Cc: Marek Vasut > Acked-by: Dmitry Torokhov > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: linux-input@vger.kernel.org > Signed-off-by: Arnd Bergmann Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 934DAC433EF for ; Sun, 1 May 2022 21:48:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC28110E363; Sun, 1 May 2022 21:48:36 +0000 (UTC) Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72FD310E34F for ; Sun, 1 May 2022 21:48:35 +0000 (UTC) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-2f7ca2ce255so131576957b3.7 for ; Sun, 01 May 2022 14:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=zwY5ZnqN7kNhGK99pE/WVaiRJMMJk1J46UwT4pwImXGX6UOmFH90vIl3pqBFOiefpf XGDauOFPVnr0N+wehwWqxGedJrPEnCfA7QYfI1Ud6pUqjR0VJCUMCPCgmokVJfJlO5J3 9fgUKiXoKaLiNlZ2lnMOc8odLW1cWM39J6DifJp1VzhPP3yFCswh3y7kpJGPLRycUKkx MOm6n0oCCKvOF9FQQTqGTr1+Nj0qDNWhyJnFD6sUHzDc8vvEHbsUWHtvJVGJUVLO7jGU zEl/kVv1ENb3aFDPeJIshWrcYr3gbS2Bho2vG2ESmIY+jYGxLU0tAEUviHdRTMa60iKl bN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=kYoKkyLYKo+GQwAsRl14waZwxxFekzwCxsUBVdaiAKPQxv23b+wc46VewGw/+azPKy JlE2BZE+RadEq8gEDGojo+RJphijU/cctayBIeX3mtAQ0sS0tM4yAXZg6k3k7axlx28m WSLKg6AOUp5eVie+CObE+ERlz1ODvOSdZDh+nkqWti8r7ow0Jjub1qtxBVR8vfLyvilD ii9wYY2cyD7skejmE5yXG8YxeBo2kr6Qor+jTC3Bmss7FbLMCWjH1gNum7SB3afCZvIi J4Spgd03Mqgin0E5dM098i44DnFxHodosN2FThAPOD20x4X/lk5p1jID2meBZh7aCmXN rN1Q== X-Gm-Message-State: AOAM530bQHJPO2BuV0+WV+1Zl/filLRxV/4IBt0Q7i+iMidINNj3J7i9 Uu5RPHwXiYHixnUyixh1cBgRySVWedGbr0lSmeMgWA== X-Google-Smtp-Source: ABdhPJyC4yrP3wkFWKCa3+OUAbpp0OAp6QL2ydyOZCULhsvaONngjc+9/s4GocTjYt3qkP0LOVwZrKfaB6+LtqaJLgI= X-Received: by 2002:a0d:f0c3:0:b0:2f4:d291:9dde with SMTP id z186-20020a0df0c3000000b002f4d2919ddemr9084184ywe.437.1651441714674; Sun, 01 May 2022 14:48:34 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-25-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-25-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:48:23 +0200 Message-ID: Subject: Re: [PATCH 24/48] ARM: pxa: mainstone-wm97xx: use gpio lookup table To: Arnd Bergmann Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar , Sergey Lapin , linux-fbdev@vger.kernel.org, Dominik Brodowski , linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, Tomas Cech , robert.jarzmik@free.fr, linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Helge Deller , Marek Vasut , Paul Parsons , Michael Turquette , Arnd Bergmann , linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , Lubomir Rintel , Mark Brown , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Stephen Boyd , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 19, 2022 at 6:42 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > This driver hardcodes gpio numbers without a header file. > Use lookup tables instead. > > Cc: Marek Vasut > Acked-by: Dmitry Torokhov > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: linux-input@vger.kernel.org > Signed-off-by: Arnd Bergmann Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B125C433F5 for ; Sun, 1 May 2022 21:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GgRIlYuw94ZFbdBImy79fSKFTgdhXTuLto1Cn/Ce+JE=; b=DxOEQnaH+x5bpi rbibsQRVC1bjwcZr3nb27xM3g9zg02keIAGsvizYAD+/uDd1vYmOlnqOfTVh13AZQBLrCrnAPE9fP lulqaDwDXYZS2/btW7eN1h+oVkBrzIvSfNar/B9R5JTSe0SLisJI5JvKdI9T+Qcez3CMr1siQ+Zs7 jSa1p9+ribj2JPOsWKH1N/dtOS+tEF3aRBSW48bRp/38EMFNLm1tlwLKQyXkPJINAUXxeW94770iR nOWIHxwJhb7gDhheoc+A4MMulAQHFTUYDQKnCjw4OZ95Jok1HYPABXBJz0budfO6mW0dEL/8FIew9 zNRwuox77uVoxzWYkULQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHQx-00Gz9s-Q2; Sun, 01 May 2022 21:48:51 +0000 Received: from mail-yw1-x112a.google.com ([2607:f8b0:4864:20::112a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHQh-00Gz11-IH for linux-mtd@lists.infradead.org; Sun, 01 May 2022 21:48:36 +0000 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-2ef5380669cso131603897b3.9 for ; Sun, 01 May 2022 14:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=zwY5ZnqN7kNhGK99pE/WVaiRJMMJk1J46UwT4pwImXGX6UOmFH90vIl3pqBFOiefpf XGDauOFPVnr0N+wehwWqxGedJrPEnCfA7QYfI1Ud6pUqjR0VJCUMCPCgmokVJfJlO5J3 9fgUKiXoKaLiNlZ2lnMOc8odLW1cWM39J6DifJp1VzhPP3yFCswh3y7kpJGPLRycUKkx MOm6n0oCCKvOF9FQQTqGTr1+Nj0qDNWhyJnFD6sUHzDc8vvEHbsUWHtvJVGJUVLO7jGU zEl/kVv1ENb3aFDPeJIshWrcYr3gbS2Bho2vG2ESmIY+jYGxLU0tAEUviHdRTMa60iKl bN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=08dPSz74kUJ0cwN6eB3nhnUC1Jni2rQAK9cNZUCJqQN6ymolOmBm3vaHLEjc1/ppZg G+tKRMzx3HXnm29VxMCvJwtWRZnf49THqdXV8/o51x4ZMM5YcJXGtoarOhNWCpsNheKq 41vSk8p7an1+CvpE9ff1u9rUeyaPfMDa/SIocvQdyqXkKoCHIXyxU7jQAeAESJ2ea0wz f445Kg7a6fCwWWWGYMvmTnDByqiEsv1vHgB8zrf8gU5HjzhluCIFWELwEW9mYQBnnNfC fu18wi00O3mF2IeiicjdBT5bEBf8N/MYcoLFrJHA/FxipNHFyIGGD6SA5CVp2oP+tnqi Uucw== X-Gm-Message-State: AOAM533h2emeq9mJaE3zAONxrYQkEPosGwEPsjvVVEstG0vYx7lN4sZ/ A3w2KnX9XvEWT8wV305qkk0k4rrp/gjCHFj9Yyu83A== X-Google-Smtp-Source: ABdhPJyC4yrP3wkFWKCa3+OUAbpp0OAp6QL2ydyOZCULhsvaONngjc+9/s4GocTjYt3qkP0LOVwZrKfaB6+LtqaJLgI= X-Received: by 2002:a0d:f0c3:0:b0:2f4:d291:9dde with SMTP id z186-20020a0df0c3000000b002f4d2919ddemr9084184ywe.437.1651441714674; Sun, 01 May 2022 14:48:34 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-25-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-25-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:48:23 +0200 Message-ID: Subject: Re: [PATCH 24/48] ARM: pxa: mainstone-wm97xx: use gpio lookup table To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220501_144835_676083_D716F729 X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 6:42 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > This driver hardcodes gpio numbers without a header file. > Use lookup tables instead. > > Cc: Marek Vasut > Acked-by: Dmitry Torokhov > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: linux-input@vger.kernel.org > Signed-off-by: Arnd Bergmann Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 116FBC433EF for ; Sun, 1 May 2022 21:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d+vGSpzhiTMyCcCGMYGdmQ4RO21+47c0JicnNO+xqjY=; b=jyoxrzL6oZmrMM xfFu+G41T3jhRIn00FZeqnPxI+QXNSMjBnU5NVz7Y2VX1nsHjaJciEcoUYD111/vs2FdqXCvBH/C3 dN7QkIwQJsM3IKvhVdD7MMtjZLn9hkDJvX2010dg5srXecuSEF7focNQxK5duhIeWBNh2tBeDCgFA 5M8qTdx0SCNogmM7k9zri7mJl89XagDRqgGn9AddcQdFE7hvdrJm+YZHNTRzF2tOWV/JJdqYa8VXS fy7hvRw7MjCaiUsslFzy1AhLoiLPfisDmszGqcc6HebBqt0lmuhC72Ie0gM1VYvy4grN+K4MR6z5F P4pV091EmF5wgb/nk6ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHQk-00Gz2x-TR; Sun, 01 May 2022 21:48:39 +0000 Received: from mail-yw1-x112a.google.com ([2607:f8b0:4864:20::112a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHQh-00Gz12-I4 for linux-arm-kernel@lists.infradead.org; Sun, 01 May 2022 21:48:36 +0000 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-2f83983782fso131751307b3.6 for ; Sun, 01 May 2022 14:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=zwY5ZnqN7kNhGK99pE/WVaiRJMMJk1J46UwT4pwImXGX6UOmFH90vIl3pqBFOiefpf XGDauOFPVnr0N+wehwWqxGedJrPEnCfA7QYfI1Ud6pUqjR0VJCUMCPCgmokVJfJlO5J3 9fgUKiXoKaLiNlZ2lnMOc8odLW1cWM39J6DifJp1VzhPP3yFCswh3y7kpJGPLRycUKkx MOm6n0oCCKvOF9FQQTqGTr1+Nj0qDNWhyJnFD6sUHzDc8vvEHbsUWHtvJVGJUVLO7jGU zEl/kVv1ENb3aFDPeJIshWrcYr3gbS2Bho2vG2ESmIY+jYGxLU0tAEUviHdRTMa60iKl bN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IF3vEg3+jPF9cVJcI8jPci4JS9DP0GVP7RD7934mEjE=; b=lwZqsFEMx8XeQLFs2lPKhBo840JnfSzDKIKPrMlGh8BE08azEu6Gipuo/h+pSW1GZe GJlzqzPeH7u8kMSEe9uFd0HXgfWi08KmBVr41HpIXGCR5ZzceNTKohMjAQK2N5dS8k7Q hugn92F9Iqa5q5l3evsy7E1I99GaFPDPIGrSl6HWdL8f6Jlkg0rBXPCiSXsItk8dT0Nf zB75pkoGTfYkCF+FGrXit7+t3KakDZCnXRkVYTZuRApbq7IKXpN0bWqtl4+akGYdmc5e N160A3i0rXaKFyg3mi+DnJNL1lV7lGW0n76EaxQ5qfsJylvQoRV+xIdjiNnhD7XKm9Hc wrlA== X-Gm-Message-State: AOAM532ve2qWmrBEcF7f8jCGYcypBrWiMwwy+2KKeSA0jJXg244p349f /Be8BblhBce54WkuVNSOinTEHvaiD4m2ROXsN90E6Q== X-Google-Smtp-Source: ABdhPJyC4yrP3wkFWKCa3+OUAbpp0OAp6QL2ydyOZCULhsvaONngjc+9/s4GocTjYt3qkP0LOVwZrKfaB6+LtqaJLgI= X-Received: by 2002:a0d:f0c3:0:b0:2f4:d291:9dde with SMTP id z186-20020a0df0c3000000b002f4d2919ddemr9084184ywe.437.1651441714674; Sun, 01 May 2022 14:48:34 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-25-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-25-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:48:23 +0200 Message-ID: Subject: Re: [PATCH 24/48] ARM: pxa: mainstone-wm97xx: use gpio lookup table To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220501_144835_668906_5DB811E0 X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 6:42 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > This driver hardcodes gpio numbers without a header file. > Use lookup tables instead. > > Cc: Marek Vasut > Acked-by: Dmitry Torokhov > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: linux-input@vger.kernel.org > Signed-off-by: Arnd Bergmann Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel