From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver Date: Thu, 15 Nov 2012 15:17:10 +0100 Message-ID: References: <4a92290e8a3b1a19c3a5e864edfa7badfc2af5d0.1352608333.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4a92290e8a3b1a19c3a5e864edfa7badfc2af5d0.1352608333.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Viresh Kumar Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, Shiraz Hashim , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sr-ynQEQJNshbs@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, Nov 11, 2012 at 5:39 AM, Viresh Kumar wrote: > From: Shiraz Hashim > > SPEAr platform provides a provision to control chipselects of ARM PL022 > Prime Cell spi controller through its system registers, which otherwise > remains under PL022 control which some protocols do not want. > > This commit intends to provide the spi chipselect control in software > over gpiolib interface. Since it is tied to pinctrl, we place it under > 'drivers/pinctrl/spear/' directory. > > spi chip drivers can use the exported gpiolib interface to define their > chipselect through DT or platform data. > > Cc: Linus Walleij > Signed-off-by: Shiraz Hashim > Reviewed-by: Vipin Kumar > Signed-off-by: Viresh Kumar This sure looks good, sorry for the delay. Just one question: since this driver is not using any pinctrl interfaces, why is it under drivers/pinctrl/*? Shouldn't it be under drivers/gpio from a technical point of view? I think I'd accept it under drivers/pinctrl/spear/* if you just want this to keep everything SPEAr-related in one place though, so enlighten me. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Thu, 15 Nov 2012 15:17:10 +0100 Subject: [PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver In-Reply-To: <4a92290e8a3b1a19c3a5e864edfa7badfc2af5d0.1352608333.git.viresh.kumar@linaro.org> References: <4a92290e8a3b1a19c3a5e864edfa7badfc2af5d0.1352608333.git.viresh.kumar@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Nov 11, 2012 at 5:39 AM, Viresh Kumar wrote: > From: Shiraz Hashim > > SPEAr platform provides a provision to control chipselects of ARM PL022 > Prime Cell spi controller through its system registers, which otherwise > remains under PL022 control which some protocols do not want. > > This commit intends to provide the spi chipselect control in software > over gpiolib interface. Since it is tied to pinctrl, we place it under > 'drivers/pinctrl/spear/' directory. > > spi chip drivers can use the exported gpiolib interface to define their > chipselect through DT or platform data. > > Cc: Linus Walleij > Signed-off-by: Shiraz Hashim > Reviewed-by: Vipin Kumar > Signed-off-by: Viresh Kumar This sure looks good, sorry for the delay. Just one question: since this driver is not using any pinctrl interfaces, why is it under drivers/pinctrl/*? Shouldn't it be under drivers/gpio from a technical point of view? I think I'd accept it under drivers/pinctrl/spear/* if you just want this to keep everything SPEAr-related in one place though, so enlighten me. Yours, Linus Walleij