From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 23/39] usb: musb: ux500: harden checks for platform data Date: Thu, 30 May 2013 10:34:00 +0200 Message-ID: References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-24-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Felipe Balbi , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "David S. Miller" , Herbert Xu , Vinod Koul , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR To: Lee Jones Return-path: In-Reply-To: <1368611522-9984-24-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > In its current state, the ux500-musb driver uses platform data pointers > blindly with no prior checking. If no platform data pointer is passed > this will Oops the kernel. In this patch we ensure platform data and > board data are present prior to using them. > > Cc: Felipe Balbi > Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030223Ab3E3IeJ (ORCPT ); Thu, 30 May 2013 04:34:09 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:59310 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967903Ab3E3IeB (ORCPT ); Thu, 30 May 2013 04:34:01 -0400 MIME-Version: 1.0 In-Reply-To: <1368611522-9984-24-git-send-email-lee.jones@linaro.org> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-24-git-send-email-lee.jones@linaro.org> Date: Thu, 30 May 2013 10:34:00 +0200 Message-ID: Subject: Re: [PATCH 23/39] usb: musb: ux500: harden checks for platform data From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Felipe Balbi , "linux-usb@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "David S. Miller" , Herbert Xu , Vinod Koul , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > In its current state, the ux500-musb driver uses platform data pointers > blindly with no prior checking. If no platform data pointer is passed > this will Oops the kernel. In this patch we ensure platform data and > board data are present prior to using them. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Thu, 30 May 2013 10:34:00 +0200 Subject: [PATCH 23/39] usb: musb: ux500: harden checks for platform data In-Reply-To: <1368611522-9984-24-git-send-email-lee.jones@linaro.org> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-24-git-send-email-lee.jones@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > In its current state, the ux500-musb driver uses platform data pointers > blindly with no prior checking. If no platform data pointer is passed > this will Oops the kernel. In this patch we ensure platform data and > board data are present prior to using them. > > Cc: Felipe Balbi > Cc: linux-usb at vger.kernel.org > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij