From: Linus Walleij <linus.walleij@linaro.org>
To: Shyam Sundar S K <ssundark@amd.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Agrawal, Nitesh-kumar" <Nitesh-kumar.Agrawal@amd.com>,
"Sen, Pankaj" <Pankaj.Sen@amd.com>,
"Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>
Subject: Re: [PATCH] pinctrl/amd: Set the level based on ACPI tables
Date: Wed, 28 Dec 2016 13:32:14 +0100 [thread overview]
Message-ID: <CACRpkdbD_OgxcS50TQk+KpAX_qrsy9GKiDrgmDsk7JyR=yxreQ@mail.gmail.com> (raw)
In-Reply-To: <61a2d2f5-2d84-af87-deda-adba064b1dba@amd.com>
On Thu, Dec 8, 2016 at 1:01 PM, Shyam Sundar S K <ssundark@amd.com> wrote:
> In the function amd_gpio_irq_set_type, read the values from
> the ACPI table to set the level and drop the settings passed
> by the client.
>
> Reviewed-by: Pankaj Sen <Pankaj.Sen@amd.com>
> Reviewed-by: Nitesh Kumar Agrawal <Nitesh-kumar.Agrawal@amd.com>
> Reviewed-by: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@amd.com>
> Signed-off-by: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com>
Patch applied. The code makes a lot more sense now, too.
> - /*
> - * When level_trig is set EDGE and active_level is set HIGH in BIOS
> - * default settings, ignore incoming settings from client and use
> - * BIOS settings to configure GPIO register.
> + /* Ignore the settings coming from the client and
> + * read the values from the ACPI tables
> + * while setting the trigger type
In my book you do the exact opposite: the client/consumer is the device
making use of this IRQ, and that defines what trigger to set.
Before this, you let the hardware power-on defaults define the trigger, which
was probably not such a good idea.
But it's just a comment so I don't care much.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-12-28 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 12:01 [PATCH] pinctrl/amd: Set the level based on ACPI tables Shyam Sundar S K
2016-12-28 12:32 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbD_OgxcS50TQk+KpAX_qrsy9GKiDrgmDsk7JyR=yxreQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Nitesh-kumar.Agrawal@amd.com \
--cc=Pankaj.Sen@amd.com \
--cc=linux-gpio@vger.kernel.org \
--cc=ssundark@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.