From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] pinctrl: ocelot: fix gpio direction Date: Mon, 26 Mar 2018 11:05:25 +0200 Message-ID: References: <20180322123500.2379-1-alexandre.belloni@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180322123500.2379-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni Cc: Gregory Clement , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Thu, Mar 22, 2018 at 1:35 PM, Alexandre Belloni wrote: > Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for > output. ocelot_gpio_set_direction() got it wrong and this went unnoticed > when the driver was reworked. > > Reported-by: Gregory Clement > Signed-off-by: Alexandre Belloni Patch applied. Yours, Linus Walleij