From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314C6C1B0E3 for ; Mon, 14 Dec 2020 08:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D80C322AAB for ; Mon, 14 Dec 2020 08:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407185AbgLNI6A (ORCPT ); Mon, 14 Dec 2020 03:58:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406715AbgLNI6A (ORCPT ); Mon, 14 Dec 2020 03:58:00 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E164C0613D3 for ; Mon, 14 Dec 2020 00:57:19 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id o19so2554328lfo.1 for ; Mon, 14 Dec 2020 00:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PeLskSmDYaVOsZxv9dazYTBEZV4Owe3PpH2dLGUOSKI=; b=KWsCICqm5auiKhsRbZlPOGFcRacp9hlIrGS5KIynS4aaQ4DgAkTGJVhw7HGrLsO6oO My98Qtyce3BQgZY3NTyROxxZRL7zkL51Syux7ofWkEVIkqBuvZ5QVzgvH05FzJUOhSGl hEwQzml6uDxkMxmqyMVdMcaeMvcA1Dt/MuA0v/oieVzcm2gMV0X90yEJwP2BaJSf9X9l eP6t4uxbML2qVE2pzH3dJSOf27gtqFcouJFvczJhjcik43RksnkM/gQ9ldsGxZgTiOBK CzMjhWm+GFc+ZghGTj6H7LBXFD/Y8ey2eVNXpjVQoO9DRg8yj7Gk7A8GebAoGaut1DvB 4HQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PeLskSmDYaVOsZxv9dazYTBEZV4Owe3PpH2dLGUOSKI=; b=DK46VrvdSZ2BPK0UHWjfuqYGJO0HCE51sVpVxf/qTphLHDh0Z4DOqNu51Oe2YNUqmc PZXR1F4wMIqP6bCFc7XBL6BFTLlIWU/s6PYwfMmZ3noAiQWEkuqqtK6EzbPvVg5Gstkn lzMhhgl11DFjPn3LL4cgh+kZRvOLAQkaHqZUBkmw7SFdn7rHrTdrayP7FFXaNEeiYLLe +k4EuKzEebeUh3mmKO2eCIUTrDrdDSyBhYa+9Q08/QmxMvdX5tOw15g21P4JF6bTSdvI sZxHKSuKrfbzZ724Q60ZVeg3M+xtK46E3sANZ93lCVLM6fhCkhKX5uZcC25No12Rrs8c U0Vw== X-Gm-Message-State: AOAM532TFSTOoFZtYCvHcTiBaI+CJlffCN/uXwOi2rAyA/2NBbsIVRXy 8aRBY+wWkme5IFqlUAnT+b2jfYJYcMd/e7q3UTSTYg== X-Google-Smtp-Source: ABdhPJwsHyoU4o37zHEtZOYqmgDKOY1YjMUhOeqiSTQT16Q9804/21EtJ1z7yMpPlKLKYk+6gufMYxW6U48B7xOH69c= X-Received: by 2002:a19:495d:: with SMTP id l29mr4671485lfj.465.1607936237341; Mon, 14 Dec 2020 00:57:17 -0800 (PST) MIME-Version: 1.0 References: <20201211183815.51269-1-stephan@gerhold.net> <20201211183815.51269-2-stephan@gerhold.net> In-Reply-To: <20201211183815.51269-2-stephan@gerhold.net> From: Linus Walleij Date: Mon, 14 Dec 2020 09:57:06 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] iio: gyro: bmg160: Add rudimentary regulator support To: Stephan Gerhold Cc: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , linux-iio , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "H . Nikolaus Schaller" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Dec 11, 2020 at 7:39 PM Stephan Gerhold wrote: > BMG160 needs VDD and VDDIO regulators that might need to be explicitly > enabled. Add some rudimentary support to obtain and enable these > regulators during probe() and disable them using a devm action. > > Signed-off-by: Stephan Gerhold > --- > Changes in v2: > - Do regulator_bulk_enable() immediately after devm_regulator_bulk_get() > - Simplify error handling using devm_add_action_or_reset() Reviewed-by: Linus Walleij Yours, Linus Walleij