From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v3 12/18] dt-bindings: Add PLX Technology OXNAS pinctrl and gpio bindings Date: Fri, 8 Apr 2016 13:14:46 +0200 Message-ID: References: <1458838215-23314-1-git-send-email-narmstrong@baylibre.com> <1458838215-23314-13-git-send-email-narmstrong@baylibre.com> <20160325144834.GA27177@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f41.google.com ([209.85.218.41]:32972 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758119AbcDHLOr (ORCPT ); Fri, 8 Apr 2016 07:14:47 -0400 Received: by mail-oi0-f41.google.com with SMTP id w85so132777085oiw.0 for ; Fri, 08 Apr 2016 04:14:46 -0700 (PDT) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Rob Herring Cc: Neil Armstrong , "linux-kernel@vger.kernel.org" , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" On Thu, Mar 31, 2016 at 3:36 PM, Rob Herring wrote: > Looking at one example, it appears to be redundant already. > nomadik-gpio-chips property already gives you the index. The index of > the phandles is the bank numbering. PIC32 could do the same. nomadik-gpio-chips is a property on the pin controller, so it goes the wrong direction I think, the pin controller knows these indexes but the GPIO chip does not know what index it has. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758212AbcDHLOt (ORCPT ); Fri, 8 Apr 2016 07:14:49 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34908 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758118AbcDHLOr (ORCPT ); Fri, 8 Apr 2016 07:14:47 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458838215-23314-1-git-send-email-narmstrong@baylibre.com> <1458838215-23314-13-git-send-email-narmstrong@baylibre.com> <20160325144834.GA27177@rob-hp-laptop> Date: Fri, 8 Apr 2016 13:14:46 +0200 Message-ID: Subject: Re: [PATCH v3 12/18] dt-bindings: Add PLX Technology OXNAS pinctrl and gpio bindings From: Linus Walleij To: Rob Herring Cc: Neil Armstrong , "linux-kernel@vger.kernel.org" , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 3:36 PM, Rob Herring wrote: > Looking at one example, it appears to be redundant already. > nomadik-gpio-chips property already gives you the index. The index of > the phandles is the bank numbering. PIC32 could do the same. nomadik-gpio-chips is a property on the pin controller, so it goes the wrong direction I think, the pin controller knows these indexes but the GPIO chip does not know what index it has. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Fri, 8 Apr 2016 13:14:46 +0200 Subject: [PATCH v3 12/18] dt-bindings: Add PLX Technology OXNAS pinctrl and gpio bindings In-Reply-To: References: <1458838215-23314-1-git-send-email-narmstrong@baylibre.com> <1458838215-23314-13-git-send-email-narmstrong@baylibre.com> <20160325144834.GA27177@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 31, 2016 at 3:36 PM, Rob Herring wrote: > Looking at one example, it appears to be redundant already. > nomadik-gpio-chips property already gives you the index. The index of > the phandles is the bank numbering. PIC32 could do the same. nomadik-gpio-chips is a property on the pin controller, so it goes the wrong direction I think, the pin controller knows these indexes but the GPIO chip does not know what index it has. Yours, Linus Walleij