From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions Date: Thu, 24 Jul 2014 17:40:10 +0200 Message-ID: References: <1405610748-7583-5-git-send-email-iivanov@mm-sol.com> <1405626085-14069-1-git-send-email-iivanov@mm-sol.com> <20140722214643.GH19700@sonymobile.com> <53D04996.2030902@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oa0-f49.google.com ([209.85.219.49]:47796 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759544AbaGXPkL (ORCPT ); Thu, 24 Jul 2014 11:40:11 -0400 Received: by mail-oa0-f49.google.com with SMTP id eb12so3873838oac.22 for ; Thu, 24 Jul 2014 08:40:10 -0700 (PDT) In-Reply-To: <53D04996.2030902@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Bjorn Andersson , "Ivan T. Ivanov" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mark Brown , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" On Thu, Jul 24, 2014 at 1:47 AM, Stephen Boyd wrote: >> Please add these constants to the table of valid power-source values and use >> something like I did to translate them to register values - it makes the DT >> much more readable. > > The DT could be similarly readable if we had a bunch of #defines for the > different VIN settings that resolved to the final register value for > that pmic. Something like PM8921_GPIO1_14_VPH, PM8921_GPIO19_36_VPH, > etc. There would be a lot of them, but then the driver could be really > simple and just jam whatever value is in the DT into the register > without having to bounce through a mapping table in software to figure > out the register value. If we did this for the functions also then I > believe we achieve readability without requiring a bunch of drivers for > each and every single pmic? Not sure but it sounds like you want to make the device tree a jam table, (know about individual register offsets, sequences etc). That has been throrougly NACKed in the past, because DT is not Open Firmware. The exception is pinctrl-single which is restricted to single register per pin use cases and is still a point of contention... Yours, Linus Walleij