From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdFINoM (ORCPT ); Fri, 9 Jun 2017 09:44:12 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:38772 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbdFINoK (ORCPT ); Fri, 9 Jun 2017 09:44:10 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170605074846.30925-1-andrew@aj.id.au> From: Linus Walleij Date: Fri, 9 Jun 2017 15:44:08 +0200 Message-ID: Subject: Re: [PATCH] arm: aspeed: Add clock-names property to timer node To: Arnd Bergmann Cc: Joel Stanley , Andrew Jeffery , Linux ARM , Linux Kernel Mailing List , Daniel Lezcano Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 6, 2017 at 11:41 AM, Arnd Bergmann wrote: > On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley wrote: >> On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery wrote: >>> The merging of a number of clocksource drivers into fttmr010 means we >>> require clock-names to be specified in the Aspeed timer node, else the >>> clocksource fails to probe and boot hangs. >> >> Arnd, >> >> Linus' reworked timer driver will go into 4.13. >> >> Can we get this patch merged into 4.12 as a fix so we don't end up >> with a broken boot at any stage? > > Hmm, can't we make the driver backward-compatible and have it fall > back on the first clock if no clk named "PCLK" is found? Otherwise > you still have an incompatible change in the DT binding and it will > break if someone uses an older dtb with a newer kernel. I was under the impression that the Aspeed support is still in its infancy and everyone working on it using DT will recompile and bundle the DTB as part of their kernel build at this point in time. Are there people shipping products with DTBs on this, really? Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Fri, 9 Jun 2017 15:44:08 +0200 Subject: [PATCH] arm: aspeed: Add clock-names property to timer node In-Reply-To: References: <20170605074846.30925-1-andrew@aj.id.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 6, 2017 at 11:41 AM, Arnd Bergmann wrote: > On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley wrote: >> On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery wrote: >>> The merging of a number of clocksource drivers into fttmr010 means we >>> require clock-names to be specified in the Aspeed timer node, else the >>> clocksource fails to probe and boot hangs. >> >> Arnd, >> >> Linus' reworked timer driver will go into 4.13. >> >> Can we get this patch merged into 4.12 as a fix so we don't end up >> with a broken boot at any stage? > > Hmm, can't we make the driver backward-compatible and have it fall > back on the first clock if no clk named "PCLK" is found? Otherwise > you still have an incompatible change in the DT binding and it will > break if someone uses an older dtb with a newer kernel. I was under the impression that the Aspeed support is still in its infancy and everyone working on it using DT will recompile and bundle the DTB as part of their kernel build at this point in time. Are there people shipping products with DTBs on this, really? Yours, Linus Walleij