From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619DCC433B4 for ; Wed, 5 May 2021 12:51:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E77C610EA for ; Wed, 5 May 2021 12:51:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232410AbhEEMwZ (ORCPT ); Wed, 5 May 2021 08:52:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232389AbhEEMwY (ORCPT ); Wed, 5 May 2021 08:52:24 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B63F3C061761 for ; Wed, 5 May 2021 05:51:27 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id v5so2263848ljg.12 for ; Wed, 05 May 2021 05:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ZKINt+24vkgq+jtEeRzmpva+N3VhWpG25a6HCCDQLg=; b=lsqTsl7XXHy6S6on3u5XAyk4I5ko7hEiejMokpIADhU8TTGOHuBxi28EfYt8Jf7FV/ OnGwPXxfbb2dKPzov0N0V6NLD0nonHQEVWfTyW02sRnjp85USPGekyOLAQKJFWp9fF8E hqkQ/ym/tBF1B6XEQnez1qYEpgs7V6bTtplIPN8B/Ji0Uc1VvPaIIJbB6dxkhLrH3AqL 3UtMnEuE9F6FZUX2A6rX80PBuBmh84a54AcIhfZ3QZ8F4adFMGl4Pe5TjEyqDS5EGFmn on3hpo4FRiMNfsvx4bzbW3vZtc2TN6Ndl2ZTM44H5dPIxkf925BYAYWpGTMK9970dbWN jpDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ZKINt+24vkgq+jtEeRzmpva+N3VhWpG25a6HCCDQLg=; b=VaqxfrOxmNLQV4ixAg+QRb9nagXIyp5OVG0WO4U+15oogCDR9tQKQrdfHXh0KpWECn E3W4SprFrdjXw4o/dfoIServRINylUy6oEKt2ENXksMuOlO2lTp0ok6lIJ8dRiN1h5aR qJIa+/YOec9y9Dan6TNmhAGoktCbb2FO3Esyf+4B19Uuh7vgywVx3p49rv9FL/9pMRdn Uws+83Ppym5/Qhz/gaUUaDSgABjTB4Y89aD5hQbwuFLbP8qwqRX5zDRQ/DI2lBdXGDXp nAu0e+Q/t/STWn0I29FTqI727FfD6Jes5oHfe9u/x5XO69i7KyQLpQky5XfI0tXbnv2Z rdQA== X-Gm-Message-State: AOAM533Ug0kzDGKiAewdS25SZYxZB9EddSiGB1/1mBcKnxCVs8/Yv2wi bfwxv1mdpiyUywwv5Ud8G4EXEPUKDoJe67lTwjLUvA== X-Google-Smtp-Source: ABdhPJyQJiePbgT7/Tp3x1+jnfQmk7ukJ4HB+fh/IcgCx7MW+Kkyq/ARSBbLSXWU82nXtNazzReNnDeM6ZGufQXDZ/A= X-Received: by 2002:a2e:a54c:: with SMTP id e12mr21964567ljn.326.1620219086062; Wed, 05 May 2021 05:51:26 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: From: Linus Walleij Date: Wed, 5 May 2021 14:51:14 +0200 Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Doug Anderson Cc: Andrzej Hajda , Laurent Pinchart , Bjorn Andersson , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , MSM , Rob Clark , Stanislav Lisovskiy , Stephen Boyd , Steev Klimaszewski , Maarten Lankhorst , linux-i2c , "open list:DRM PANEL DRIVERS" , Daniel Vetter , David Airlie , Thierry Reding , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, May 3, 2021 at 10:41 PM Doug Anderson wrote: > > At your convenience and when you think there is too little > > stuff in your sn65dsi86 TODO, check out > > pinctrl-bcm63xx.c for an example of select GPIO_REGMAP > > made very simple (this works fine as long as they are bit > > offsets starting from 0). > > I seem to recall you mentioning something like this. When I looked at > it in the past I wasn't convinced it would be easy. See my response > [2]. The rough summary is that I didn't think the helpers were happy > with the pm_runtime() model that I'm using. Did I get that wrong? Yeah good point. It does seem a bit too complex for that. Sorry for not remembering. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B02C433ED for ; Wed, 5 May 2021 12:51:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 616E6610EA for ; Wed, 5 May 2021 12:51:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 616E6610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CDE9A6E440; Wed, 5 May 2021 12:51:28 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8DEA6E440 for ; Wed, 5 May 2021 12:51:27 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id u20so2257237lja.13 for ; Wed, 05 May 2021 05:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ZKINt+24vkgq+jtEeRzmpva+N3VhWpG25a6HCCDQLg=; b=lsqTsl7XXHy6S6on3u5XAyk4I5ko7hEiejMokpIADhU8TTGOHuBxi28EfYt8Jf7FV/ OnGwPXxfbb2dKPzov0N0V6NLD0nonHQEVWfTyW02sRnjp85USPGekyOLAQKJFWp9fF8E hqkQ/ym/tBF1B6XEQnez1qYEpgs7V6bTtplIPN8B/Ji0Uc1VvPaIIJbB6dxkhLrH3AqL 3UtMnEuE9F6FZUX2A6rX80PBuBmh84a54AcIhfZ3QZ8F4adFMGl4Pe5TjEyqDS5EGFmn on3hpo4FRiMNfsvx4bzbW3vZtc2TN6Ndl2ZTM44H5dPIxkf925BYAYWpGTMK9970dbWN jpDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ZKINt+24vkgq+jtEeRzmpva+N3VhWpG25a6HCCDQLg=; b=FZ+LoOke6TzBJaONGipjZTttIJcCZU6uIbGmxWjRRn2QtTlgEGYWrHfHiq2cZlP6d3 L0hZQbICU1MoES7Ol1M4Gtl2/2LfJZmjTPkxCUt2TvGe9Al/TdutmvIzsVZ7oHTvk5Lz VykYZkn0Zvq6Wa3O29dSqK0OU2cJbqEwEu6hHdW1DMUaHE0isSPSJUmJm9YpBPCOnSIq Gc6pDmM4NQa7EOxLFSbHi+aJPejp/iwtKz/kpGXTY0eyUCzv/kqigccFXXjd4j0xX9P0 xRy6ULm8pm4HVkihZfYZq/W4CD7Km4cdVVCX0hNvIVWa3O0PyXPoH6ECQcMwiIhV6+0J ORHg== X-Gm-Message-State: AOAM531SY9Kn0GzZxdx2XtAEKWoQr5uvQzhL4XYvya0oz1Jnxath8nHh /AksW1UaU/90mMGClg3XGOSprxsNZzBQ3QurwArm6w== X-Google-Smtp-Source: ABdhPJyQJiePbgT7/Tp3x1+jnfQmk7ukJ4HB+fh/IcgCx7MW+Kkyq/ARSBbLSXWU82nXtNazzReNnDeM6ZGufQXDZ/A= X-Received: by 2002:a2e:a54c:: with SMTP id e12mr21964567ljn.326.1620219086062; Wed, 05 May 2021 05:51:26 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: From: Linus Walleij Date: Wed, 5 May 2021 14:51:14 +0200 Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Doug Anderson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Stanislav Lisovskiy , Jernej Skrabec , Jonas Karlman , David Airlie , MSM , "open list:DRM PANEL DRIVERS" , Neil Armstrong , linux-kernel , Steev Klimaszewski , Bjorn Andersson , Wolfram Sang , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Stephen Boyd , Sam Ravnborg , linux-i2c Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 3, 2021 at 10:41 PM Doug Anderson wrote: > > At your convenience and when you think there is too little > > stuff in your sn65dsi86 TODO, check out > > pinctrl-bcm63xx.c for an example of select GPIO_REGMAP > > made very simple (this works fine as long as they are bit > > offsets starting from 0). > > I seem to recall you mentioning something like this. When I looked at > it in the past I wasn't convinced it would be easy. See my response > [2]. The rough summary is that I didn't think the helpers were happy > with the pm_runtime() model that I'm using. Did I get that wrong? Yeah good point. It does seem a bit too complex for that. Sorry for not remembering. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel