From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B8FC433ED for ; Fri, 21 May 2021 10:04:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6DDD6135C for ; Fri, 21 May 2021 10:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232273AbhEUKFw (ORCPT ); Fri, 21 May 2021 06:05:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbhEUKFs (ORCPT ); Fri, 21 May 2021 06:05:48 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7BABC0613ED for ; Fri, 21 May 2021 03:04:25 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id v5so23235574ljg.12 for ; Fri, 21 May 2021 03:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y703Ccx+OTVaWUBCSYH8WB2pCfwJTEkBdShX5aoEd5U=; b=FK4Uxegv3dlbXSHmfZkIILoMjTrkUnCadXvOCTXwz61zBEqo8XuxaRLI477qridtDX KWRqC0Xsyy0RaSBAfI6HDwck/LKYxEk94TEDa96tzAY98IC0ure6vHgQGuXZUV/0XYOe 1byrlbnUhRcixOf3T1VQq+B04CvZyvvz6tG+DBF4g3Sok9dofTiV0jMkvyyiZSqCs/z6 e7lV7gcjVa3MfE9TgNzQj7WnkfmpOF2UlkJ7vIpEVMrPfud5DKKbcPSZFcXpqMZFIllr T6sTGSQtx5RTFo2r9r6qO8uQ33iyoHjb2iat48Ts9zBk5bMolvT4PaaI7DjVSkCgjqVf +7ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y703Ccx+OTVaWUBCSYH8WB2pCfwJTEkBdShX5aoEd5U=; b=onwpuiHE1kYW/7NibMtLOMS8WLJx83Z0BFpKS7Fc0G+V0VIxBbmsCHIsvdCOOOg1WX VQ0jTpuIpSFdY94xj2hLAiRADVTH5qHcIbqYxKHz0xr5avRhxMQHiVtiBifD7Ta8jSUU /uo+Z5jc5My+wzKocFAShsdfioQRDiZC/elLQM66qgezAlAtNRrByC6CVuBP2DcBE0+t aKhINuRm3XBmhQn6+HW3IHCsiMOyVSF0qZy4vYjsWFGhPwBkQP6KHd/TYGi9ekFjeqH9 N5xtM6n4ZGzIBuK6HGCS0M5uY/nLjZ5tJp98u7bjulqmFWoMruMy6/n2BR7RGT+plJ+F qCSA== X-Gm-Message-State: AOAM5322th0Ta+YGmTLeTcqJN63vN2A5oPBHnIcoEnsFReGfFQBgpi6/ MnRaFWz35WrY46d6RaTUgJi/IxlwRAPlEnmj74xTTB93fj2MAQ== X-Google-Smtp-Source: ABdhPJxYYlDb+WDA9clSQo27j62lQA1sN33Wn6ony6XmM/ZkiSizwZPVoBxp6VVDs3T+PGjG3ATJK87UTncv58xBVOI= X-Received: by 2002:a05:651c:4c6:: with SMTP id e6mr6517419lji.326.1621591464170; Fri, 21 May 2021 03:04:24 -0700 (PDT) MIME-Version: 1.0 References: <52df0592c81ac000d3f486a9ba5a4d84b0f42c47.1621583562.git.geert+renesas@glider.be> In-Reply-To: <52df0592c81ac000d3f486a9ba5a4d84b0f42c47.1621583562.git.geert+renesas@glider.be> From: Linus Walleij Date: Fri, 21 May 2021 12:04:12 +0200 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema To: Geert Uytterhoeven Cc: Rob Herring , Laurent Pinchart , Bartosz Golaszewski , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Jan Tuerk , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Linux-OMAP , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, May 21, 2021 at 9:54 AM Geert Uytterhoeven wrote: > Convert the PCF857x-compatible I/O expanders Device Tree binding > documentation to json-schema. > > Document missing compatible values, properties, and gpio hogs. > > Signed-off-by: Geert Uytterhoeven (...) > Perhaps the "ti,pcf8575" construct should be removed, and the few users > fixed instead? You would rather list it as deprecated I think? It is ABI... > + gpio-controller: true So this is implicitly using the generic schema in /dtschema/schemas/gpio/gpio.yaml > + lines-initial-states: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Bitmask that specifies the initial state of each line. > + When a bit is set to zero, the corresponding line will be initialized to > + the input (pulled-up) state. > + When the bit is set to one, the line will be initialized to the > + low-level output state. > + If the property is not specified all lines will be initialized to the > + input state. Is this something we standardized or something that should actually be a custom "nxp," property we just missed it? (Looks like the latter... oh well, now it is there.) > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > + type: object But this is already in /dtschema/schemas/gpio/gpio-hog.yaml for nodename, isn't that where it properly belongs? I'm however confused here Rob will know what to do. > required: > - gpio-hog > - gpios This is already in /dtschema/schemas/gpio/gpio-hog.yaml as well? Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97F2C433ED for ; Fri, 21 May 2021 10:06:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DFF16109F for ; Fri, 21 May 2021 10:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DFF16109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CUFUN4WHfnfPQ+uLHbu6scaxvGskFujRHQSAkzBMVvQ=; b=H9VqrYhGC6H3pyVZ8pRd76GbuO V6Pvpygg6ZMXkY34QQUjUS9hNrJaTU7Y3cu+zaZvITrjrawPXekYgJTPK5qGNMge/PaoZYj/C7Qn9 8r86D2AksjsxoWL1dKG/4e7X5Fvd+GnB3XY89SE68Ik9XWXoE35kP5rjA8/dagHR6sUlFzQfG9/Oo s7cKsSqQg/K35fLioh7BBJ+J5bswnA9IrgU1YIRKvtYjFUKjnc2dWNhWSR/lDjD35PB+yz0tYzDVS 0jDnMy40FL+m5M4H8tUfmu9t+Ygv/ESiMW/mOy4rNg0jhYVoXL5dbm7UZNNZ3TqVP/WzGRmmyNcL8 fIYPHYVw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk219-004qwv-Ns; Fri, 21 May 2021 10:04:31 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk217-004qwk-8E for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 10:04:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y703Ccx+OTVaWUBCSYH8WB2pCfwJTEkBdShX5aoEd5U=; b=UOordHVAeHrUmawlvaVgTjcAR9 z3DD2bJyvUhBzmG3Imhvr8MIFPHT2VhEnzKfuiFwU54Yyv7DLA9KcqXRZ7jxCp4JvE3myoeVJE+gB 8O9l8U3TeVhMZWdWKthrrV6yc72sWAUxIHorgimRTkvcrIXC5n184JdSmGwHe04nO6K9TVlGBtfyH N5CjQZUk4j/+Sg8eqfXMloV0bgMP0l/kGjaTsXkRnT0tT3mgbaHqBdmg5NcPBUJZerrcRzRR/XI8k L7DHKs3zcEExsWsIFNYNBG4BF20vNrRv23M+HeT7BxrB1PpdEIHhPNQzc+aQi1uxbzAfljPXDvBWS jHOEPXGQ==; Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk214-00H1Fu-CH for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 10:04:27 +0000 Received: by mail-lj1-x229.google.com with SMTP id e11so23230312ljn.13 for ; Fri, 21 May 2021 03:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y703Ccx+OTVaWUBCSYH8WB2pCfwJTEkBdShX5aoEd5U=; b=FK4Uxegv3dlbXSHmfZkIILoMjTrkUnCadXvOCTXwz61zBEqo8XuxaRLI477qridtDX KWRqC0Xsyy0RaSBAfI6HDwck/LKYxEk94TEDa96tzAY98IC0ure6vHgQGuXZUV/0XYOe 1byrlbnUhRcixOf3T1VQq+B04CvZyvvz6tG+DBF4g3Sok9dofTiV0jMkvyyiZSqCs/z6 e7lV7gcjVa3MfE9TgNzQj7WnkfmpOF2UlkJ7vIpEVMrPfud5DKKbcPSZFcXpqMZFIllr T6sTGSQtx5RTFo2r9r6qO8uQ33iyoHjb2iat48Ts9zBk5bMolvT4PaaI7DjVSkCgjqVf +7ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y703Ccx+OTVaWUBCSYH8WB2pCfwJTEkBdShX5aoEd5U=; b=ST1Y57vVQmM2WTlYZnK6rH8gJeGyRPvzayGwrmrN9pIT/s0cgb6X3XUERpXqxOCRmY SruFI8/NB6eyINkWEgeDaj7id3IU8JtNYxFf5hnCnV7L32NVXeHTBBlIZwIhL8t4yUsx rVRAFSCiixxHZyZOjSc5dJtVqXAfswcEDrqljMUuI7YJ1HLooaG/9C64fx9MDntlQmKp 8VKD6IbNhCK0eFO7OjSiTekg3LgPL2SpsPOOHFFKxUXIU+aTgnILh7bS4tnDVGwQOckI TrzfwL2ExuGKyVxDleawe9WnMSTUENtF97Oks8gmjbAXNrd+DSvsq1Xhm10oajur/HCC nHnw== X-Gm-Message-State: AOAM533rVP8o2detziUIc8lM6msikywNheX10lmZahQ8l18HUVtiMlRZ 06N2f0Km7GiHWE9F4MNrcDM1N1Q1kiblmYiC9eJpBw== X-Google-Smtp-Source: ABdhPJxYYlDb+WDA9clSQo27j62lQA1sN33Wn6ony6XmM/ZkiSizwZPVoBxp6VVDs3T+PGjG3ATJK87UTncv58xBVOI= X-Received: by 2002:a05:651c:4c6:: with SMTP id e6mr6517419lji.326.1621591464170; Fri, 21 May 2021 03:04:24 -0700 (PDT) MIME-Version: 1.0 References: <52df0592c81ac000d3f486a9ba5a4d84b0f42c47.1621583562.git.geert+renesas@glider.be> In-Reply-To: <52df0592c81ac000d3f486a9ba5a4d84b0f42c47.1621583562.git.geert+renesas@glider.be> From: Linus Walleij Date: Fri, 21 May 2021 12:04:12 +0200 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema To: Geert Uytterhoeven Cc: Rob Herring , Laurent Pinchart , Bartosz Golaszewski , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Jan Tuerk , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Linux-OMAP , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_030426_462299_B7DD4993 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 9:54 AM Geert Uytterhoeven wrote: > Convert the PCF857x-compatible I/O expanders Device Tree binding > documentation to json-schema. > > Document missing compatible values, properties, and gpio hogs. > > Signed-off-by: Geert Uytterhoeven (...) > Perhaps the "ti,pcf8575" construct should be removed, and the few users > fixed instead? You would rather list it as deprecated I think? It is ABI... > + gpio-controller: true So this is implicitly using the generic schema in /dtschema/schemas/gpio/gpio.yaml > + lines-initial-states: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Bitmask that specifies the initial state of each line. > + When a bit is set to zero, the corresponding line will be initialized to > + the input (pulled-up) state. > + When the bit is set to one, the line will be initialized to the > + low-level output state. > + If the property is not specified all lines will be initialized to the > + input state. Is this something we standardized or something that should actually be a custom "nxp," property we just missed it? (Looks like the latter... oh well, now it is there.) > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > + type: object But this is already in /dtschema/schemas/gpio/gpio-hog.yaml for nodename, isn't that where it properly belongs? I'm however confused here Rob will know what to do. > required: > - gpio-hog > - gpios This is already in /dtschema/schemas/gpio/gpio-hog.yaml as well? Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel