From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62EEEC433EF for ; Mon, 23 May 2022 08:39:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231867AbiEWIjP (ORCPT ); Mon, 23 May 2022 04:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231969AbiEWIjL (ORCPT ); Mon, 23 May 2022 04:39:11 -0400 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DC1E3CFE6 for ; Mon, 23 May 2022 01:39:08 -0700 (PDT) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-2ff155c239bso140008157b3.2 for ; Mon, 23 May 2022 01:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9ms1xiGnp9VFH8Q9WvnNJjHzsFoHcObvaufuDxPzB8s=; b=Uet4r7oIXi/ElVe63yV1mWhDRZ+fGIgc5OZMp+pGq/pwPrZ33OPF1HDuE/BKkaKPXK jQDEkdFsjwaDOM0WHhuA6doA6kC9TMW7VHOC3aArWFo8rD/XFve21eGHC2NVQEFM2Fsa 2BBCBMxfigeAO9ep6xDQ7mXqxxb34jwF1pEXTfDTPfYT9Kc/Ugs23KFhBZSXh10RM9Zx AIEUjNNEc3uDMKeQMajmp/JwzZqX9O+cG6X1BA+62WhYx8hK945ueObKZ6qjPB/0xKbQ 2KETO5q4v/umXdZUIidDW+RgYqN91R5iY8+h+dRBlHq3TGczK5IM4T4WU7a8EIkNSg9q r69Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9ms1xiGnp9VFH8Q9WvnNJjHzsFoHcObvaufuDxPzB8s=; b=J0ef9DAyUTPmBE1vz4wdaX+5S2R6dX9ohhBGPMLZn5AZsPZFfAnMnZKFaWLGlQGoaY Pt0RpFkIOOrAyI9c4jTOV5PbBm0PggLLIVnbAdRaSJNbQNAPs8xj3E48sAS9uX5mo4ML enPoR+pdlU5O2PDtFz6wrfCWpj5FfNGUly0JefMr5V/JTErlu+GUo2AQv5vvm5UivS+K eDwBjkDmtuaUxG6NbsCrkLh4Ka0swnPXa3uCspf2KfVqosbsGQ/kQhmYaLK9xyro0Tfa dkIj67+OCdJGgHbWxXoRpit1efsnfHuciGdtrpyNLmi2kH789kt8PVeiiyTd1nx2PckE vdWw== X-Gm-Message-State: AOAM531JnROLSRHg0DrMjyYVZKQDAHEk3B/rSdl6FYHu1aTkCisD+bz6 Od9c9RUetY1d/o1Xeq0Q0R165JYjNRX6B1mkcnq8kw== X-Google-Smtp-Source: ABdhPJzVCJisNVWwF/tRYhS+3OQBbnOrRKNdHmqe9UxkbvUyiNZVzi+GLJWTPkxmpI2apsjpExrpugAd+DKqFmDQJAE= X-Received: by 2002:a81:a107:0:b0:2ff:e11d:3ad8 with SMTP id y7-20020a81a107000000b002ffe11d3ad8mr5164601ywg.448.1653295147509; Mon, 23 May 2022 01:39:07 -0700 (PDT) MIME-Version: 1.0 References: <20220521200734.421223-1-a.fatoum@pengutronix.de> <80306a31-462c-4ce3-5c54-c0f74ad828f8@pengutronix.de> In-Reply-To: <80306a31-462c-4ce3-5c54-c0f74ad828f8@pengutronix.de> From: Linus Walleij Date: Mon, 23 May 2022 10:38:56 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding To: Ahmad Fatoum Cc: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2022 at 12:16 AM Ahmad Fatoum wrote: > On 22.05.22 23:03, Linus Walleij wrote: > > On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum wrote: > > > >> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and > >> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package. > > > > So the BT and the package have two different names. > > The package also goes by the name BCM4349B1 apparently. > Cypress support had later confirmed BCM4349B1 and BCM89359 to > be the same chipset. I should probably rephrase the commit message. > > > >> + - brcm,bcm4349-bt > > > > Then why do you have to tag on "-bt" on this compatible? > > > > That is typically used when the wifi and bt has the *same* name, so > > the only way to distinguish between them is a suffix. > I think that's the case here too. OK then! Reviewed-by: Linus Walleij Yours, Linus Walleij