From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8794DC04AA5 for ; Thu, 25 Aug 2022 12:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237197AbiHYMIl (ORCPT ); Thu, 25 Aug 2022 08:08:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234589AbiHYMIk (ORCPT ); Thu, 25 Aug 2022 08:08:40 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F5EBAA4DC for ; Thu, 25 Aug 2022 05:08:39 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id b16so25831494edd.4 for ; Thu, 25 Aug 2022 05:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=TolwNg/wx0BhjmILpbscAwoASK3Z/Nrde9QjMCFbj7Y=; b=FU0JAd34mB6ckFxckBeSEVG3DUKXpDBtb+oVBz9x45986hMZ4ClFEzwuqvwWY1ueYz uZtrPLDRA+2wnAl0oU44tspm8EEBV+8PV4W87nFDlnxPLFgGN9r8cTCue4trJAbU797y pttlot+ScBBj/ktSNbox2r+P8KSUVHceQOiEUqYNVbgd2Z01zWcnjLmZMUd1ONHm4AOV g9RD+rJBf8j5oUVbYgxotijsVTyN5zJORRMe2fXTJQxvIKR4FXH8OBzQKSVWoFVwj43r uxFJMufxYlHMsn4NI3/qjMmBBm6AkO4zgAQVoadCd0s9MQZ46xrAK1PKz7zjeAv/uAR6 OaVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=TolwNg/wx0BhjmILpbscAwoASK3Z/Nrde9QjMCFbj7Y=; b=5sITSB9Mp1L1llno5T9Rzjsw48rM801KUOz9nn73SClDwlOdUDi7PgXVhFPnAwM2uB x0zpe8vSomSXHwoJtrjz0chQKtpbEwr6R/9DoAQLyMpErYsXAfsnV0ZR6kDTWbrkeUKE xZtUPQcLci+CU9q/awbM6Y7MB6ip/yACMtotfR/+oJVZYhWv1XU9hGFtT9F4ErT17pND CQwrgtOP2dd2N7MMf6ZfoETjyT4jwIb7i50CBD5g42sAcRBBP0yuyupSUMQEFoCkfy/I JerFN1eVKD0K/LAEdP8R7FgcYOhMy1nT4NYw/S7VjAjTE3qdDoSfXD08jf/hDPBBT9Oz hv5w== X-Gm-Message-State: ACgBeo2cs9eP9jso5c+AnSn6FCiO1N2DPBvrVy8mjfkTt+vL8m0igBtP DbiLdUHX9/qj4Y3C3zrg/LPLdhkaonadu8/2N1vpzg== X-Google-Smtp-Source: AA6agR4nN1PE1GuW5na5F7GWkxxXtSEWynOGHSi1uR/KtVxpLS+JeugMHolJGMCKawv6M+VDxbHWHMoTccam5p3hfNs= X-Received: by 2002:aa7:c84f:0:b0:446:2bfb:5a63 with SMTP id g15-20020aa7c84f000000b004462bfb5a63mr3013820edt.172.1661429317773; Thu, 25 Aug 2022 05:08:37 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> In-Reply-To: <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> From: Linus Walleij Date: Thu, 25 Aug 2022 14:08:26 +0200 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Krzysztof Kozlowski Cc: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Jul 28, 2022 at 10:32 AM Krzysztof Kozlowski wrote: > On 27/07/2022 03:33, Saravana Kannan wrote: > > As soon as a gpio is registered, it should be usable by a consumer. So, > > do all the initialization before registering the gpios. Without this > > change, a consumer can request a GPIO IRQ and have the gpio to IRQ > > mapping fail. > > > > Signed-off-by: Saravana Kannan > > Looks good. > > Linus, > It's too late for me to pick it up, so make you could grab it directly? > > Reviewed-by: Krzysztof Kozlowski > > Otherwise it will wait for merge window to finish. I sadly missed this during the merge window, as the commit message didn't make it look like a fix or something urgent. (I don't know if it is?) Just send me the patch as fix or for -next, I let you decide. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81C01C04AA5 for ; Thu, 25 Aug 2022 12:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R5a6bz2D1qUc9ZO0UjUgGZ72JkdMO4sCfYnS3A3wLms=; b=BSws1JX31fXJpN JSY197DFxJuV3WYnKmz6aGnvE7RoEOfCAz0x0mqrs/ImguyGxDbuAFkIQy8/JRp4oSLYI8Q8A7tw6 72DXj/M+Bhh2xuo09tX6j5VhAZGY2u8U2TsGdQxqo7tPI7kEBaTOqWz8qKd1pQazJO2eIUai54eJR rj8RhaR2rH0A5oeAsMt4hmVE8tkt9fRien/h0XsMpTaMb60yTebuN6ETvqrnUI3/xFh9ol7ka5MYP aQCEpCsuM7RzGj8U38XS6mSl9H2oJzPA0TRNhexmfudTNsyRmZrWasSHsGbr6n9rY/4pGHN27dnZe fFMqvR36tTDlTPUp2bDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBf9-00DPwP-1Y; Thu, 25 Aug 2022 12:08:43 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBf6-00DPpl-6n for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 12:08:41 +0000 Received: by mail-ed1-x530.google.com with SMTP id b44so5551449edf.9 for ; Thu, 25 Aug 2022 05:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=TolwNg/wx0BhjmILpbscAwoASK3Z/Nrde9QjMCFbj7Y=; b=FU0JAd34mB6ckFxckBeSEVG3DUKXpDBtb+oVBz9x45986hMZ4ClFEzwuqvwWY1ueYz uZtrPLDRA+2wnAl0oU44tspm8EEBV+8PV4W87nFDlnxPLFgGN9r8cTCue4trJAbU797y pttlot+ScBBj/ktSNbox2r+P8KSUVHceQOiEUqYNVbgd2Z01zWcnjLmZMUd1ONHm4AOV g9RD+rJBf8j5oUVbYgxotijsVTyN5zJORRMe2fXTJQxvIKR4FXH8OBzQKSVWoFVwj43r uxFJMufxYlHMsn4NI3/qjMmBBm6AkO4zgAQVoadCd0s9MQZ46xrAK1PKz7zjeAv/uAR6 OaVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=TolwNg/wx0BhjmILpbscAwoASK3Z/Nrde9QjMCFbj7Y=; b=vpmfG9VdhIXBl706jDnySUm78FZQIHvo7uiwkjCR2cBcUcipechFtDSitE0M97WSOC xV1+GiX0+bZgeQUTBYknawrfsrt1cDvuKz0d8bDBJEuuLKYGZKNXsGm6RQ3IyhGMTIz+ ibT12pk5nXoV5AcoN2xiFNQvDlqWxdoX3ohkSre1XYCgzW6T5FYgBEkPcEWlxhNm2cka asHE3cEy3PeJUCv4P8acywZa09mjyRCeojQz/qyz/up3I98owQ4xFlXIo8ZNyyBSiFtw GoX/nEz9GtqyfNPvlrPqMUC9Z2IYFrX8GKGNTS5XxJ6H40dptuXV1St4UQY6ntDKHMHa DrFQ== X-Gm-Message-State: ACgBeo0/rML9cRkL8d0DsiWN+r3TE4LsWi5WvjGQjUIVee3fJ+jMhskT JmEkNN5wUddQCiYCFC4TWEQ47PUr7NPMZxz5aj3nAw== X-Google-Smtp-Source: AA6agR4nN1PE1GuW5na5F7GWkxxXtSEWynOGHSi1uR/KtVxpLS+JeugMHolJGMCKawv6M+VDxbHWHMoTccam5p3hfNs= X-Received: by 2002:aa7:c84f:0:b0:446:2bfb:5a63 with SMTP id g15-20020aa7c84f000000b004462bfb5a63mr3013820edt.172.1661429317773; Thu, 25 Aug 2022 05:08:37 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> In-Reply-To: <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> From: Linus Walleij Date: Thu, 25 Aug 2022 14:08:26 +0200 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Krzysztof Kozlowski Cc: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_050840_275508_653E9505 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 28, 2022 at 10:32 AM Krzysztof Kozlowski wrote: > On 27/07/2022 03:33, Saravana Kannan wrote: > > As soon as a gpio is registered, it should be usable by a consumer. So, > > do all the initialization before registering the gpios. Without this > > change, a consumer can request a GPIO IRQ and have the gpio to IRQ > > mapping fail. > > > > Signed-off-by: Saravana Kannan > > Looks good. > > Linus, > It's too late for me to pick it up, so make you could grab it directly? > > Reviewed-by: Krzysztof Kozlowski > > Otherwise it will wait for merge window to finish. I sadly missed this during the merge window, as the commit message didn't make it look like a fix or something urgent. (I don't know if it is?) Just send me the patch as fix or for -next, I let you decide. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel