From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82ECC433EF for ; Tue, 7 Sep 2021 15:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BAD36108D for ; Tue, 7 Sep 2021 15:52:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345510AbhIGPxX (ORCPT ); Tue, 7 Sep 2021 11:53:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232935AbhIGPxV (ORCPT ); Tue, 7 Sep 2021 11:53:21 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBD9FC061575 for ; Tue, 7 Sep 2021 08:52:14 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id d16so17316952ljq.4 for ; Tue, 07 Sep 2021 08:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GBfZ6rYZZeIPSWSyvRqA6X9QP4civIatZJOw7UmVoyw=; b=qsTjF2EtL63/MmojR21+eZMT7uft4oZ+rurnnMXzU72+vF684F1frdvochMuKCWX+p HhR0qES/dCAcuTuoRpzfVjuXahAmReikXvBcUZ15f97Ot1NoSanPssqUm5SrrI+X1Zx8 CEyt3FrCVE3twc6JiGeYk03qTKQJuoUaBMB1MTD5nfysU4tAXzyOetQVDVLnbkBQHQGY ZaxqCF0rjm7n0b7ypme2QXozutDNEd/4pdxXCj08LtGgaCkoeIBk92kmSxkWj3gv3xjS k50jSWAeRMAx0CHZRg3IRyMV+z2jdeYY0XHfeCw8pFylgFMg3w2LkdMtIi/2JyTo15TQ YbpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GBfZ6rYZZeIPSWSyvRqA6X9QP4civIatZJOw7UmVoyw=; b=Fbxnf38HiP8ZvAC1DgHqP7cc01o4fr8Ony8KNYNRT7U1sFH+XzDvuGd1SRlv2sX/Wy y19FVqnf1GxoSO9DfvgICd5D/zGbdJNg+9d6OaCMebTGepf4DZe36Ky16+NejSeaGKWK XlcAz8L0CuqGd79AE7P+OUdpFekmXLefj/FFnNeh1dOe5QO+ygcIxO+G4n01C/fhFp/N zsXKVQlJWBE+8A76CEr9aNXX5PqVzT+bfXKoBJzlZAYXoFhYKqoehWyNu4nIVY29EAHa qYD2cQMTzauLp4q7ladsOHQi4PNMkr5nhAA1aO4TYXTl07Et7vODhLw7FmZahcLaljwn cBeg== X-Gm-Message-State: AOAM531GX4neAIJEBqb7G01rF4FvSlhX/BiwZaqBlf88z2iR37lcavJL v3LLKEYsTq7H3F6EFj7zqF5yy5rWHrHPcwI/dIbv9A== X-Google-Smtp-Source: ABdhPJyuo5RW9u05iYv4rWc6VwgbsPh/zWva+E9JjB81QW4EownwRPGnYNXrm3c0tCp71a5Eo/x1zCMYf5iFw+/e2VA= X-Received: by 2002:a2e:5758:: with SMTP id r24mr15146100ljd.432.1631029932430; Tue, 07 Sep 2021 08:52:12 -0700 (PDT) MIME-Version: 1.0 References: <20210830214859.403100-1-linus.walleij@linaro.org> <20210830214859.403100-4-linus.walleij@linaro.org> <20210830224019.d7lzral6zejdfl5t@skbuf> In-Reply-To: <20210830224019.d7lzral6zejdfl5t@skbuf> From: Linus Walleij Date: Tue, 7 Sep 2021 17:52:01 +0200 Message-ID: Subject: Re: [PATCH net-next 3/5 v2] net: dsa: rtl8366rb: Support disabling learning To: Vladimir Oltean Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Jakub Kicinski , netdev , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Mauri Sandberg , DENG Qingfang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 31, 2021 at 12:40 AM Vladimir Oltean wrote: > > /* Enable learning for all ports */ > > - ret = regmap_write(smi->map, RTL8366RB_SSCR0, 0); > > + ret = regmap_write(smi->map, RTL8366RB_PORT_LEARNDIS_CTRL, 0); > > So the expected behavior for standalone ports would be to _disable_ > learning. In rtl8366rb_setup, they are standalone. OK I altered the code such that I disable learning on all ports instead, the new callback can be used to enable it. What about the CPU port here? Sorry if it is a dumb question... I just disabled learning on all ports including the CPU port, but should I just leave learning on on the CPU port? Yours, Linus Walleij