From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61720C433F5 for ; Wed, 13 Oct 2021 23:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B34E610CE for ; Wed, 13 Oct 2021 23:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbhJMXwd (ORCPT ); Wed, 13 Oct 2021 19:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbhJMXwc (ORCPT ); Wed, 13 Oct 2021 19:52:32 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CBAAC061570 for ; Wed, 13 Oct 2021 16:50:28 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id r18so16759966edv.12 for ; Wed, 13 Oct 2021 16:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=510ObgM18jX/lFq7VSHe55hUODoT8WQOT31yT/EoTnc=; b=YnVB+VQsi9O5VsxkVkm0OTCUU3REoqic6XtUf+dalgNwszRL9fySufRPs8eTHS0LYK vOM0t5ouHbe9Pt/R/eohRSnfGXYC7l/VhLcubg9YIDouhj5wjtaWz3lTfD7dJFsGG6wL UZvOA726POHBpitWCqianq/lzHFUWWYOKNXpofmbf1Ipbu4Gco5/GAE1DkS/4XJLV3fu vrzzjz4EQHocBTFTVtoJGaj7Z0GAba2TZJ4wKmrVhpsBjd7bplAHBHlGY9sowWdq8NM2 mKyomjPmL/9aJYyQRhWOMWvQHqNSJlbBL/bqAbrBG6yjwjOmmHBYeM64W/QTJZ+9yZgr Q/Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=510ObgM18jX/lFq7VSHe55hUODoT8WQOT31yT/EoTnc=; b=JJqhJAfn3FencbSe4zLNorx+sw5bw9mdhPFFeu/MkPlJsRZFbXaCiq+wdb6J+N4Vab HISy+ZE9/EkQOuLAEPJQmTWhIm/HixcKX9U29kE5BTV8lRRZrz/1h8ewUh1LeuaWzZX2 ahwD+WdI2WoJZrqJUTFGtOHFJflJqLoPx25pXFF+O+jNeRHRtl4VRGeAwDYVh0YWPIlZ 8BnSpdfGiOEDRjxTFc5uhsbjVE1cfJV8D2DZJNQcaluXem4MJWeegGu2ccHoCI7SU0So J/RbxQWC1CtVkd7x/vq4wVzTYVH54XQQzelN/Euqh/EbxVkN8vWBoCYs4Hnxn/yLggDP 2fvA== X-Gm-Message-State: AOAM533vZirw6R8Yv6kTuzjxtIQb7T2R8On2E60jrrbEYIGORLEsxKYZ ntjfE/IyFQACQOBSCbFLJQLy0u3nAHQzkN1WVZ3gug== X-Google-Smtp-Source: ABdhPJyli8i5itKCqT3i1bM4X1zwNz7i0+Lb1GXlWBFV9LWdkZU7FRdyN1RKStnvPqqCa7eg4Sx07GsZn6MBL2U7444= X-Received: by 2002:a17:907:6010:: with SMTP id fs16mr2646778ejc.266.1634169026737; Wed, 13 Oct 2021 16:50:26 -0700 (PDT) MIME-Version: 1.0 References: <20211013204435.322561-1-kuba@kernel.org> <20211013204435.322561-4-kuba@kernel.org> In-Reply-To: <20211013204435.322561-4-kuba@kernel.org> From: Linus Walleij Date: Thu, 14 Oct 2021 01:50:15 +0200 Message-ID: Subject: Re: [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random() where appropriate To: Jakub Kicinski Cc: "David S. Miller" , netdev , chris.snook@gmail.com, Hans Ulli Kroll , Yisen Zhuang , Salil Mehta , subashab@codeaurora.org, stranche@codeaurora.org, Michael Walle , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 13, 2021 at 10:44 PM Jakub Kicinski wrote: > Number of drivers use eth_random_addr(netdev->dev_addr) > thus writing to netdev->dev_addr directly, and not setting > the address type. Switch them to eth_hw_addr_random(). > > @@ > expression netdev; > @@ > - eth_random_addr(netdev->dev_addr); > + eth_hw_addr_random(netdev); > > Signed-off-by: Jakub Kicinski Oh this is better. Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49AFDC433F5 for ; Wed, 13 Oct 2021 23:52:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0038060E96 for ; Wed, 13 Oct 2021 23:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0038060E96 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tmKWT2GthN6NP9Cnj4N5SDvEfiM3MyqNC8L4y7AJBiE=; b=y8H0yIm2u3fs54 vDrtid45Pwhz/Hm446y7Qs3UhsPRNfq8usidK57PodevrXcauG2qgKrBYVOdTVq7cxbaRqpYnCqRm OYuAeWHqVDm1GEdwPS0MMJ7dyVnJZfFk91xcYdddYdZZT8d9QocDKHOk6uzB3ac14wV842l/vOWif clrI0ypYU6WYzsB5gx6ujoka0i8BW2XyDsB+odxdkhBEkJ+ACN7CIc3EZxtsn4UgFS5bs5kojK2bA yZk58aLdWycBxnjPvpiNsrBrcz+x8FqMlk/ManYX087C3xgc/zWDnj0n/EIuKNtUywsM5F4iv6Akb X+zZlirhSp7FJ/bNKCrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mao12-0014lO-Ou; Wed, 13 Oct 2021 23:50:32 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mao0y-0014kh-H3 for linux-arm-kernel@lists.infradead.org; Wed, 13 Oct 2021 23:50:30 +0000 Received: by mail-ed1-x535.google.com with SMTP id w14so16802589edv.11 for ; Wed, 13 Oct 2021 16:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=510ObgM18jX/lFq7VSHe55hUODoT8WQOT31yT/EoTnc=; b=YnVB+VQsi9O5VsxkVkm0OTCUU3REoqic6XtUf+dalgNwszRL9fySufRPs8eTHS0LYK vOM0t5ouHbe9Pt/R/eohRSnfGXYC7l/VhLcubg9YIDouhj5wjtaWz3lTfD7dJFsGG6wL UZvOA726POHBpitWCqianq/lzHFUWWYOKNXpofmbf1Ipbu4Gco5/GAE1DkS/4XJLV3fu vrzzjz4EQHocBTFTVtoJGaj7Z0GAba2TZJ4wKmrVhpsBjd7bplAHBHlGY9sowWdq8NM2 mKyomjPmL/9aJYyQRhWOMWvQHqNSJlbBL/bqAbrBG6yjwjOmmHBYeM64W/QTJZ+9yZgr Q/Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=510ObgM18jX/lFq7VSHe55hUODoT8WQOT31yT/EoTnc=; b=YepBQwJFhFgn09n7ZZrQ1nAFu4FxqP+FVF87QClxwMgzWWwfV7Ek/+Vxi+u+btfKEO MvPHwnO0IlzBLDraEBrey9ZsKlRqysBap0EgrFx7E/4m8BmA3QQ3GomfIVXWlNXWWx00 KPBjopdoo5r+tgOgez5hmEtpg3NA/s8oitzR6dSQ8xgh1Mc3OoSCi2LuawTRzMTzLijd x0EjVue2CnpBnyxg5gR0OQs8qZEgTDO+DAq7mlAEm/PrVGdYE7vA1lTzvP4J5yc7t/+A 7G3qxlUH3kaDYoznf2dvpCizozSyPdZjeviB6xogJpDm+zeb11HlN1zCke6xlkDvck8h cCxA== X-Gm-Message-State: AOAM533mXyqnqKzn8qWP2HgUnXW3peLyjyP9lraP6H3x841w73Zfrn1G GgyuX5Bd5YaHpEoq6iJqsYmefSlLjCqmVT17oQREkw== X-Google-Smtp-Source: ABdhPJyli8i5itKCqT3i1bM4X1zwNz7i0+Lb1GXlWBFV9LWdkZU7FRdyN1RKStnvPqqCa7eg4Sx07GsZn6MBL2U7444= X-Received: by 2002:a17:907:6010:: with SMTP id fs16mr2646778ejc.266.1634169026737; Wed, 13 Oct 2021 16:50:26 -0700 (PDT) MIME-Version: 1.0 References: <20211013204435.322561-1-kuba@kernel.org> <20211013204435.322561-4-kuba@kernel.org> In-Reply-To: <20211013204435.322561-4-kuba@kernel.org> From: Linus Walleij Date: Thu, 14 Oct 2021 01:50:15 +0200 Message-ID: Subject: Re: [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random() where appropriate To: Jakub Kicinski Cc: "David S. Miller" , netdev , chris.snook@gmail.com, Hans Ulli Kroll , Yisen Zhuang , Salil Mehta , subashab@codeaurora.org, stranche@codeaurora.org, Michael Walle , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_165028_620899_A8862598 X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 10:44 PM Jakub Kicinski wrote: > Number of drivers use eth_random_addr(netdev->dev_addr) > thus writing to netdev->dev_addr directly, and not setting > the address type. Switch them to eth_hw_addr_random(). > > @@ > expression netdev; > @@ > - eth_random_addr(netdev->dev_addr); > + eth_hw_addr_random(netdev); > > Signed-off-by: Jakub Kicinski Oh this is better. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel