From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 4/9] pinctrl: meson: allow gpio to request irq Date: Fri, 4 Nov 2016 15:40:53 +0100 Message-ID: References: <1476871709-8359-1-git-send-email-jbrunet@baylibre.com> <1476871709-8359-5-git-send-email-jbrunet@baylibre.com> <1477040798.15560.96.camel@baylibre.com> <1477400900.2482.51.camel@baylibre.com> <1477405332.2482.87.camel@baylibre.com> <1477409478.2482.113.camel@baylibre.com> <1477491766.2482.159.camel@baylibre.com> <7hk2cvrtxt.fsf@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <7hk2cvrtxt.fsf@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Kevin Hilman , Alexandre TORGUE , Maxime Coquelin Cc: Jerome Brunet , Marc Zyngier , Carlo Caione , "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Thomas Gleixner , Jason Cooper , Rob Herring , Catalin Marinas , Will Deacon , Russell King List-Id: linux-gpio@vger.kernel.org On Wed, Oct 26, 2016 at 5:50 PM, Kevin Hilman wrote: >> Yes they are all wrong. They should all be using irq_find_mapping(). > > So, dumb question from someone trying (but having a hard time) to follow > and understand the rationale... > > If it's wrong enough to completely reject, why are changes still being > merged that are doing it so wrong? (e.g. like this one[1], just merged > for v4.9) It's a bug. It's that problem that Wolfram brought up in a recent lecture about maintainer scaling: if noone but the subsystem maintainer reviews the code, things like this will happen. I need more review... > [1] 0eb9f683336d pinctrl: Add IRQ support to STM32 gpios > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/stm32/pinctrl-stm32.c?id=0eb9f683336d7eb99a3b75987620417c574ffb57 Alexandre, Maxime: can you please make a patch for the STM32 driver that remove the semantic dependence for .to_irq() to be called before an interrupt can be used? It should be possible to use the irqs directly from the irqchip. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935009AbcKDOk5 (ORCPT ); Fri, 4 Nov 2016 10:40:57 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:36850 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934988AbcKDOkz (ORCPT ); Fri, 4 Nov 2016 10:40:55 -0400 MIME-Version: 1.0 In-Reply-To: <7hk2cvrtxt.fsf@baylibre.com> References: <1476871709-8359-1-git-send-email-jbrunet@baylibre.com> <1476871709-8359-5-git-send-email-jbrunet@baylibre.com> <1477040798.15560.96.camel@baylibre.com> <1477400900.2482.51.camel@baylibre.com> <1477405332.2482.87.camel@baylibre.com> <1477409478.2482.113.camel@baylibre.com> <1477491766.2482.159.camel@baylibre.com> <7hk2cvrtxt.fsf@baylibre.com> From: Linus Walleij Date: Fri, 4 Nov 2016 15:40:53 +0100 Message-ID: Subject: Re: [PATCH 4/9] pinctrl: meson: allow gpio to request irq To: Kevin Hilman , Alexandre TORGUE , Maxime Coquelin Cc: Jerome Brunet , Marc Zyngier , Carlo Caione , "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Thomas Gleixner , Jason Cooper , Rob Herring , Catalin Marinas , Will Deacon , Russell King Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2016 at 5:50 PM, Kevin Hilman wrote: >> Yes they are all wrong. They should all be using irq_find_mapping(). > > So, dumb question from someone trying (but having a hard time) to follow > and understand the rationale... > > If it's wrong enough to completely reject, why are changes still being > merged that are doing it so wrong? (e.g. like this one[1], just merged > for v4.9) It's a bug. It's that problem that Wolfram brought up in a recent lecture about maintainer scaling: if noone but the subsystem maintainer reviews the code, things like this will happen. I need more review... > [1] 0eb9f683336d pinctrl: Add IRQ support to STM32 gpios > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/stm32/pinctrl-stm32.c?id=0eb9f683336d7eb99a3b75987620417c574ffb57 Alexandre, Maxime: can you please make a patch for the STM32 driver that remove the semantic dependence for .to_irq() to be called before an interrupt can be used? It should be possible to use the irqs directly from the irqchip. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Fri, 4 Nov 2016 15:40:53 +0100 Subject: [PATCH 4/9] pinctrl: meson: allow gpio to request irq In-Reply-To: <7hk2cvrtxt.fsf@baylibre.com> References: <1476871709-8359-1-git-send-email-jbrunet@baylibre.com> <1476871709-8359-5-git-send-email-jbrunet@baylibre.com> <1477040798.15560.96.camel@baylibre.com> <1477400900.2482.51.camel@baylibre.com> <1477405332.2482.87.camel@baylibre.com> <1477409478.2482.113.camel@baylibre.com> <1477491766.2482.159.camel@baylibre.com> <7hk2cvrtxt.fsf@baylibre.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 26, 2016 at 5:50 PM, Kevin Hilman wrote: >> Yes they are all wrong. They should all be using irq_find_mapping(). > > So, dumb question from someone trying (but having a hard time) to follow > and understand the rationale... > > If it's wrong enough to completely reject, why are changes still being > merged that are doing it so wrong? (e.g. like this one[1], just merged > for v4.9) It's a bug. It's that problem that Wolfram brought up in a recent lecture about maintainer scaling: if noone but the subsystem maintainer reviews the code, things like this will happen. I need more review... > [1] 0eb9f683336d pinctrl: Add IRQ support to STM32 gpios > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/stm32/pinctrl-stm32.c?id=0eb9f683336d7eb99a3b75987620417c574ffb57 Alexandre, Maxime: can you please make a patch for the STM32 driver that remove the semantic dependence for .to_irq() to be called before an interrupt can be used? It should be possible to use the irqs directly from the irqchip. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Fri, 4 Nov 2016 15:40:53 +0100 Subject: [PATCH 4/9] pinctrl: meson: allow gpio to request irq In-Reply-To: <7hk2cvrtxt.fsf@baylibre.com> References: <1476871709-8359-1-git-send-email-jbrunet@baylibre.com> <1476871709-8359-5-git-send-email-jbrunet@baylibre.com> <1477040798.15560.96.camel@baylibre.com> <1477400900.2482.51.camel@baylibre.com> <1477405332.2482.87.camel@baylibre.com> <1477409478.2482.113.camel@baylibre.com> <1477491766.2482.159.camel@baylibre.com> <7hk2cvrtxt.fsf@baylibre.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Wed, Oct 26, 2016 at 5:50 PM, Kevin Hilman wrote: >> Yes they are all wrong. They should all be using irq_find_mapping(). > > So, dumb question from someone trying (but having a hard time) to follow > and understand the rationale... > > If it's wrong enough to completely reject, why are changes still being > merged that are doing it so wrong? (e.g. like this one[1], just merged > for v4.9) It's a bug. It's that problem that Wolfram brought up in a recent lecture about maintainer scaling: if noone but the subsystem maintainer reviews the code, things like this will happen. I need more review... > [1] 0eb9f683336d pinctrl: Add IRQ support to STM32 gpios > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/stm32/pinctrl-stm32.c?id=0eb9f683336d7eb99a3b75987620417c574ffb57 Alexandre, Maxime: can you please make a patch for the STM32 driver that remove the semantic dependence for .to_irq() to be called before an interrupt can be used? It should be possible to use the irqs directly from the irqchip. Yours, Linus Walleij