From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 08/13] clk: add ARM syscon ICST device tree bindings Date: Fri, 23 Oct 2015 11:48:09 +0200 Message-ID: References: <1444916813-31024-1-git-send-email-linus.walleij@linaro.org> <1444916813-31024-9-git-send-email-linus.walleij@linaro.org> <20151015192325.GN4558@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20151015192325.GN4558-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Boyd Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Arnd Bergmann , Russell King , Pawel Moll , Mark Rutland , Marc Zyngier , Will Deacon , Rob Herring , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michael Turquette , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Oct 15, 2015 at 9:23 PM, Stephen Boyd wrote: > On 10/15, Linus Walleij wrote: >> +Required properties: >> +- lock-offset: the offset address into the system controller where the >> + unlocking register is located >> +- vco-offset: the offset address into the system controller where the >> + ICST control register is located (even 32 bit address) > > Is there any reason why we don't use a reg property for this? Usually reg = <> is used with two (or more) tokens: reg = ; The exception being things like I2C addresses which are just one token. Since in this case, there is a "mother" reg property in the syscon-compatible node, which we are indexing into, it is confusing to use the same name for subnodes. Also there is a bunch of precedents doing it like this for sybdevices to system controllers, just git grep offset Documentation/devicetree/bindings will give you a bunch of them. (Fixing the spelling comments.) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20151015192325.GN4558@codeaurora.org> References: <1444916813-31024-1-git-send-email-linus.walleij@linaro.org> <1444916813-31024-9-git-send-email-linus.walleij@linaro.org> <20151015192325.GN4558@codeaurora.org> Date: Fri, 23 Oct 2015 11:48:09 +0200 Message-ID: Subject: Re: [PATCH 08/13] clk: add ARM syscon ICST device tree bindings From: Linus Walleij To: Stephen Boyd Cc: "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , Russell King , Pawel Moll , Mark Rutland , Marc Zyngier , Will Deacon , Rob Herring , "devicetree@vger.kernel.org" , Michael Turquette , linux-clk@vger.kernel.org Content-Type: text/plain; charset=UTF-8 List-ID: On Thu, Oct 15, 2015 at 9:23 PM, Stephen Boyd wrote: > On 10/15, Linus Walleij wrote: >> +Required properties: >> +- lock-offset: the offset address into the system controller where the >> + unlocking register is located >> +- vco-offset: the offset address into the system controller where the >> + ICST control register is located (even 32 bit address) > > Is there any reason why we don't use a reg property for this? Usually reg = <> is used with two (or more) tokens: reg = ; The exception being things like I2C addresses which are just one token. Since in this case, there is a "mother" reg property in the syscon-compatible node, which we are indexing into, it is confusing to use the same name for subnodes. Also there is a bunch of precedents doing it like this for sybdevices to system controllers, just git grep offset Documentation/devicetree/bindings will give you a bunch of them. (Fixing the spelling comments.) Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Fri, 23 Oct 2015 11:48:09 +0200 Subject: [PATCH 08/13] clk: add ARM syscon ICST device tree bindings In-Reply-To: <20151015192325.GN4558@codeaurora.org> References: <1444916813-31024-1-git-send-email-linus.walleij@linaro.org> <1444916813-31024-9-git-send-email-linus.walleij@linaro.org> <20151015192325.GN4558@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Oct 15, 2015 at 9:23 PM, Stephen Boyd wrote: > On 10/15, Linus Walleij wrote: >> +Required properties: >> +- lock-offset: the offset address into the system controller where the >> + unlocking register is located >> +- vco-offset: the offset address into the system controller where the >> + ICST control register is located (even 32 bit address) > > Is there any reason why we don't use a reg property for this? Usually reg = <> is used with two (or more) tokens: reg = ; The exception being things like I2C addresses which are just one token. Since in this case, there is a "mother" reg property in the syscon-compatible node, which we are indexing into, it is confusing to use the same name for subnodes. Also there is a bunch of precedents doing it like this for sybdevices to system controllers, just git grep offset Documentation/devicetree/bindings will give you a bunch of them. (Fixing the spelling comments.) Yours, Linus Walleij