From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA54C64E7B for ; Tue, 24 Nov 2020 08:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0177C2075A for ; Tue, 24 Nov 2020 08:42:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mJUb4iGM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730771AbgKXImC (ORCPT ); Tue, 24 Nov 2020 03:42:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730763AbgKXImB (ORCPT ); Tue, 24 Nov 2020 03:42:01 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5214DC0613CF for ; Tue, 24 Nov 2020 00:42:01 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id s27so7737376lfp.5 for ; Tue, 24 Nov 2020 00:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wvJieEgip1g2WEMiOdWtOXx++qG4HU5IWILT3U6RFgs=; b=mJUb4iGMJjIWX8lPMq4tIdVYYwCQ67pBbsA+TPEjhQUqZSAatFbBhuCBKyZsKh8fCc JGpV0Cc2ww5FVkjK63FldrCA9Ig/lclWUIkH+vU/D421GHQ60WDTVS7RhVSTyJmRPPbm vlKNUUw+ltheJYgTJ6WBZ/vKeTtoG5+fj2fyzvIPf8kBhK4gxu6qfLs/P1Qgksfm4fvE gCqb1lv58LleBY/hA5uwf9esy/7WwKX1IeTsIZVNuXTpHvrVix6x+q/3uc+HHz85ECOP 7c8+s1vq6e5L2fQCf1ooqPCMlZ5x42ijySwcRxEE/jL/qA+EjXMtSGYmuBEFllkrARzE mNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wvJieEgip1g2WEMiOdWtOXx++qG4HU5IWILT3U6RFgs=; b=loAdSV6/OHoiyffDbyTkJmCrCeMo6nCRtdQ0kWzYQE2JXOjCNRcoCud+fpa7kQIrpb wVPKcelQZL+CGfSblBh0MJf/DGk6aOyxdECCXSEOw2hTavcT1zqHZ7VYChyJS2U1Wj1v Jg9fAglGp1Bi5w25y1J/v45N0VmFSBRHVj1jkzf6yZiMnyxVXIKFGGoiwttmcpGtDF2b cqr1Unrw0yFS9+FlvxLCVdRGRgwW1Io1TGx25e0bjz28YmBtgtJnp/uKI+w/rcS+UR7X cSTVfGeXpGZwRxPkRfW3TktI8cSBdxiimSWDAif6OlKXeCI8oGOEVNsfr5s4LtX7JXGn ZjeA== X-Gm-Message-State: AOAM532GFRIs/+9BZifYwwFP+MWS9RveCGGHqy1AIEzJMY3RUCp+eITL 0GsvW5VKWFyYbCHpC8JyWZNs/5YIMPXFOiec9OcIPA== X-Google-Smtp-Source: ABdhPJwq8vXwP1njCi8d7YRqNvXM/K6scFYWCwRR28xF1q8lPLVDfnosAP2q9vjrVciFTOlk0Ez/FkVcAKgB/NO8E4k= X-Received: by 2002:a19:7b06:: with SMTP id w6mr1430812lfc.260.1606207319854; Tue, 24 Nov 2020 00:41:59 -0800 (PST) MIME-Version: 1.0 References: <85263ce8b058e80cea25c6ad6383eb256ce96cc8.1604988979.git.frank@allwinnertech.com> In-Reply-To: <85263ce8b058e80cea25c6ad6383eb256ce96cc8.1604988979.git.frank@allwinnertech.com> From: Linus Walleij Date: Tue, 24 Nov 2020 09:41:49 +0100 Message-ID: Subject: Re: [RESEND PATCH 03/19] pinctrl: sunxi: Always call chained_irq_{enter, exit} in sunxi_pinctrl_irq_handler To: Frank Lee Cc: Frank Lee , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , stable , Maxime Ripard , Chen-Yu Tsai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Nov 10, 2020 at 7:24 AM Frank Lee wrote: > From: Yangtao Li > > It is found on many allwinner soc that there is a low probability that > the interrupt status cannot be read in sunxi_pinctrl_irq_handler. This > will cause the interrupt status of a gpio bank to always be active on > gic, preventing gic from responding to other spi interrupts correctly. > > So we should call the chained_irq_* each time enter sunxi_pinctrl_irq_handler(). > > Cc: stable@vger.kernel.org > Signed-off-by: Yangtao Li Patch applied. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7256EC2D0E4 for ; Tue, 24 Nov 2020 08:42:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6015206FA for ; Tue, 24 Nov 2020 08:42:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AE+QErsf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mJUb4iGM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6015206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U0hmEvuTzmqY0VLqV2zjFKAxmI+/u2WwTfSRi/+yTTU=; b=AE+QErsfPEPwjBEI2hDm+blwQ coe1a+S4tJ+TXDjAJ5dYogX+x00j5y//VlZoMf7zAL0XWUt0eCfUQIbTEtbOv8DI//UaITsSPLxP/ HGJ19XCJjOuZ3hoCoyK1P6dbLtAdZnX6xKGGbM1uye4zm3zuA0xhGswmf+pdRM1qp/XfYOGdmDRTE rkFIEkv7LBOXvMRAldnqbWvkHb5/lR9IBMMOqY+pFnXepHmbt7iB5FNh/v+qvYW9+kloEXP0P1VcC uLh7q5st2d4if072XjqiQcwzAoinLUR69YGzEvkvRsXVkanhOV0QSWIy/Xp68sxkCTrNxlEl/w83Q 9cghHeVag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khTtk-0005Cc-AO; Tue, 24 Nov 2020 08:42:04 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khTth-0005Bv-LN for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 08:42:02 +0000 Received: by mail-lf1-x141.google.com with SMTP id j205so27702217lfj.6 for ; Tue, 24 Nov 2020 00:42:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wvJieEgip1g2WEMiOdWtOXx++qG4HU5IWILT3U6RFgs=; b=mJUb4iGMJjIWX8lPMq4tIdVYYwCQ67pBbsA+TPEjhQUqZSAatFbBhuCBKyZsKh8fCc JGpV0Cc2ww5FVkjK63FldrCA9Ig/lclWUIkH+vU/D421GHQ60WDTVS7RhVSTyJmRPPbm vlKNUUw+ltheJYgTJ6WBZ/vKeTtoG5+fj2fyzvIPf8kBhK4gxu6qfLs/P1Qgksfm4fvE gCqb1lv58LleBY/hA5uwf9esy/7WwKX1IeTsIZVNuXTpHvrVix6x+q/3uc+HHz85ECOP 7c8+s1vq6e5L2fQCf1ooqPCMlZ5x42ijySwcRxEE/jL/qA+EjXMtSGYmuBEFllkrARzE mNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wvJieEgip1g2WEMiOdWtOXx++qG4HU5IWILT3U6RFgs=; b=Q2htU5EZZ0wsuCz70BdcTYIVVi5U/BXXmiIJtGKlgp9+3tCAyxPqodqW7cRFdoqkLB eyt7Lhzd8b5WXXOnlfvynZ0vzaxL0o2KNEnEL3MlTZOtOuS4Rthdu98vW7kR6KWmCJh4 6Tc1/cwso2GTISccZ0OGVTp+qEYN+Sd8E51Be6UokTzcrPfXAQ52nLIYqcq7QtyeOYLo srgXS3Uzh+tz0e6fwuGZzGiqPrm3neSKs5RmuhdJMA6IgVLXbfSk6Vs8UzWKttoFNZ4G MveZ7S2cy8l5ftWwQMIauxXXzfCQNCpeMJtrUTlUeHh0wfsK5b50sxDMOmB47nMijLml 5kKA== X-Gm-Message-State: AOAM530OzSeKnNCbFWNlkHz0gBBYWqNP3/SQBqtBItRnSRCwlLOtZasn Xia62U5C3ubdUE6fQCEj4kIlPA9/ehUu9iAai5bxQA== X-Google-Smtp-Source: ABdhPJwq8vXwP1njCi8d7YRqNvXM/K6scFYWCwRR28xF1q8lPLVDfnosAP2q9vjrVciFTOlk0Ez/FkVcAKgB/NO8E4k= X-Received: by 2002:a19:7b06:: with SMTP id w6mr1430812lfc.260.1606207319854; Tue, 24 Nov 2020 00:41:59 -0800 (PST) MIME-Version: 1.0 References: <85263ce8b058e80cea25c6ad6383eb256ce96cc8.1604988979.git.frank@allwinnertech.com> In-Reply-To: <85263ce8b058e80cea25c6ad6383eb256ce96cc8.1604988979.git.frank@allwinnertech.com> From: Linus Walleij Date: Tue, 24 Nov 2020 09:41:49 +0100 Message-ID: Subject: Re: [RESEND PATCH 03/19] pinctrl: sunxi: Always call chained_irq_{enter, exit} in sunxi_pinctrl_irq_handler To: Frank Lee X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_034201_810217_2398338E X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Lee , "linux-kernel@vger.kernel.org" , stable , "open list:GPIO SUBSYSTEM" , Chen-Yu Tsai , Maxime Ripard , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 10, 2020 at 7:24 AM Frank Lee wrote: > From: Yangtao Li > > It is found on many allwinner soc that there is a low probability that > the interrupt status cannot be read in sunxi_pinctrl_irq_handler. This > will cause the interrupt status of a gpio bank to always be active on > gic, preventing gic from responding to other spi interrupts correctly. > > So we should call the chained_irq_* each time enter sunxi_pinctrl_irq_handler(). > > Cc: stable@vger.kernel.org > Signed-off-by: Yangtao Li Patch applied. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel