From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 2/4] drivers: gpio: msm: Fix the error condition for reading ngpio Date: Wed, 19 Jun 2013 21:45:01 +0200 Message-ID: References: <1371603747-27436-1-git-send-email-rvaswani@codeaurora.org> <1371603747-27436-3-git-send-email-rvaswani@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1371603747-27436-3-git-send-email-rvaswani@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Rohit Vaswani Cc: David Brown , Daniel Walker , Bryan Huntsman , Grant Likely , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-arm-msm@vger.kernel.org On Wed, Jun 19, 2013 at 3:02 AM, Rohit Vaswani wrote: > of_property_read_u32 return 0 on success. The check was using a ! to > return error. Fix the if condition. > > Signed-off-by: Rohit Vaswani Acked-by: Linus Walleij I guess this is going through the MSM tree as well? Yours, Linus Walleij