From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Date: Wed, 29 Mar 2017 04:30:43 +0200 Message-ID: References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> <1490026491-21742-3-git-send-email-jacopo+renesas@jmondi.org> <20170323160204.GL30223@w540> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: jacopo Cc: Geert Uytterhoeven , Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Tue, Mar 28, 2017 at 4:38 PM, wrote: >> The fact that historically all the early adopters of pinctrl in device >> tree >> have these funky custom bindings is unfortunate but just something >> that we need to live with. >> > > To avoid any confusion, please bear with me and clarify this once and for > all, > since I'm not certain I fully got you here. > > Are you suggesting: > > 1) Use "pins" property with the currently implemented ABI (which slightly > differs > from the standard documented one as explained above. Not sure it is fine > overriding > it or not) Correction: you should be using the property "pinmux", because you are setting group and function at the same time. See for example: include/dt-bindings/pinctrl/mt65xx.h And how that is used in: arch/arm/boot/dts/mt2701-pinfunc.h arch/arm/boot/dts/mt2701-evb.dts The docs are here: Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt I'm sorry that "pinmux" is not part of the generic documentation, it'd be great if you would like to add it with a patch. Yours, Linus Walleij