From: Linus Walleij <linus.walleij@linaro.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 0/4] iio: magnetometer: ak8974: support AMI306
Date: Fri, 18 Aug 2017 23:42:53 +0200 [thread overview]
Message-ID: <CACRpkdbcdxmL2QiNZzqaDNTkfsvgqb1Bw_nqc1ipW-fxmq6NLA@mail.gmail.com> (raw)
In-Reply-To: <cover.1502977929.git.mirq-linux@rere.qmqm.pl>
On Thu, Aug 17, 2017 at 3:56 PM, Micha=C5=82 Miros=C5=82aw
<mirq-linux@rere.qmqm.pl> wrote:
> This series adds support for AMI306 magnetometer. The device is very
> similar to already supported AMI305.
All four patches:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Very clear and to the point. Nice to see some wider use of this :)
> Calibration data is not used
> yet as I still need to figure out what it means.
Does your datasheet tell you how to convert to ISO units? Right now
the sensor only suppport raw data and it would be nice to support
IIO_CHAN_INFO_SCALE like e.g. ak8975.c does.
I bet the same scaling applies as to the other variants.
Yours,
Linus Walleij
prev parent reply other threads:[~2017-08-18 21:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 13:56 [PATCH 0/4] iio: magnetometer: ak8974: support AMI306 Michał Mirosław
2017-08-17 13:56 ` [PATCH 1/4] iio: magnetometer: ak8974: support AMI306 variant Michał Mirosław
2017-08-20 10:19 ` Jonathan Cameron
2017-08-17 13:56 ` [PATCH 3/4] iio: magnetometer: ak8974: mark INT_CLEAR as precious Michał Mirosław
2017-08-17 13:56 ` [PATCH 2/4] iio: magnetometer: ak8974: add_device_randomness(fw + serial) Michał Mirosław
2017-08-20 10:22 ` Jonathan Cameron
2017-08-20 11:10 ` Linus Walleij
2017-08-20 14:18 ` Jonathan Cameron
2017-08-17 13:56 ` [PATCH 4/4] iio: magnetometer: ak8974: debug AMI306 calibration data Michał Mirosław
2017-08-20 10:25 ` Jonathan Cameron
2017-08-20 10:28 ` Jonathan Cameron
2017-08-20 14:40 ` Jonathan Cameron
2017-08-18 21:42 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbcdxmL2QiNZzqaDNTkfsvgqb1Bw_nqc1ipW-fxmq6NLA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.