From: Linus Walleij <linus.walleij@linaro.org>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Steven Miao <realmz6@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
adi-buildroot-devel@lists.sourceforge.net,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.
Date: Wed, 7 Aug 2013 20:56:49 +0200 [thread overview]
Message-ID: <CACRpkdbfCZWqowT3i9+5kx=1BBYS5qEROpAzutHbDmQ-kQqc1g@mail.gmail.com> (raw)
In-Reply-To: <CAJxxZ0NHVRzHcFqy6V5_MzbRS9Dz8R5eLp6Oz+DF6SYLWB8r8w@mail.gmail.com>
On Thu, Aug 1, 2013 at 9:31 AM, Sonic Zhang <sonic.adi@gmail.com> wrote:
> On Tue, Jul 30, 2013 at 12:47 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> On Fri, Jul 26, 2013 at 6:57 AM, Sonic Zhang <sonic.adi@gmail.com> wrote:
>>
>>> Could you please comment on this patch set? It is based on your former comments.
>>
>> I'll get to it. I'm pretty choked right now and actually trying to have
>> some vacation at the same time.
>>
>> In the meantime, after glancing over and noting prolific use of the
>> unlikely() macro, please read the following articles:
>> http://lwn.net/Articles/70473/
>> http://lwn.net/Articles/420019/
>>
>
> These articles say the directives should be rarely used. Do you
> suggest to remove them from the patch?
I think so? Or can you make a case for them being in
a critical path, like have you run a profiler (such as perf)
on the code and come to the conclusion that it's really
needed for performance? In that case, spell it out in the
patch description.
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-08-07 18:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 10:55 [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x Sonic Zhang
2013-07-16 10:55 ` [PATCH 2/3] blackfin: gpio: Remove none gpio lib code Sonic Zhang
2013-07-23 7:33 ` Sonic Zhang
2013-07-26 4:57 ` Sonic Zhang
2013-08-14 15:34 ` Linus Walleij
2013-07-16 10:55 ` [PATCH 3/3] blackfin: pinctrl-adi2: Add pin control device groups and function data Sonic Zhang
2013-07-23 7:33 ` Sonic Zhang
2013-07-26 4:58 ` Sonic Zhang
2013-08-14 15:39 ` Linus Walleij
2013-07-23 7:32 ` [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x Sonic Zhang
2013-07-26 4:57 ` Sonic Zhang
2013-07-29 16:47 ` Linus Walleij
2013-08-01 7:31 ` Sonic Zhang
2013-08-07 18:56 ` Linus Walleij [this message]
2013-08-08 3:07 ` Sonic Zhang
2013-08-14 13:47 ` Linus Walleij
2013-08-16 6:23 ` Sonic Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbfCZWqowT3i9+5kx=1BBYS5qEROpAzutHbDmQ-kQqc1g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=realmz6@gmail.com \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.