From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DC1C433E0 for ; Mon, 25 May 2020 11:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90430204EF for ; Mon, 25 May 2020 11:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wntl+SwB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390354AbgEYLq5 (ORCPT ); Mon, 25 May 2020 07:46:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390165AbgEYLq4 (ORCPT ); Mon, 25 May 2020 07:46:56 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDBDDC061A0E for ; Mon, 25 May 2020 04:46:55 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id c11so18272668ljn.2 for ; Mon, 25 May 2020 04:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NtZVEMzdq38fu53lZDWzc8NBLCjAY5aGK/W4AvmImNs=; b=wntl+SwBMbjTVLSjCzfXL4lZBWDORiVo7jKBQtyuJNmBEa+JX+hFHc90oI5p93MmIw 7Vku1Od56aWGJjM8UzLHBbWv+TBowntLoOoTlqUjBXHTYoXg8tMmLyEDUnwOnoM0B9VU dLG6zfe5wvjWBRaB0I32BcY9J6R2ZooI1C60ko4ij26+NS4CFS6ckhes3zzE6XgZ3ZjH 59pLQE3IiKWc1IVka37TGUAnSPIlQ/zYfSW8rDeTmVQnrAaLT6cy7yvZeElaMEILicsd jJUmutQrVef6xE+GmQiC6z6zwASoOZP7gu1UkLOKiwWPimCbxlm4I61EXYqJPc0hZ7KG vNfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NtZVEMzdq38fu53lZDWzc8NBLCjAY5aGK/W4AvmImNs=; b=lXuT7PplrRNa4AXgrQf5p5+B9VS+A44WJKrTcbn14n6Cm7fFjlOjp+xW+bEUOSMyAw TWZXn4MIolgKbLhiKZJwS7fFsaXTtm9cA2vhEafZhdeEnawcMXLb76jHIjl16UiODE3x 40wFP6725Opeo1WRTcjftvuzgE3QYD4JZxwEwsAFLpqFyc0LQ52XwHDUYE2OVjrf/AG2 W2H1ExrKpitF3Qz6CeULcLv9rUegB3IT4Yz1nHAkXSk6oWIW17WirY4BPrqiUvrFE7lb b2M6ceBECNzJ4oZXbEdA+0Vxm6jb9bcgBbJ4nBKThHpQMDlKSd+g2FKoK6Oyrli0rk/R zzUg== X-Gm-Message-State: AOAM530YQK3ktTSni4sy8YgGn/m46JYxrbvRWYwN4SGaI3+Bh2YtIYDP HRqvpnfag9HrOMreMsEFWhliNPj0IZ3s94MgRE8fDA== X-Google-Smtp-Source: ABdhPJw5ECdRR0sT2j9LkRJkgjus2cyG5DJ9ePNpehKNpHs1eYNP0nQD76ry5+o8e6vYyTFN7E8BrPnW3RB52TR3RaY= X-Received: by 2002:a2e:b5b0:: with SMTP id f16mr1271162ljn.100.1590407214125; Mon, 25 May 2020 04:46:54 -0700 (PDT) MIME-Version: 1.0 References: <20200523170859.50003-1-sudeep.holla@arm.com> <20200523170859.50003-7-sudeep.holla@arm.com> In-Reply-To: <20200523170859.50003-7-sudeep.holla@arm.com> From: Linus Walleij Date: Mon, 25 May 2020 13:46:43 +0200 Message-ID: Subject: Re: [PATCH 6/8] soc: ux500: Use custom soc attribute group instead of device_create_file To: Sudeep Holla Cc: "linux-kernel@vger.kernel.org" , Linux ARM , Arnd Bergmann , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried to use it, it was found lot of existing custom > attributes can moved to use it instead of device_create_file. > > Though most of these never remove/cleanup the custom attribute as they > never call soc_device_unregister, using these custom attribute group > eliminate the need for any cleanup as the driver infrastructure will > take care of that. > > Let us remove device_create_file and start using the custom attribute > group in soc_device_attribute. > > Cc: Linus Walleij > Signed-off-by: Sudeep Holla Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6724DC433DF for ; Mon, 25 May 2020 11:47:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BA58204EF for ; Mon, 25 May 2020 11:47:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D7gTnip0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wntl+SwB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BA58204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ERtTTBriS6BXbItgIL+sd9zjZjU10+jFw3EWNCSEn+k=; b=D7gTnip0WQx/UN CGcOqPgT5HV425yclIl58q+SF51qgZz6sldA9vmBLyUrFMDzets3CPIDRkJ6cKiFgTsqJ7qVagpU1 iIIq0xUMSFPmTd9eFp5IZnflRXnlozzcfQ9Jwg7QRYY2bZLFlwNPi4ABDM48aVTFRUjBUm3PkuAjX poLnpJCKazbqt01f4DEr19OrmQdx7JjIiP9uTlUrSKndOWeOZnGd/FKafsM5pmlsbH/GZzZephqYR ggTX1Xh7LuiltiJdRLnbd6caIPkANaQ+Uo39zgw0hYzwo+Cyk3smJOGMTCagvmCr2z1C9sCjPaz6P LPWLTv171FDPXxmMTmwA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdBZO-0005wF-Uo; Mon, 25 May 2020 11:47:02 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdBZI-0005qR-1o for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 11:47:00 +0000 Received: by mail-lj1-x243.google.com with SMTP id o14so20479942ljp.4 for ; Mon, 25 May 2020 04:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NtZVEMzdq38fu53lZDWzc8NBLCjAY5aGK/W4AvmImNs=; b=wntl+SwBMbjTVLSjCzfXL4lZBWDORiVo7jKBQtyuJNmBEa+JX+hFHc90oI5p93MmIw 7Vku1Od56aWGJjM8UzLHBbWv+TBowntLoOoTlqUjBXHTYoXg8tMmLyEDUnwOnoM0B9VU dLG6zfe5wvjWBRaB0I32BcY9J6R2ZooI1C60ko4ij26+NS4CFS6ckhes3zzE6XgZ3ZjH 59pLQE3IiKWc1IVka37TGUAnSPIlQ/zYfSW8rDeTmVQnrAaLT6cy7yvZeElaMEILicsd jJUmutQrVef6xE+GmQiC6z6zwASoOZP7gu1UkLOKiwWPimCbxlm4I61EXYqJPc0hZ7KG vNfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NtZVEMzdq38fu53lZDWzc8NBLCjAY5aGK/W4AvmImNs=; b=nuUuV2oYq8SHa8Na/Pi6ewQUkTmC4z63eDjpMEixauYr7uVjE+2Tg2jNgL5lYp9U1j h4jt8AA4JXGrLc2PhxZvKudSFdMKa59Al/iKzZAClWIPy99pfsljMp4ppZuWFCUa8q8L AkOD3Al9uwZum4UJ9SQdxClbBvGbZwdxAW+VpSVdFmUdmFp0WxnPP4Bt+Oycg9mRC9Dk vgqJKaHi2SPi2NnqbmDoJwC7NGoviHp0ApBhhnZutoW0Zri+UuxeugbTKI4lUTQ1t6Dq zJ3pmMQbgFzk2gP0KW41n5aRH7ATjUkAU/UCjb5u5W/TpbMaLcycC+X746BTut3ShIjv 2CDQ== X-Gm-Message-State: AOAM530lGlp7VENIowreUMv3ukw4naFfFjSHPyqPMvdlJ6k/dG1vvKfk cIslpZNcJUOQOrDcAHTWPC5+p8nkBn7XabaS8u7TJg== X-Google-Smtp-Source: ABdhPJw5ECdRR0sT2j9LkRJkgjus2cyG5DJ9ePNpehKNpHs1eYNP0nQD76ry5+o8e6vYyTFN7E8BrPnW3RB52TR3RaY= X-Received: by 2002:a2e:b5b0:: with SMTP id f16mr1271162ljn.100.1590407214125; Mon, 25 May 2020 04:46:54 -0700 (PDT) MIME-Version: 1.0 References: <20200523170859.50003-1-sudeep.holla@arm.com> <20200523170859.50003-7-sudeep.holla@arm.com> In-Reply-To: <20200523170859.50003-7-sudeep.holla@arm.com> From: Linus Walleij Date: Mon, 25 May 2020 13:46:43 +0200 Message-ID: Subject: Re: [PATCH 6/8] soc: ux500: Use custom soc attribute group instead of device_create_file To: Sudeep Holla X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_044656_384792_EE7A37B4 X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried to use it, it was found lot of existing custom > attributes can moved to use it instead of device_create_file. > > Though most of these never remove/cleanup the custom attribute as they > never call soc_device_unregister, using these custom attribute group > eliminate the need for any cleanup as the driver infrastructure will > take care of that. > > Let us remove device_create_file and start using the custom attribute > group in soc_device_attribute. > > Cc: Linus Walleij > Signed-off-by: Sudeep Holla Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel