From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4791AC433EF for ; Thu, 30 Jun 2022 11:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235159AbiF3L5G (ORCPT ); Thu, 30 Jun 2022 07:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235128AbiF3L5F (ORCPT ); Thu, 30 Jun 2022 07:57:05 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1A765A452 for ; Thu, 30 Jun 2022 04:57:01 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-317a66d62dfso176383387b3.7 for ; Thu, 30 Jun 2022 04:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T2nf43YSG2Rmj+bAJwbn+WqQ9U0uX95RW/bS0f0BEIk=; b=xX22BKzLNWetYuGqacglbCbctbEFAqaw/9VSCakoyY1uZ/lUsbRrOi5MPNjNdCKQN7 auegeivkAV5FQ+lTQkNytjNOQrKUT15ORn8L+4LjcV4/uZT3Ecv8R4+ZE2VzN/1pkJCB LTWU6L9wNQlbxiWOMY3eRQzSab60pao7/ezDEKGrL6FPkEZrhFYs3flAtJlnGJ67hw+W DuugEAx86feg+q2PbjwxvDQ7IXtr/G2VXfl/TsXaUiX539ecJD45jYNRoQ5QyTV8/qgz 8Y5gnJ6P5kyLFyFoIGcVUWqtd/mvRLwwkDlWsR9NkgrPm0BFzV0FtoyvPPkJU/bWtbjE CpQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T2nf43YSG2Rmj+bAJwbn+WqQ9U0uX95RW/bS0f0BEIk=; b=eMlM6DtghVdh/UIAqCl0kkICobytqcwvsiXD2q9BAMG1cEGAg9SFDnbtWkcyelB87P 1P6Nauwpa32sBBJUqA4QSEqaS9L5IMprEBJan7oDWzbCRO9WDYcwfM88BO8zmqGN0QLv dgkTJNQIQje93HoNXL9IFeVH3Nn41ubY8pWkHd1iZ2DDPbMq/ML3S0fdU/CX+aHijr98 iGkTt9wAL3y5TSQP50u2O5/P0o1cA9rLS97vGOkZoE44E5XGn/TdvyQWmvHb1mNNSDxh 4MwJCyi+IlO3WqbN/iF356FXOYMqCo4T/iQlumS64qcLBUmXpcxTBvN1sFdeKZ3CEf53 VZQg== X-Gm-Message-State: AJIora//VQDjptcjTQoHKkAT8WebWyjEjzG9IDVVqlcIe+K0PXTwTZuT CTmQO2qR4TfKnHpbID0u6giekE+owcfCib7BKk/FSQ== X-Google-Smtp-Source: AGRyM1vpjSh9Y05u4DDxMAgxG1Ha5a6O1Yp1CqeRVvx6hQ7LjjtidYeoQ5W9aC0ImR5rk487POkEk9TQdl0wKxfgqfc= X-Received: by 2002:a81:d05:0:b0:317:76a1:9507 with SMTP id 5-20020a810d05000000b0031776a19507mr10201231ywn.151.1656590220853; Thu, 30 Jun 2022 04:57:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628081709.829811-1-colin.foster@in-advantage.com> <20220628081709.829811-4-colin.foster@in-advantage.com> <20220628182535.GC855398@euler> In-Reply-To: From: Linus Walleij Date: Thu, 30 Jun 2022 13:56:49 +0200 Message-ID: Subject: Re: [PATCH v11 net-next 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module To: Andy Shevchenko Cc: Colin Foster , devicetree , Linux Kernel Mailing List , netdev , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Vladimir Oltean , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Wolfram Sang , Terry Bowman , Florian Fainelli Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Jun 28, 2022 at 9:00 PM Andy Shevchenko wrote: > > On Tue, Jun 28, 2022 at 8:25 PM Colin Foster > wrote: > > On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote: > > > On Tue, Jun 28, 2022 at 10:17 AM Colin Foster > > > wrote: > > ... > > > > > builtin_platform_driver(ocelot_pinctrl_driver); > > > > > > This contradicts the logic behind this change. Perhaps you need to > > > move to module_platform_driver(). (Yes, I think functionally it won't > > > be any changes if ->remove() is not needed, but for the sake of > > > logical correctness...) > > > > I'll do this. Thanks. > > > > Process question: If I make this change is it typical to remove all > > Reviewed-By tags? I assume "yes" > > I would not. This change is logical continuation and I truly believe > every reviewer will agree on it. I would have to think hard to remember a single review comment from Andy where I didn't think "ah, yeah he's right", so definately keep mine. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9873C433EF for ; Thu, 30 Jun 2022 11:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+xqN1dn3G6xd+paZrg2FAZO5uruOEyfs/seIzLnPBsU=; b=Po8r4D1El5iwS7 scOVvdx4CughWzV6l1jPmsXn77AaEHZBINZ5RL9IH7s2JgnmARXxOexpv+jnEp/NbYPBZGdQmmCAV c6NUpH/HmKqg9xVqxJ4SAJTk60bIaaaDwmnNIZqB2P/cjxq94ylNTW4ACY0wbUwKmnWiY/VATiChK ffp8yy7KWpK9C/R2px6LSXGdprPO+Ak1AbfebNuuVCYqEUOWjwS6e5iTULc+kREMMQcvnwkNJkcXb aF4rGqR2l5unVlX2u9yGJppYWrQa+Y5wwpniZtngSBHCUACAjKIuUHSFRwgBh5h75YF5oNyFGdndV lt0usxlUutz7woDPD2BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6snH-00GypQ-SB; Thu, 30 Jun 2022 11:57:12 +0000 Received: from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6snE-00Gyl9-Se for linux-arm-kernel@lists.infradead.org; Thu, 30 Jun 2022 11:57:10 +0000 Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-31780ad7535so176362267b3.8 for ; Thu, 30 Jun 2022 04:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T2nf43YSG2Rmj+bAJwbn+WqQ9U0uX95RW/bS0f0BEIk=; b=xX22BKzLNWetYuGqacglbCbctbEFAqaw/9VSCakoyY1uZ/lUsbRrOi5MPNjNdCKQN7 auegeivkAV5FQ+lTQkNytjNOQrKUT15ORn8L+4LjcV4/uZT3Ecv8R4+ZE2VzN/1pkJCB LTWU6L9wNQlbxiWOMY3eRQzSab60pao7/ezDEKGrL6FPkEZrhFYs3flAtJlnGJ67hw+W DuugEAx86feg+q2PbjwxvDQ7IXtr/G2VXfl/TsXaUiX539ecJD45jYNRoQ5QyTV8/qgz 8Y5gnJ6P5kyLFyFoIGcVUWqtd/mvRLwwkDlWsR9NkgrPm0BFzV0FtoyvPPkJU/bWtbjE CpQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T2nf43YSG2Rmj+bAJwbn+WqQ9U0uX95RW/bS0f0BEIk=; b=CyHQCUBlB4/ufwMtVGAVsn7PvzoaYICzUT2Nlsko4g/x18ZslW6ejdeCOQfP6CKxO1 q5sHGNieDypJwVz2hoIj9om+WGeYLJE8AUToiTeZVVRfcW6x50fliqapjhXiW0wJy2L7 4vccW6vvMo2Gd1XSzz0C0WpnCC6yc6PJkMxsE45uiFlhVR/fBsOk3P0Oub2GVIJyKVuL RJ5Ru/nqsb791SUOlfnxsxeMlnIgWFKIfj1RGJbISbLlm0FpLnsMqAg/BgY0M3+Hpl/K tlZ0KSnCYY9LYpNfSlZo78GApdugjdALh26bYQd40xQm5MRrHaLvKHjxRMBn5mB0QxUY vgzg== X-Gm-Message-State: AJIora89bD6oPLXvUc2Rbu814BUw28ySTRtu5sfqBZ1dQD4cbm1eBCmO c7vCkIByfPXZtm/EtCwAFF8peeecbFGnTfG58AMw+g== X-Google-Smtp-Source: AGRyM1vpjSh9Y05u4DDxMAgxG1Ha5a6O1Yp1CqeRVvx6hQ7LjjtidYeoQ5W9aC0ImR5rk487POkEk9TQdl0wKxfgqfc= X-Received: by 2002:a81:d05:0:b0:317:76a1:9507 with SMTP id 5-20020a810d05000000b0031776a19507mr10201231ywn.151.1656590220853; Thu, 30 Jun 2022 04:57:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628081709.829811-1-colin.foster@in-advantage.com> <20220628081709.829811-4-colin.foster@in-advantage.com> <20220628182535.GC855398@euler> In-Reply-To: From: Linus Walleij Date: Thu, 30 Jun 2022 13:56:49 +0200 Message-ID: Subject: Re: [PATCH v11 net-next 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module To: Andy Shevchenko Cc: Colin Foster , devicetree , Linux Kernel Mailing List , netdev , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Vladimir Oltean , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Wolfram Sang , Terry Bowman , Florian Fainelli X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220630_045708_965692_58C54236 X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 28, 2022 at 9:00 PM Andy Shevchenko wrote: > > On Tue, Jun 28, 2022 at 8:25 PM Colin Foster > wrote: > > On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote: > > > On Tue, Jun 28, 2022 at 10:17 AM Colin Foster > > > wrote: > > ... > > > > > builtin_platform_driver(ocelot_pinctrl_driver); > > > > > > This contradicts the logic behind this change. Perhaps you need to > > > move to module_platform_driver(). (Yes, I think functionally it won't > > > be any changes if ->remove() is not needed, but for the sake of > > > logical correctness...) > > > > I'll do this. Thanks. > > > > Process question: If I make this change is it typical to remove all > > Reviewed-By tags? I assume "yes" > > I would not. This change is logical continuation and I truly believe > every reviewer will agree on it. I would have to think hard to remember a single review comment from Andy where I didn't think "ah, yeah he's right", so definately keep mine. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel