From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E318320A for ; Thu, 23 Mar 2023 08:36:28 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id y5so23909071ybu.3 for ; Thu, 23 Mar 2023 01:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679560587; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rUuy98YfrrGR9WlMIlTaa+4F/lCxj6Hdgjgj3ZONIGA=; b=Q7owO8OcLsAk4Smi2JWsWIKAzqfBJpGOHyVtF07hxl9piqNLJCWoW7ed4RVNmHjhGk ol3NRAXqNtaHo6lDY/g//4xjwt/zxo/2zoFknjy1zGZhizSaFw5hdgDuLK8RdU/zZVAH dCepbf77TgGhUbiTSUqhp684enkT1DtfqWYiu+D4zXHU39Q95c87S5jHYzWSUjmQidIr CR/bcZ9UWgx4ZwxmbVTnGPjgT3U1OF+r4Mp8yx8TwvEPJeXshXVD54tjYJO1ApHYyVfH z4fQSasarnufBSTBhpRbCiJTIbgj3WYu0exC/3/6OArXM7pWXh8QX0awOx12n+r31erH QTsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679560587; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rUuy98YfrrGR9WlMIlTaa+4F/lCxj6Hdgjgj3ZONIGA=; b=ezNHAAc2emS0X13imZIH+xzFOCJryMMvRwfeJe41J68sctWiC8UChR2I5vghCxXz+Z ETG9sXyqJeXmUaxAV7Bn5ZnFj3ejKUmimNVAd5E/SVIgLeoDPfbTCvYqK8a4WtEjLxTL nl+4NCctaCzt/a0obKKG8Ddk+5Ag1FGP0z2D5uIfD5DTI9qFrE7jVerjCFcVIpRcMU7I hLxT/uHCVIqzesmT0INyXP8JbmLPs9gXWGDClYnmyreGHgdEXtJOa+y5fWgrAzqJ7Jn0 hsYZrzAg/BscE/4U+ie+VOLSIaHocVfg6B4E0ZdGZgK07/G4Hqq/L0JaaQJvl7sQD6TN FJJw== X-Gm-Message-State: AAQBX9dpn9GeivO+zt3U8YK4UTZpFAAZPqIjHgGXRun5HO34sg6LZuMc ++mHtf7J4XEgktveXIcxZSax833pei4zXGmiDbS16gRzcH17OJoc X-Google-Smtp-Source: AKy350bcnM7cm+AyBPl6E7Dhs+RovIUhLWC1y2V4vCJ+ybMyh+qGNl7hbQ/eRRAdXm8YoocIetQrjs3e6tsPxiaKuts= X-Received: by 2002:a05:6902:a93:b0:b23:4649:7ef3 with SMTP id cd19-20020a0569020a9300b00b2346497ef3mr1654862ybb.4.1679560587513; Thu, 23 Mar 2023 01:36:27 -0700 (PDT) Precedence: bulk X-Mailing-List: timestamp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230323012929.10815-1-dipenp@nvidia.com> <20230323012929.10815-5-dipenp@nvidia.com> In-Reply-To: <20230323012929.10815-5-dipenp@nvidia.com> From: Linus Walleij Date: Thu, 23 Mar 2023 09:36:16 +0100 Message-ID: Subject: Re: [PATCH V4 04/10] dt-bindings: timestamp: Add nvidia,gpio-controller To: Dipen Patel Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, timestamp@lists.linux.dev, krzysztof.kozlowski+dt@linaro.org, brgl@bgdev.pl, corbet@lwn.net, gregkh@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 23, 2023 at 2:29=E2=80=AFAM Dipen Patel wro= te: > Introducing nvidia,gpio-controller property from Tegra234 SoCs onwards. > This is done to help below case. > > Without this property code would look like: > if (of_device_is_compatible(dev->of_node, "nvidia,tegra194-gte-aon")) > hte_dev->c =3D gpiochip_find("tegra194-gpio-aon", > tegra_get_gpiochip_from_name); > else if (of_device_is_compatible(dev->of_node, "nvidia,tegra234-gte-aon")= ) > hte_dev->c =3D gpiochip_find("tegra234-gpio-aon", > tegra_get_gpiochip_from_name); > else > return -ENODEV; > > This means for every future addition of the compatible string, if else > condition statements have to be expanded. > > With the property: > gpio_ctrl =3D of_parse_phandle(dev->of_node, "nvidia,gpio-controller", 0)= ; > .... > hte_dev->c =3D gpiochip_find(gpio_ctrl, tegra_get_gpiochip_from_of_node); > > This simplifies the code significantly. The introdunction of this > property/binding does not break existing Tegra194 provider driver. > > Signed-off-by: Dipen Patel It is fair to assume that other operating systems will need this too so I interpret the commit message as an example of the issues faced by anyone making a driver for this HW. Reviewed-by: Linus Walleij Yours, Linus Walleij