From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB94C636CA for ; Sun, 18 Jul 2021 00:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CC3661108 for ; Sun, 18 Jul 2021 00:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231899AbhGRAUF (ORCPT ); Sat, 17 Jul 2021 20:20:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbhGRAUE (ORCPT ); Sat, 17 Jul 2021 20:20:04 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B56FFC061764 for ; Sat, 17 Jul 2021 17:17:06 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id q4so19633183ljp.13 for ; Sat, 17 Jul 2021 17:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X1WDN9LkkfTLodn/7AZmvdlWK3elCwMaUY4+s15zcjs=; b=lr/rWTTelnW7nH05zdzy9FmUTLjtt9x/tUlCN50zyyz+UyWy1fPUrp4MBwEazKLI1X 2tI09g2FvGKVdBNeR3iA0kePNjlxn4uF99kvRlbRpGmJBtM2bXfqPCvnMsV4fZEDXgOB cfwfCTZpRJpP8XCfwPBB5HLe6EFbcUx+r6SV3aYbkgX+R7j54g2UEufmNHwppKl+Dy60 eOF4MHP2iIoOLUblsBzMt0mEgLB7yhdJNOCfiHkbgnmudCLvzyCDPAW4uBSYjhD/V0iB QzT5UmxJpzVt0uhk/TARoTkXEq7y4rI/1NwAj9vsXfO4oc8lvVdfu0NPKzeKeoGF+Sjn KtGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X1WDN9LkkfTLodn/7AZmvdlWK3elCwMaUY4+s15zcjs=; b=FF/i24AL3ASbvpicLSgyxznkMAQAoq55iTe0wBj3FxLUtJkUkK5opkyM6b83/kFEIO J1P3RFEZ4E0/iRMXUP4ln+PXgn3IIBnAp1GVQMx0shoI27kQwDLwuZqUCOggvaw9+4O7 BgGguQbGJ9WHZN+iUwK64OfKOf43BCixtnF5J0tgp8lLjkz+ytxUXrZf3IvR8MjZyxtC afLkEwKoLFuUErf0Ujgwn5l5MWZl/smZOEWCiSSXZo5KyBNCFj3B+e017nxkmoKitmII fXcwvhvzx9OG4PQMXwWoaU0fhSHS5aBq5yd6936a0fY4qXNQRTSjHi4lFV+WIGSR+xQC 2lrQ== X-Gm-Message-State: AOAM533ODCET1ze3Q/OY3DNGWIXGKOcHCncjpviaRhZLQwtHOm/l9EKm MN+XpWZLOE6wt9TSKnWEO9wtb26GkKPTnbz4QCqyQg== X-Google-Smtp-Source: ABdhPJyH8Es5S0fiHP/hznaMowGfa4CiQ/5DqH3eELfDWrap1a8f9HW2gm8T83Kn6nYavVuv3RpCOGtt2aCb7jKivCo= X-Received: by 2002:a05:651c:160e:: with SMTP id f14mr7064711ljq.273.1626567424296; Sat, 17 Jul 2021 17:17:04 -0700 (PDT) MIME-Version: 1.0 References: <1626430843-23823-1-git-send-email-dillon.minfei@gmail.com> <1626430843-23823-2-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1626430843-23823-2-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Sun, 18 Jul 2021 02:16:53 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings To: dillon min Cc: "thierry.reding@gmail.com" , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Doug Anderson , Alexandre Torgue , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dillon, thanks for your patch! On Fri, Jul 16, 2021 at 12:20 PM wrote: > From: Dillon Min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: Dillon Min > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) This is a DBI feature so mention in the description that this is a DBI panel. > + spi-3wire: true > + > + spi-max-frequency: > + const: 10000000 > + > + port: true > + > +additionalProperties: false Please add regulator supplies for the power lines, it's fine not to implement code handling them in the driver but they should be in the bindings. For the ili9341 it should be vci-supply: description: Analog voltage supply (2.5 .. 3.3V) vddi-supply: description: Voltage supply for interface logic (1.65 .. 3.3 V) vddi-led-supply: description: Voltage supply for the LED driver (1.65 .. 3.3 V) Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3768C636CA for ; Sun, 18 Jul 2021 00:17:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF4A761108 for ; Sun, 18 Jul 2021 00:17:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF4A761108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AEBF6EAC9; Sun, 18 Jul 2021 00:17:07 +0000 (UTC) Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF3B66EACC for ; Sun, 18 Jul 2021 00:17:05 +0000 (UTC) Received: by mail-lj1-x22c.google.com with SMTP id h9so19690070ljm.5 for ; Sat, 17 Jul 2021 17:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X1WDN9LkkfTLodn/7AZmvdlWK3elCwMaUY4+s15zcjs=; b=lr/rWTTelnW7nH05zdzy9FmUTLjtt9x/tUlCN50zyyz+UyWy1fPUrp4MBwEazKLI1X 2tI09g2FvGKVdBNeR3iA0kePNjlxn4uF99kvRlbRpGmJBtM2bXfqPCvnMsV4fZEDXgOB cfwfCTZpRJpP8XCfwPBB5HLe6EFbcUx+r6SV3aYbkgX+R7j54g2UEufmNHwppKl+Dy60 eOF4MHP2iIoOLUblsBzMt0mEgLB7yhdJNOCfiHkbgnmudCLvzyCDPAW4uBSYjhD/V0iB QzT5UmxJpzVt0uhk/TARoTkXEq7y4rI/1NwAj9vsXfO4oc8lvVdfu0NPKzeKeoGF+Sjn KtGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X1WDN9LkkfTLodn/7AZmvdlWK3elCwMaUY4+s15zcjs=; b=KX0RlBbx5LYZ3sKAQkKF3NUX6W+4MgjUPi10vCyAfbIlCY7IeFR6SSo7lKmDbbrWpU ISytPa9HAFOb8pS8A8Qe1v+YIAeYN4x2r0AVCMoAWME/+KvYUGIoZswl0bl5bfV3Om5Z SN/tylwDju0JCAVrhqiuwQfxDzGvflAL+eSuBQV2gM61JJvXmYwF/r98C1isVpcTWR/i e0pHq/owA2Rl0m67CkAklLfJwo027yjacT4P067Id3PsZocsiX2xHN6uDeeGodZsTvHM DT/SDYp1IU80o/WhpU/pOgfsgPReBq7EU1CVuYUqMPbrb64IPLk73E6FSX5n8tWuKAjq C4lQ== X-Gm-Message-State: AOAM531lGUzuaRZrD0rvoX3/xrJKef9XiXUpd5GFT/5KhBJOpDBqUtyQ prRpGrDxDsOVP0olPzMH5QhPB0y7fkWx5zbKpbZh2Q== X-Google-Smtp-Source: ABdhPJyH8Es5S0fiHP/hznaMowGfa4CiQ/5DqH3eELfDWrap1a8f9HW2gm8T83Kn6nYavVuv3RpCOGtt2aCb7jKivCo= X-Received: by 2002:a05:651c:160e:: with SMTP id f14mr7064711ljq.273.1626567424296; Sat, 17 Jul 2021 17:17:04 -0700 (PDT) MIME-Version: 1.0 References: <1626430843-23823-1-git-send-email-dillon.minfei@gmail.com> <1626430843-23823-2-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1626430843-23823-2-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Sun, 18 Jul 2021 02:16:53 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings To: dillon min Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Dave Airlie , linux-kernel , Doug Anderson , "open list:DRM PANEL DRIVERS" , Alexandre Torgue , Rob Herring , "thierry.reding@gmail.com" , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dillon, thanks for your patch! On Fri, Jul 16, 2021 at 12:20 PM wrote: > From: Dillon Min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: Dillon Min > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) This is a DBI feature so mention in the description that this is a DBI panel. > + spi-3wire: true > + > + spi-max-frequency: > + const: 10000000 > + > + port: true > + > +additionalProperties: false Please add regulator supplies for the power lines, it's fine not to implement code handling them in the driver but they should be in the bindings. For the ili9341 it should be vci-supply: description: Analog voltage supply (2.5 .. 3.3V) vddi-supply: description: Voltage supply for interface logic (1.65 .. 3.3 V) vddi-led-supply: description: Voltage supply for the LED driver (1.65 .. 3.3 V) Yours, Linus Walleij