From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9919CC433EF for ; Fri, 11 Feb 2022 00:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346215AbiBKAPi (ORCPT ); Thu, 10 Feb 2022 19:15:38 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346212AbiBKAPh (ORCPT ); Thu, 10 Feb 2022 19:15:37 -0500 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C81272E for ; Thu, 10 Feb 2022 16:15:37 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id g14so20274573ybs.8 for ; Thu, 10 Feb 2022 16:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E7OoL04aP+MZeQy8gEUASlkgu2toqHuHNgEWJOzWKkI=; b=STyD92iMRI0ITMeRrZZIgrsOTqWv1OtmvKboQgkN8aHCeb6qmGBZytZN5kIu8+b5AB FM95HInfiaDAapUiv/80ZCTLvpJgeTC/hvl1gCpJ08wK35dPxUz2ctLpohgB7m3nIj0Y WmO+83UiTjZSSEygrYn1m1c2lMnsa1k7yzX57aoMAgU82rQg1S9T46OlWV3M8urvhhGD 7okaYEU+fobCrAf3l6IwhUznoZR4ZQdjP7Z8hsI0Nar2PJGrmalR7C581w0B/kPRqvQ7 k8tgqGsGgyRu+J7ohCT3R4zi1SdWCWAyUAolivGpxAaxiG376F6K5TYtIjaM4xR+ZN9c SAfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E7OoL04aP+MZeQy8gEUASlkgu2toqHuHNgEWJOzWKkI=; b=h9UrELe2IBtyEnAnA8N4c7nxaTRFfRLnImsVPVqAPwKLRLEHKWtz6mahFNdM1t8o8i /3b/oymo8A85d116nODI7YPGDOqr2UFQ2KLKwNmNNS37TM10InSQd8/intfZhprTeITp FQMfK7INTf8BwbbD4MPwVkPjjsFK/182ixzwgmyXp6XGLtZTT3FiAtwhbonqI/+YvXbi 598BufjwMFiRHy5YIWP7Hn+HlPfEifoYuEmmdSZx/swD/VRjsIjIDHTZ7s8cNj5WLwpb LbxN3psZ0hMO3XePh+/I7ZeQZ7WV3cwpYFFrykWFRtZDiuXAVTQNBejzKIfLi/4TLRl1 3woA== X-Gm-Message-State: AOAM530PZoDbm5Z8lUnYfGX0vbLvtrAwwhWfrhymJjTtFJh9kpZVSbhd 7fLI2oq+OZfQC8efkDF1O7H4aTlFlpEsja/2VfxTZw== X-Google-Smtp-Source: ABdhPJy/Q5Zr/NTFpZq1apn9uDiuLsg2WFOhJqeZ3lViKWsIgjSwTxtM1oZy17C+JIqGLVdKS7iawzFxAzRAsAjiNVk= X-Received: by 2002:a25:103:: with SMTP id 3mr9355820ybb.110.1644538537279; Thu, 10 Feb 2022 16:15:37 -0800 (PST) MIME-Version: 1.0 References: <20220209162607.1118325-1-maz@kernel.org> <20220209162607.1118325-11-maz@kernel.org> <87zgmz3xbf.wl-maz@kernel.org> In-Reply-To: <87zgmz3xbf.wl-maz@kernel.org> From: Linus Walleij Date: Fri, 11 Feb 2022 01:15:25 +0100 Message-ID: Subject: Re: [PATCH 10/10] pinctrl: starfive: Switch to dynamic chip name output To: Marc Zyngier Cc: Emil Renner Berthing , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , Matthias Brugger , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Tony Lindgren , Thomas Gleixner , Vladimir Zapolskiy , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Feb 10, 2022 at 10:06 AM Marc Zyngier wrote: > On Wed, 09 Feb 2022 23:30:55 +0000, > Emil Renner Berthing wrote: > > The gpio framework seems to fill in default handlers in the struct > > above, so unfortunately it can't yet be made const. Is this something > > you intend to fix in the future? > > This is next on my list of things to address. The whole 'let's copy a > whole irqchip structure and hijack random pointers' should not have > happened, and it certainly is going to be an interesting ride. Sorry about that... Probably my bad idea. The only upside is that the things that are ugly are centralized to one spot. Yours, Linus Walleij