From: Linus Walleij <linus.walleij@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, Nishanth Menon <nm@ti.com>,
Simon Guinot <simon.guinot@sequanux.org>,
Jamie Lentin <jm@lentin.co.uk>
Subject: Re: [9/9] hwmon: gpio-fan: Convert to use GPIO descriptors
Date: Mon, 9 Oct 2017 01:05:56 +0200 [thread overview]
Message-ID: <CACRpkdbp6Eaw+CwJz9-8BLnnz-nAGuuXr_pkLecGjh_2nzZnAA@mail.gmail.com> (raw)
In-Reply-To: <20171008143927.GA8671@roeck-us.net>
On Sun, Oct 8, 2017 at 4:39 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>> @@ -86,9 +84,9 @@ static ssize_t fan1_alarm_show(struct device *dev,
>> struct device_attribute *attr, char *buf)
>> {
>> struct gpio_fan_data *fan_data = dev_get_drvdata(dev);
>> - int value = gpio_get_value_cansleep(fan_data->alarm_gpio);
>> + int value = gpiod_get_value_cansleep(fan_data->alarm_gpio);
>>
>> - if (fan_data->alarm_gpio_active_low)
>> + if (gpiod_is_active_low(fan_data->alarm_gpio))
>
> Is this still needed ? Just wondering - I would have thought that
> gpiod_get_value_cansleep() does the conversion.
My bad. Fixing in V2, sending it soon.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-10-08 23:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 23:09 [PATCH 0/9] GPIO controlled fans refactoring Linus Walleij
2017-09-25 23:09 ` [PATCH 1/9] hwmon: gpio-fan: Move DT bindings to the right place Linus Walleij
2017-10-05 20:31 ` Rob Herring
2017-10-08 14:21 ` [1/9] " Guenter Roeck
2017-10-08 14:21 ` Guenter Roeck
2017-09-25 23:09 ` [PATCH 2/9] hwmon: gpio-fan: Use local variable pointers Linus Walleij
2017-10-08 14:26 ` [2/9] " Guenter Roeck
2017-09-25 23:09 ` [PATCH 3/9] hwmon: gpio-fan: Localize platform data Linus Walleij
2017-09-25 23:09 ` [PATCH 4/9] hwmon: gpio-fan: Send around device pointer Linus Walleij
2017-10-08 14:28 ` [4/9] " Guenter Roeck
2017-09-25 23:09 ` [PATCH 5/9] hwmon: gpio-fan: Mandate OF_GPIO and cut pdata path Linus Walleij
2017-10-08 14:29 ` [5/9] " Guenter Roeck
2017-09-25 23:09 ` [PATCH 6/9] hwmon: gpio-fan: Get rid of platform data struct Linus Walleij
2017-10-08 14:32 ` [6/9] " Guenter Roeck
2017-09-25 23:09 ` [PATCH 7/9] hwmon: gpio-fan: Get rid of the gpio alarm struct Linus Walleij
2017-10-08 14:33 ` [7/9] " Guenter Roeck
2017-09-25 23:09 ` [PATCH 8/9] hwmon: gpio-fan: Rename GPIO line state variables Linus Walleij
2017-10-08 14:35 ` [8/9] " Guenter Roeck
2017-09-25 23:09 ` [PATCH 9/9] hwmon: gpio-fan: Convert to use GPIO descriptors Linus Walleij
2017-10-08 14:39 ` [9/9] " Guenter Roeck
2017-10-08 23:05 ` Linus Walleij [this message]
2017-10-08 16:20 ` Guenter Roeck
2017-10-08 23:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbp6Eaw+CwJz9-8BLnnz-nAGuuXr_pkLecGjh_2nzZnAA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=jdelvare@suse.com \
--cc=jm@lentin.co.uk \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nm@ti.com \
--cc=simon.guinot@sequanux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.