From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 02/11] clocksource:global_timer: Add ARM global timer support. Date: Tue, 11 Jun 2013 22:13:04 +0200 Message-ID: References: <1370855828-5318-1-git-send-email-srinivas.kandagatla@st.com> <1370856087-6452-1-git-send-email-srinivas.kandagatla@st.com> <51B5D7A6.1020101@st.com> <51B72E9A.6070006@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51B72E9A.6070006-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Srinivas KANDAGATLA Cc: Mauro Carvalho Chehab , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Will Deacon , Mike Turquette , Samuel Ortiz , Stephen Gallimore , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grant Likely , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Rob Herring , Stuart Menefy , Mark Brown , John Stultz , Russell King - ARM Linux , Thomas Gleixner , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Greg Kroah-Hartman , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Andrew List-Id: devicetree@vger.kernel.org On Tue, Jun 11, 2013 at 4:05 PM, Srinivas KANDAGATLA wrote: > Doing this is not adding any value to the driver, because > 1. Currently the driver only support DT boot paths, in my previous RFC > patches, Arnd suggested to get rid of the header as all platforms are DT > now. In that case why do you have the separate global_timer_init() at all? Just move that code into global_timer_of_register() and also remove the #ifdef around CONFIG_OF and make the driver depend on CONFIG_OF in Kconfig. After this you realize that all that business with clk_register_clkdev() / clk_get_sys() is just pure surplus baggade, you just use of_clk_get() and that's it. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Tue, 11 Jun 2013 22:13:04 +0200 Subject: [PATCH v2 02/11] clocksource:global_timer: Add ARM global timer support. In-Reply-To: <51B72E9A.6070006@st.com> References: <1370855828-5318-1-git-send-email-srinivas.kandagatla@st.com> <1370856087-6452-1-git-send-email-srinivas.kandagatla@st.com> <51B5D7A6.1020101@st.com> <51B72E9A.6070006@st.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 11, 2013 at 4:05 PM, Srinivas KANDAGATLA wrote: > Doing this is not adding any value to the driver, because > 1. Currently the driver only support DT boot paths, in my previous RFC > patches, Arnd suggested to get rid of the header as all platforms are DT > now. In that case why do you have the separate global_timer_init() at all? Just move that code into global_timer_of_register() and also remove the #ifdef around CONFIG_OF and make the driver depend on CONFIG_OF in Kconfig. After this you realize that all that business with clk_register_clkdev() / clk_get_sys() is just pure surplus baggade, you just use of_clk_get() and that's it. Yours, Linus Walleij